]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:smb_server: Add missing newlines to logging messages
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 7 Aug 2023 04:54:43 +0000 (16:54 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 8 Aug 2023 04:39:38 +0000 (04:39 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/smb_server/smb/negprot.c
source4/smb_server/smb/sesssetup.c
source4/smb_server/smb/trans2.c
source4/smb_server/smb2/receive.c
source4/smb_server/smb2/sesssetup.c

index cd2451d2e9c35b3c40c444e12fe1778d27d9fcc2..2d78d4e060d2424023acba7cbbdc67fc3de9951b 100644 (file)
@@ -49,13 +49,13 @@ static NTSTATUS get_challenge(struct smbsrv_connection *smb_conn, uint8_t buff[8
                                        smb_conn->lp_ctx,
                                        &smb_conn->negotiate.auth_context);
        if (!NT_STATUS_IS_OK(nt_status)) {
-               DEBUG(0, ("auth_context_create() returned %s", nt_errstr(nt_status)));
+               DEBUG(0, ("auth_context_create() returned %s\n", nt_errstr(nt_status)));
                return nt_status;
        }
 
        nt_status = auth_get_challenge(smb_conn->negotiate.auth_context, buff);
        if (!NT_STATUS_IS_OK(nt_status)) {
-               DEBUG(0, ("auth_get_challenge() returned %s", nt_errstr(nt_status)));
+               DEBUG(0, ("auth_get_challenge() returned %s\n", nt_errstr(nt_status)));
                return nt_status;
        }
 
index 00d927375a33b3796baca2ab898c342874913edf..69cbdca388cf18e6009ac00f889f8497638cda54 100644 (file)
@@ -519,14 +519,14 @@ static void sesssetup_spnego(struct smbsrv_request *req, union smb_sesssetup *se
                                                        req);
                if (!remote_address) {
                        status = NT_STATUS_INTERNAL_ERROR;
-                       DBG_ERR("Failed to obtain remote address");
+                       DBG_ERR("Failed to obtain remote address\n");
                        goto failed;
                }
 
                status = gensec_set_remote_address(gensec_ctx,
                                                   remote_address);
                if (!NT_STATUS_IS_OK(status)) {
-                       DBG_ERR("Failed to set remote address");
+                       DBG_ERR("Failed to set remote address\n");
                        goto failed;
                }
 
@@ -534,14 +534,14 @@ static void sesssetup_spnego(struct smbsrv_request *req, union smb_sesssetup *se
                                                        req);
                if (!local_address) {
                        status = NT_STATUS_INTERNAL_ERROR;
-                       DBG_ERR("Failed to obtain local address");
+                       DBG_ERR("Failed to obtain local address\n");
                        goto failed;
                }
 
                status = gensec_set_local_address(gensec_ctx,
                                                   local_address);
                if (!NT_STATUS_IS_OK(status)) {
-                       DBG_ERR("Failed to set local address");
+                       DBG_ERR("Failed to set local address\n");
                        goto failed;
                }
 
@@ -549,7 +549,7 @@ static void sesssetup_spnego(struct smbsrv_request *req, union smb_sesssetup *se
                                                               "SMB");
 
                if (!NT_STATUS_IS_OK(status)) {
-                       DBG_ERR("Failed to set service description");
+                       DBG_ERR("Failed to set service description\n");
                        goto failed;
                }
 
index fc357ed73f921969c5b6b1d08645fadc62c93bf4..1e2d93dc79eca5595d454433f6468a7e0660357c 100644 (file)
@@ -954,8 +954,8 @@ static NTSTATUS trans2_getdfsreferral(struct smbsrv_request *req,
                        }
 
                        if (outblob.length <= MAX_DFS_RESPONSE) {
-                               DEBUG(10,("DFS: managed to reduce the size of referral initial"
-                                         "number of referral %d, actual count: %d",
+                               DEBUG(10,("DFS: managed to reduce the size of referral initial "
+                                         "number of referral %d, actual count: %d\n",
                                          nb_referrals, r->out.resp->nb_referrals));
                                ok = true;
                                break;
@@ -964,7 +964,7 @@ static NTSTATUS trans2_getdfsreferral(struct smbsrv_request *req,
 
                if (!ok && r->out.resp->nb_referrals <= 2) {
                        DEBUG(8, (__location__ "; Not able to fit the domain and realm in DFS a "
-                                 " 56K buffer, something must be broken"));
+                                 " 56K buffer, something must be broken\n"));
                        talloc_free(r);
                        return NT_STATUS_INTERNAL_ERROR;
                }
index 2d0c377b13e473dbca7921a74cf6af1546225194..7818fdc48261b66c7485e38f46700b902e44fa22 100644 (file)
@@ -505,7 +505,7 @@ NTSTATUS smbsrv_recv_smb2_request(void *private_data, DATA_BLOB blob)
 
        /* see if its a special NBT packet */
        if (CVAL(blob.data,0) != 0) {
-               DEBUG(2,("Special NBT packet on SMB2 connection"));
+               DEBUG(2,("Special NBT packet on SMB2 connection\n"));
                smbsrv_terminate_connection(smb_conn, "Special NBT packet on SMB2 connection");
                return NT_STATUS_OK;
        }
index a8c45608cae0dd472159cef9880459748e94d77f..852218ddaea7fd9f59590277878e1beae951ec47 100644 (file)
@@ -151,14 +151,14 @@ static void smb2srv_sesssetup_backend(struct smb2srv_request *req, union smb_ses
                                                        req);
                if (!remote_address) {
                        status = NT_STATUS_INTERNAL_ERROR;
-                       DBG_ERR("Failed to obtain remote address");
+                       DBG_ERR("Failed to obtain remote address\n");
                        goto failed;
                }
 
                status = gensec_set_remote_address(gensec_ctx,
                                                   remote_address);
                if (!NT_STATUS_IS_OK(status)) {
-                       DBG_ERR("Failed to set remote address");
+                       DBG_ERR("Failed to set remote address\n");
                        goto failed;
                }
 
@@ -166,14 +166,14 @@ static void smb2srv_sesssetup_backend(struct smb2srv_request *req, union smb_ses
                                                      req);
                if (!local_address) {
                        status = NT_STATUS_INTERNAL_ERROR;
-                       DBG_ERR("Failed to obtain local address");
+                       DBG_ERR("Failed to obtain local address\n");
                        goto failed;
                }
 
                status = gensec_set_local_address(gensec_ctx,
                                                  local_address);
                if (!NT_STATUS_IS_OK(status)) {
-                       DBG_ERR("Failed to set local address");
+                       DBG_ERR("Failed to set local address\n");
                        goto failed;
                }
 
@@ -181,7 +181,7 @@ static void smb2srv_sesssetup_backend(struct smb2srv_request *req, union smb_ses
                                                               "SMB2");
 
                if (!NT_STATUS_IS_OK(status)) {
-                       DBG_ERR("Failed to set service description");
+                       DBG_ERR("Failed to set service description\n");
                        goto failed;
                }