]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
vhost: Do not abort on log-stop error
authorHanna Czenczek <hreitz@redhat.com>
Thu, 24 Jul 2025 12:59:28 +0000 (14:59 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 1 Aug 2025 12:33:04 +0000 (08:33 -0400)
Failing to stop logging in a vhost device is not exactly fatal.  We can
log such an error, but there is no need to abort the whole qemu process
because of it.

Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20250724125928.61045-3-hreitz@redhat.com>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/vhost.c

index 05ad5de629b4763a30d671c7e473cef396dd6a48..6557c58d12af2c60d160c027b538c4aad35d3087 100644 (file)
@@ -1122,7 +1122,8 @@ static void vhost_log_global_stop(MemoryListener *listener)
 
     r = vhost_migration_log(listener, false);
     if (r < 0) {
-        abort();
+        /* Not fatal, so report it, but take no further action */
+        warn_report("vhost: Failed to stop logging");
     }
 }