]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.10-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Feb 2023 11:11:57 +0000 (12:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 18 Feb 2023 11:11:57 +0000 (12:11 +0100)
added patches:
i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch
ixgbe-allow-to-increase-mtu-to-3k-with-xdp-enabled.patch
net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch
net-sched-tcindex-update-imperfect-hash-filters-respecting-rcu.patch
revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch
sctp-sctp_sock_filter-avoid-list_entry-on-possibly-empty-list.patch

queue-5.10/i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch [new file with mode: 0644]
queue-5.10/ixgbe-allow-to-increase-mtu-to-3k-with-xdp-enabled.patch [new file with mode: 0644]
queue-5.10/net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch [new file with mode: 0644]
queue-5.10/net-sched-tcindex-update-imperfect-hash-filters-respecting-rcu.patch [new file with mode: 0644]
queue-5.10/revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch [new file with mode: 0644]
queue-5.10/sctp-sctp_sock_filter-avoid-list_entry-on-possibly-empty-list.patch [new file with mode: 0644]
queue-5.10/series

diff --git a/queue-5.10/i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch b/queue-5.10/i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch
new file mode 100644 (file)
index 0000000..c19f21e
--- /dev/null
@@ -0,0 +1,33 @@
+From ce45ffb815e8e238f05de1630be3969b6bb15e4e Mon Sep 17 00:00:00 2001
+From: Jason Xing <kernelxing@tencent.com>
+Date: Wed, 8 Feb 2023 10:43:33 +0800
+Subject: i40e: add double of VLAN header when computing the max MTU
+
+From: Jason Xing <kernelxing@tencent.com>
+
+commit ce45ffb815e8e238f05de1630be3969b6bb15e4e upstream.
+
+Include the second VLAN HLEN into account when computing the maximum
+MTU size as other drivers do.
+
+Fixes: 0c8493d90b6b ("i40e: add XDP support for pass and drop actions")
+Signed-off-by: Jason Xing <kernelxing@tencent.com>
+Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
+Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel)
+Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/intel/i40e/i40e_main.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
++++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
+@@ -2788,7 +2788,7 @@ static int i40e_change_mtu(struct net_de
+       struct i40e_pf *pf = vsi->back;
+       if (i40e_enabled_xdp_vsi(vsi)) {
+-              int frame_size = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN;
++              int frame_size = new_mtu + I40E_PACKET_HDR_PAD;
+               if (frame_size > i40e_max_xdp_frame_size(vsi))
+                       return -EINVAL;
diff --git a/queue-5.10/ixgbe-allow-to-increase-mtu-to-3k-with-xdp-enabled.patch b/queue-5.10/ixgbe-allow-to-increase-mtu-to-3k-with-xdp-enabled.patch
new file mode 100644 (file)
index 0000000..b008fd9
--- /dev/null
@@ -0,0 +1,75 @@
+From f9cd6a4418bac6a046ee78382423b1ae7565fb24 Mon Sep 17 00:00:00 2001
+From: Jason Xing <kernelxing@tencent.com>
+Date: Wed, 8 Feb 2023 10:43:32 +0800
+Subject: ixgbe: allow to increase MTU to 3K with XDP enabled
+
+From: Jason Xing <kernelxing@tencent.com>
+
+commit f9cd6a4418bac6a046ee78382423b1ae7565fb24 upstream.
+
+Recently I encountered one case where I cannot increase the MTU size
+directly from 1500 to a much bigger value with XDP enabled if the
+server is equipped with IXGBE card, which happened on thousands of
+servers in production environment. After applying the current patch,
+we can set the maximum MTU size to 3K.
+
+This patch follows the behavior of changing MTU as i40e/ice does.
+
+References:
+[1] commit 23b44513c3e6 ("ice: allow 3k MTU for XDP")
+[2] commit 0c8493d90b6b ("i40e: add XDP support for pass and drop actions")
+
+Fixes: fabf1bce103a ("ixgbe: Prevent unsupported configurations with XDP")
+Signed-off-by: Jason Xing <kernelxing@tencent.com>
+Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
+Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel)
+Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |   25 ++++++++++++++++---------
+ 1 file changed, 16 insertions(+), 9 deletions(-)
+
+--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
++++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+@@ -6729,6 +6729,18 @@ static void ixgbe_free_all_rx_resources(
+ }
+ /**
++ * ixgbe_max_xdp_frame_size - returns the maximum allowed frame size for XDP
++ * @adapter: device handle, pointer to adapter
++ */
++static int ixgbe_max_xdp_frame_size(struct ixgbe_adapter *adapter)
++{
++      if (PAGE_SIZE >= 8192 || adapter->flags2 & IXGBE_FLAG2_RX_LEGACY)
++              return IXGBE_RXBUFFER_2K;
++      else
++              return IXGBE_RXBUFFER_3K;
++}
++
++/**
+  * ixgbe_change_mtu - Change the Maximum Transfer Unit
+  * @netdev: network interface device structure
+  * @new_mtu: new value for maximum frame size
+@@ -6739,18 +6751,13 @@ static int ixgbe_change_mtu(struct net_d
+ {
+       struct ixgbe_adapter *adapter = netdev_priv(netdev);
+-      if (adapter->xdp_prog) {
++      if (ixgbe_enabled_xdp_adapter(adapter)) {
+               int new_frame_size = new_mtu + ETH_HLEN + ETH_FCS_LEN +
+                                    VLAN_HLEN;
+-              int i;
+-
+-              for (i = 0; i < adapter->num_rx_queues; i++) {
+-                      struct ixgbe_ring *ring = adapter->rx_ring[i];
+-                      if (new_frame_size > ixgbe_rx_bufsz(ring)) {
+-                              e_warn(probe, "Requested MTU size is not supported with XDP\n");
+-                              return -EINVAL;
+-                      }
++              if (new_frame_size > ixgbe_max_xdp_frame_size(adapter)) {
++                      e_warn(probe, "Requested MTU size is not supported with XDP\n");
++                      return -EINVAL;
+               }
+       }
diff --git a/queue-5.10/net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch b/queue-5.10/net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch
new file mode 100644 (file)
index 0000000..a45b73a
--- /dev/null
@@ -0,0 +1,51 @@
+From d61615c366a489646a1bfe5b33455f916762d5f4 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
+Date: Wed, 8 Feb 2023 10:16:37 +0100
+Subject: net: bgmac: fix BCM5358 support by setting correct flags
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Rafał Miłecki <rafal@milecki.pl>
+
+commit d61615c366a489646a1bfe5b33455f916762d5f4 upstream.
+
+Code blocks handling BCMA_CHIP_ID_BCM5357 and BCMA_CHIP_ID_BCM53572 were
+incorrectly unified. Chip package values are not unique and cannot be
+checked independently. They are meaningful only in a context of a given
+chip.
+
+Packages BCM5358 and BCM47188 share the same value but then belong to
+different chips. Code unification resulted in treating BCM5358 as
+BCM47188 and broke its initialization.
+
+Link: https://github.com/openwrt/openwrt/issues/8278
+Fixes: cb1b0f90acfe ("net: ethernet: bgmac: unify code of the same family")
+Cc: Jon Mason <jdmason@kudzu.us>
+Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
+Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
+Link: https://lore.kernel.org/r/20230208091637.16291-1-zajec5@gmail.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/net/ethernet/broadcom/bgmac-bcma.c |    6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
++++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
+@@ -228,12 +228,12 @@ static int bgmac_probe(struct bcma_devic
+               bgmac->feature_flags |= BGMAC_FEAT_CLKCTLST;
+               bgmac->feature_flags |= BGMAC_FEAT_FLW_CTRL1;
+               bgmac->feature_flags |= BGMAC_FEAT_SW_TYPE_PHY;
+-              if (ci->pkg == BCMA_PKG_ID_BCM47188 ||
+-                  ci->pkg == BCMA_PKG_ID_BCM47186) {
++              if ((ci->id == BCMA_CHIP_ID_BCM5357 && ci->pkg == BCMA_PKG_ID_BCM47186) ||
++                  (ci->id == BCMA_CHIP_ID_BCM53572 && ci->pkg == BCMA_PKG_ID_BCM47188)) {
+                       bgmac->feature_flags |= BGMAC_FEAT_SW_TYPE_RGMII;
+                       bgmac->feature_flags |= BGMAC_FEAT_IOST_ATTACHED;
+               }
+-              if (ci->pkg == BCMA_PKG_ID_BCM5358)
++              if (ci->id == BCMA_CHIP_ID_BCM5357 && ci->pkg == BCMA_PKG_ID_BCM5358)
+                       bgmac->feature_flags |= BGMAC_FEAT_SW_TYPE_EPHYRMII;
+               break;
+       case BCMA_CHIP_ID_BCM53573:
diff --git a/queue-5.10/net-sched-tcindex-update-imperfect-hash-filters-respecting-rcu.patch b/queue-5.10/net-sched-tcindex-update-imperfect-hash-filters-respecting-rcu.patch
new file mode 100644 (file)
index 0000000..49ad05b
--- /dev/null
@@ -0,0 +1,101 @@
+From ee059170b1f7e94e55fa6cadee544e176a6e59c2 Mon Sep 17 00:00:00 2001
+From: Pedro Tammela <pctammela@mojatatu.com>
+Date: Thu, 9 Feb 2023 11:37:39 -0300
+Subject: net/sched: tcindex: update imperfect hash filters respecting rcu
+
+From: Pedro Tammela <pctammela@mojatatu.com>
+
+commit ee059170b1f7e94e55fa6cadee544e176a6e59c2 upstream.
+
+The imperfect hash area can be updated while packets are traversing,
+which will cause a use-after-free when 'tcf_exts_exec()' is called
+with the destroyed tcf_ext.
+
+CPU 0:               CPU 1:
+tcindex_set_parms    tcindex_classify
+tcindex_lookup
+                     tcindex_lookup
+tcf_exts_change
+                     tcf_exts_exec [UAF]
+
+Stop operating on the shared area directly, by using a local copy,
+and update the filter with 'rcu_replace_pointer()'. Delete the old
+filter version only after a rcu grace period elapsed.
+
+Fixes: 9b0d4446b569 ("net: sched: avoid atomic swap in tcf_exts_change")
+Reported-by: valis <sec@valis.email>
+Suggested-by: valis <sec@valis.email>
+Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
+Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
+Link: https://lore.kernel.org/r/20230209143739.279867-1-pctammela@mojatatu.com
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/sched/cls_tcindex.c |   34 ++++++++++++++++++++++++++++++----
+ 1 file changed, 30 insertions(+), 4 deletions(-)
+
+--- a/net/sched/cls_tcindex.c
++++ b/net/sched/cls_tcindex.c
+@@ -12,6 +12,7 @@
+ #include <linux/errno.h>
+ #include <linux/slab.h>
+ #include <linux/refcount.h>
++#include <linux/rcupdate.h>
+ #include <net/act_api.h>
+ #include <net/netlink.h>
+ #include <net/pkt_cls.h>
+@@ -338,6 +339,7 @@ tcindex_set_parms(struct net *net, struc
+       struct tcf_result cr = {};
+       int err, balloc = 0;
+       struct tcf_exts e;
++      bool update_h = false;
+       err = tcf_exts_init(&e, net, TCA_TCINDEX_ACT, TCA_TCINDEX_POLICE);
+       if (err < 0)
+@@ -455,10 +457,13 @@ tcindex_set_parms(struct net *net, struc
+               }
+       }
+-      if (cp->perfect)
++      if (cp->perfect) {
+               r = cp->perfect + handle;
+-      else
+-              r = tcindex_lookup(cp, handle) ? : &new_filter_result;
++      } else {
++              /* imperfect area is updated in-place using rcu */
++              update_h = !!tcindex_lookup(cp, handle);
++              r = &new_filter_result;
++      }
+       if (r == &new_filter_result) {
+               f = kzalloc(sizeof(*f), GFP_KERNEL);
+@@ -484,7 +489,28 @@ tcindex_set_parms(struct net *net, struc
+       rcu_assign_pointer(tp->root, cp);
+-      if (r == &new_filter_result) {
++      if (update_h) {
++              struct tcindex_filter __rcu **fp;
++              struct tcindex_filter *cf;
++
++              f->result.res = r->res;
++              tcf_exts_change(&f->result.exts, &r->exts);
++
++              /* imperfect area bucket */
++              fp = cp->h + (handle % cp->hash);
++
++              /* lookup the filter, guaranteed to exist */
++              for (cf = rcu_dereference_bh_rtnl(*fp); cf;
++                   fp = &cf->next, cf = rcu_dereference_bh_rtnl(*fp))
++                      if (cf->key == handle)
++                              break;
++
++              f->next = cf->next;
++
++              cf = rcu_replace_pointer(*fp, f, 1);
++              tcf_exts_get_net(&cf->result.exts);
++              tcf_queue_work(&cf->rwork, tcindex_destroy_fexts_work);
++      } else if (r == &new_filter_result) {
+               struct tcindex_filter *nfp;
+               struct tcindex_filter __rcu **fp;
diff --git a/queue-5.10/revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch b/queue-5.10/revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch
new file mode 100644 (file)
index 0000000..974691a
--- /dev/null
@@ -0,0 +1,34 @@
+From a5b21d8d791cd4db609d0bbcaa9e0c7e019888d1 Mon Sep 17 00:00:00 2001
+From: Andrew Morton <akpm@linux-foundation.org>
+Date: Thu, 2 Feb 2023 18:07:35 -0800
+Subject: revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
+
+From: Andrew Morton <akpm@linux-foundation.org>
+
+commit a5b21d8d791cd4db609d0bbcaa9e0c7e019888d1 upstream.
+
+This fix was nacked by Philip, for reasons identified in the email linked
+below.
+
+Link: https://lkml.kernel.org/r/68f15d67-8945-2728-1f17-5b53a80ec52d@squashfs.org.uk
+Fixes: 72e544b1b28325 ("squashfs: harden sanity check in squashfs_read_xattr_id_table")
+Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>
+Cc: Fedor Pchelkin <pchelkin@ispras.ru>
+Cc: Phillip Lougher <phillip@squashfs.org.uk>
+Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ fs/squashfs/xattr_id.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/fs/squashfs/xattr_id.c
++++ b/fs/squashfs/xattr_id.c
+@@ -76,7 +76,7 @@ __le64 *squashfs_read_xattr_id_table(str
+       /* Sanity check values */
+       /* there is always at least one xattr id */
+-      if (*xattr_ids <= 0)
++      if (*xattr_ids == 0)
+               return ERR_PTR(-EINVAL);
+       len = SQUASHFS_XATTR_BLOCK_BYTES(*xattr_ids);
diff --git a/queue-5.10/sctp-sctp_sock_filter-avoid-list_entry-on-possibly-empty-list.patch b/queue-5.10/sctp-sctp_sock_filter-avoid-list_entry-on-possibly-empty-list.patch
new file mode 100644 (file)
index 0000000..0fa78e9
--- /dev/null
@@ -0,0 +1,37 @@
+From a1221703a0f75a9d81748c516457e0fc76951496 Mon Sep 17 00:00:00 2001
+From: Pietro Borrello <borrello@diag.uniroma1.it>
+Date: Thu, 9 Feb 2023 12:13:05 +0000
+Subject: sctp: sctp_sock_filter(): avoid list_entry() on possibly empty list
+
+From: Pietro Borrello <borrello@diag.uniroma1.it>
+
+commit a1221703a0f75a9d81748c516457e0fc76951496 upstream.
+
+Use list_is_first() to check whether tsp->asoc matches the first
+element of ep->asocs, as the list is not guaranteed to have an entry.
+
+Fixes: 8f840e47f190 ("sctp: add the sctp_diag.c file")
+Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
+Acked-by: Xin Long <lucien.xin@gmail.com>
+Link: https://lore.kernel.org/r/20230208-sctp-filter-v2-1-6e1f4017f326@diag.uniroma1.it
+Signed-off-by: Jakub Kicinski <kuba@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/sctp/diag.c |    4 +---
+ 1 file changed, 1 insertion(+), 3 deletions(-)
+
+--- a/net/sctp/diag.c
++++ b/net/sctp/diag.c
+@@ -349,11 +349,9 @@ static int sctp_sock_filter(struct sctp_
+       struct sctp_comm_param *commp = p;
+       struct sock *sk = ep->base.sk;
+       const struct inet_diag_req_v2 *r = commp->r;
+-      struct sctp_association *assoc =
+-              list_entry(ep->asocs.next, struct sctp_association, asocs);
+       /* find the ep only once through the transports by this condition */
+-      if (tsp->asoc != assoc)
++      if (!list_is_first(&tsp->asoc->asocs, &ep->asocs))
+               return 0;
+       if (r->sdiag_family != AF_UNSPEC && sk->sk_family != r->sdiag_family)
index f7c9026181776f72b324a75a60687b73b55fe7d4..6f8ac430e05b3bcbf3a307f771f6ef2fc5bedc42 100644 (file)
@@ -27,3 +27,9 @@ sched-psi-fix-use-after-free-in-ep_remove_wait_queue.patch
 hugetlb-check-for-undefined-shift-on-32-bit-architectures.patch
 revert-mm-always-release-pages-to-the-buddy-allocator-in-memblock_free_late.patch
 net-fix-unwanted-sign-extension-in-netdev_stats_to_stats64.patch
+revert-squashfs-harden-sanity-check-in-squashfs_read_xattr_id_table.patch
+ixgbe-allow-to-increase-mtu-to-3k-with-xdp-enabled.patch
+i40e-add-double-of-vlan-header-when-computing-the-max-mtu.patch
+net-bgmac-fix-bcm5358-support-by-setting-correct-flags.patch
+sctp-sctp_sock_filter-avoid-list_entry-on-possibly-empty-list.patch
+net-sched-tcindex-update-imperfect-hash-filters-respecting-rcu.patch