libcli/ldap: Don’t try to encode NULL name

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/libcli/ldap/ldap_message.c b/libcli/ldap/ldap_message.c
index c7d868449630a0e7da6748ef9064a3d2701b9df2..3099086b05bfb5727449e6c643ad0ba0541eb69e 100644 (file)
--- a/libcli/ldap/ldap_message.c
+++ b/libcli/ldap/ldap_message.c
@@ -546,6 +546,9 @@ _PUBLIC_ bool ldap_encode(struct ldap_message *msg,
                for (i=0; i<r->num_attributes; i++) {
                        struct ldb_message_element *attrib = &r->attributes[i];
                        if (!asn1_push_tag(data, ASN1_SEQUENCE(0))) goto err;
+                       if (attrib->name == NULL) {
+                               goto err;
+                       }
                        if (!asn1_write_OctetString(data, attrib->name,
                                               strlen(attrib->name))) goto err;
                        if (!asn1_push_tag(data, ASN1_SET)) goto err;