const violation detected by GCC in how ftp.cc parsed login details

diff --git a/src/ftp.cc b/src/ftp.cc
index 753ccb60ce64d5241f24ed42a53886d1dcac1342..603bc2b3124ff63c6c7754110aaaae75783e7ff0 100644 (file)
--- a/src/ftp.cc
+++ b/src/ftp.cc
@@ -532,9 +532,11 @@ FtpStateData::~FtpStateData()
  * Produces filled member varisbles user, password, password_url if anything found.
  */
 void
-FtpStateData::loginParser(const char *login, int escaped)
+FtpStateData::loginParser(const char *login_, int escaped)
 {
+    char *login = xstrdup(login_);
     char *s = NULL;
+
     debugs(9, 4, HERE << ": login='" << login << "', escaped=" << escaped);
     debugs(9, 9, HERE << ": IN : login='" << login << "', escaped=" << escaped << ", user=" << user << ", password=" << password);
 
@@ -564,6 +566,7 @@ FtpStateData::loginParser(const char *login, int escaped)
     }
 
     debugs(9, 9, HERE << ": OUT: login='" << login << "', escaped=" << escaped << ", user=" << user << ", password=" << password);
+    safe_free(login);
 }
 
 void