]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainGetGuestInfo: Prepare for refactor to virTypedParamList
authorPeter Krempa <pkrempa@redhat.com>
Wed, 26 Feb 2025 13:38:15 +0000 (14:38 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 3 Mar 2025 14:08:19 +0000 (15:08 +0100)
Use of raw typed param APIs is very clunky. Prepare
qemuDomainGetGuestInfo for step-by-step refactor to virTypedParamList.

The two lists will coexist until the refactor is complete.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index 86b945d9b9b99f517ee1f2e489d3db8402189746..3d2ebd771937c5cc33f166dc5657ff1e559dc0f2 100644 (file)
@@ -19483,6 +19483,8 @@ qemuDomainGetGuestInfo(virDomainPtr dom,
     double load15m = 0;
     bool format_load = false;
     size_t i;
+    g_autoptr(virTypedParamList) list = virTypedParamListNew();
+    g_autoptr(virTypedParamList) tmplist = NULL;
 
     virCheckFlags(0, -1);
 
@@ -19592,6 +19594,14 @@ qemuDomainGetGuestInfo(virDomainPtr dom,
         virTypedParamsAddDouble(params, nparams, &maxparams, "load.15m", load15m);
     }
 
+    /* temporarily allow the old and new construction style to coexist */
+    tmplist = virTypedParamListFromParams(params, *nparams);
+    virTypedParamListConcat(tmplist, &list);
+    list = g_steal_pointer(&tmplist);
+
+    if (virTypedParamListSteal(list, params, nparams) < 0)
+        goto cleanup;
+
     ret = 0;
 
  cleanup: