]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: virtio_scsi: Remove duplicate check if queue is broken
authorLi RongQing <lirongqing@baidu.com>
Tue, 16 Jan 2024 04:58:36 +0000 (12:58 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 17 Jan 2024 19:46:17 +0000 (14:46 -0500)
virtqueue_enable_cb() will call virtqueue_poll() which will check if queue
is broken at beginning, so remove the virtqueue_is_broken() call

Signed-off-by: Li RongQing <lirongqing@baidu.com>
Link: https://lore.kernel.org/r/20240116045836.12475-1-lirongqing@baidu.com
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/virtio_scsi.c

index 9d1bdcdc13312988b2ee052c3736bb548f21ffba..e15b3809d0595edbce255fd2f3c68eb8549dac6e 100644 (file)
@@ -182,8 +182,6 @@ static void virtscsi_vq_done(struct virtio_scsi *vscsi,
                while ((buf = virtqueue_get_buf(vq, &len)) != NULL)
                        fn(vscsi, buf);
 
-               if (unlikely(virtqueue_is_broken(vq)))
-                       break;
        } while (!virtqueue_enable_cb(vq));
        spin_unlock_irqrestore(&virtscsi_vq->vq_lock, flags);
 }