usb: typec: tcpci_rt1711h: Unmask alert interrupts to fix functionality

During probe, the TCPC alert interrupts are getting masked to
avoid unwanted interrupts during chip setup: this is ok to do
but there is no unmasking happening at any later time, which
means that the chip will not raise any interrupt, essentially
making it not functional as, while internally it does perform
all of the intended functions, it won't signal anything to the
outside.

Unmask the alert interrupts to fix functionality.

Fixes: ce08eaeb6388 ("staging: typec: rt1711h typec chip driver")
Cc: stable <stable@kernel.org>
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20250219114700.41700-1-angelogioacchino.delregno@collabora.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
index 64f6dd0dc66096f4577cf5f6c6425da8efa0ba14..88c50b984e8a3f3908c1f37e22c8a6f70c1529b7 100644 (file)
--- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
+++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
@@ -334,6 +334,11 @@ static int rt1711h_probe(struct i2c_client *client)
 {
        int ret;
        struct rt1711h_chip *chip;
+       const u16 alert_mask = TCPC_ALERT_TX_SUCCESS | TCPC_ALERT_TX_DISCARDED |
+                              TCPC_ALERT_TX_FAILED | TCPC_ALERT_RX_HARD_RST |
+                              TCPC_ALERT_RX_STATUS | TCPC_ALERT_POWER_STATUS |
+                              TCPC_ALERT_CC_STATUS | TCPC_ALERT_RX_BUF_OVF |
+                              TCPC_ALERT_FAULT;
 
        chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
        if (!chip)
@@ -382,6 +387,12 @@ static int rt1711h_probe(struct i2c_client *client)
                                        dev_name(chip->dev), chip);
        if (ret < 0)
                return ret;
+
+       /* Enable alert interrupts */
+       ret = rt1711h_write16(chip, TCPC_ALERT_MASK, alert_mask);
+       if (ret < 0)
+               return ret;
+
        enable_irq_wake(client->irq);
 
        return 0;