]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/omapdrm: remove _unlocked suffix in drm_gem_object_put_unlocked
authorEmil Velikov <emil.velikov@collabora.com>
Fri, 15 May 2020 09:51:06 +0000 (10:51 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Tue, 19 May 2020 21:31:34 +0000 (22:31 +0100)
Spelling out _unlocked for each and every driver is a annoying.
Especially if we consider how many drivers, do not know (or need to)
about the horror stories involving struct_mutex.

Just drop the suffix. It makes the API cleaner.

Done via the following script:

__from=drm_gem_object_put_unlocked
__to=drm_gem_object_put
for __file in $(git grep --name-only $__from); do
  sed -i  "s/$__from/$__to/g" $__file;
done

Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200515095118.2743122-27-emil.l.velikov@gmail.com
drivers/gpu/drm/omapdrm/omap_drv.c
drivers/gpu/drm/omapdrm/omap_fb.c
drivers/gpu/drm/omapdrm/omap_fbdev.c
drivers/gpu/drm/omapdrm/omap_gem.c

index cdafd7ef1c3206eb7e22e3df3102450471c5728b..242d28281784ba1fccf65958b08de87cff100abb 100644 (file)
@@ -503,7 +503,7 @@ static int ioctl_gem_info(struct drm_device *dev, void *data,
        args->size = omap_gem_mmap_size(obj);
        args->offset = omap_gem_mmap_offset(obj);
 
-       drm_gem_object_put_unlocked(obj);
+       drm_gem_object_put(obj);
 
        return ret;
 }
index 9aeab81dfb90e760d65b9a35b99600ea8939469d..05f30e2618c97081c83fb02de70c75d9c6077bb4 100644 (file)
@@ -326,7 +326,7 @@ struct drm_framebuffer *omap_framebuffer_create(struct drm_device *dev,
 
 error:
        while (--i >= 0)
-               drm_gem_object_put_unlocked(bos[i]);
+               drm_gem_object_put(bos[i]);
 
        return fb;
 }
index 09a84919ef738846204a038033d7e00ff2997a52..3f6cfc24fb641ad945e242abb141988dadf7ef5d 100644 (file)
@@ -140,7 +140,7 @@ static int omap_fbdev_create(struct drm_fb_helper *helper,
                /* note: if fb creation failed, we can't rely on fb destroy
                 * to unref the bo:
                 */
-               drm_gem_object_put_unlocked(fbdev->bo);
+               drm_gem_object_put(fbdev->bo);
                ret = PTR_ERR(fb);
                goto fail;
        }
index d08ae95ecc0ac2aed1d90ebc87c904729b2eed36..d0d12d5dd76c535473026e87671e07f7331e728d 100644 (file)
@@ -629,7 +629,7 @@ int omap_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev,
 
        *offset = omap_gem_mmap_offset(obj);
 
-       drm_gem_object_put_unlocked(obj);
+       drm_gem_object_put(obj);
 
 fail:
        return ret;
@@ -1348,7 +1348,7 @@ int omap_gem_new_handle(struct drm_device *dev, struct drm_file *file,
        }
 
        /* drop reference from allocate - handle holds it now */
-       drm_gem_object_put_unlocked(obj);
+       drm_gem_object_put(obj);
 
        return 0;
 }