submodule--helper: fix trivial get_default_remote_submodule() leak

Fix a leak in code added in 1012a5cbc3f (submodule--helper
run-update-procedure: learn --remote, 2022-03-04), we need to free()
the xstrdup()'d string. This gets e.g. t/t7419-submodule-set-branch.sh
closer to passing under SANITIZE=leak.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index d308b14904c867b2602e7d05417146ebf84e9990..d46ba102f60c456449593a597c6ffd96d07cdf02 100644 (file)
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -2448,6 +2448,8 @@ static int update_submodule(struct update_data *update_data)
                        return code;
                remote_ref = xstrfmt("refs/remotes/%s/%s", remote_name, branch);
 
+               free(remote_name);
+
                if (!update_data->nofetch) {
                        if (fetch_in_submodule(update_data->sm_path, update_data->depth,
                                              0, NULL))