]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Coverity 1507372: explicit null dereference
authorPauli <pauli@openssl.org>
Tue, 19 Jul 2022 01:04:32 +0000 (11:04 +1000)
committerPauli <pauli@openssl.org>
Wed, 20 Jul 2022 06:22:04 +0000 (16:22 +1000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/18822)

test/evp_extra_test2.c

index b2ffe1d7928564a406588981ab2f62f852d3c402..86337b281b3942ee45d5c80b025adae013b6e0db 100644 (file)
@@ -346,9 +346,8 @@ static int test_dh_tofrom_data_select(void)
           && TEST_int_gt(EVP_PKEY_generate(gctx, &key), 0)
           && TEST_true(do_pkey_tofrom_data_select(key, "DHX"));
 # ifndef OPENSSL_NO_DEPRECATED_3_0
-    dhkey = EVP_PKEY_get0_DH(key);
-    ret = ret && TEST_ptr(dhkey);
-    ret = ret && TEST_ptr(privkey = DH_get0_priv_key(dhkey))
+    ret = ret && TEST_ptr(dhkey = EVP_PKEY_get0_DH(key))
+              && TEST_ptr(privkey = DH_get0_priv_key(dhkey))
               && TEST_int_le(BN_num_bits(privkey), 225);
 # endif
     EVP_PKEY_free(key);