* tests/install/basic-1: Skip the latter part of this test if the

just-built dd binary is not readable.  Otherwise, this test would fail
when binaries were created as root.  Reported by Bauke Jan Douma in
<http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/8433>.

diff --git a/ChangeLog b/ChangeLog
index 5458cc6de1252fba8e2f59c7447144270e728d48..1ebe1cdd4a1dedccef944fba4fc9107e3936f8ad 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2006-10-05  Jim Meyering  <jim@meyering.net>
+
+       * tests/install/basic-1: Skip the latter part of this test if the
+       just-built dd binary is not readable.  Otherwise, this test would fail
+       when binaries were created as root.  Reported by Bauke Jan Douma in
+       <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/8433>.
+
 2006-10-03  Paul Eggert  <eggert@cs.ucla.edu>
 
        * src/system.h (ST_BLKSIZE): Ceiling at SIZE_MAX / 8 + 1, not at 4

diff --git a/tests/install/basic-1 b/tests/install/basic-1
index 9c7d106ad8c45e218263b70789b91a55c3dd8989..55f0b511c8fbf3dd3c696d3a27b8cc8da8f7f8dd 100755 (executable)
--- a/tests/install/basic-1
+++ b/tests/install/basic-1
@@ -58,7 +58,20 @@ test -f $dir/$file || fail=1
 # Make sure strip works.
 dd=dd$EXEEXT
 dd2=dd2$EXEEXT
-cp $pwd/../../src/$dd . || fail=1
+
+just_built_dd=$pwd/../../src/$dd
+
+test -r $just_built_dd || \
+  {
+    cat 1>&2 <<EOF
+$0: WARNING!!!
+Your just-built dd binary, $just_built_dd
+is not readable, so skipping the remaining tests in this file.
+EOF
+    exit 77
+  }
+
+cp $just_built_dd . || fail=1
 cp $dd $dd2 || fail=1
 
 strip $dd2 || \