]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c: Fix i386 target attribute regression [PR 122180]
authorAlfie Richards <alfie.richards@arm.com>
Tue, 7 Oct 2025 09:34:48 +0000 (09:34 +0000)
committerAlfie Richards <alfie.richards@arm.com>
Wed, 8 Oct 2025 08:22:26 +0000 (08:22 +0000)
My patch (r16-4182-g73888cefe6da65) broke another target (i386), which this
patch fixes.

The issue was the target_version code was incorrectly being triggered on
targets that do not support target_version semantics (i386).

PR target/122180

gcc/c/ChangeLog:

* c-decl.cc (pushdecl): Add TARGET_HAS_FMV_TARGET_ATTRIBUTE check.

gcc/testsuite/ChangeLog:

* gcc.target/i386/pr122180.c: New test.

gcc/c/c-decl.cc
gcc/testsuite/gcc.target/i386/pr122180.c [new file with mode: 0644]

index d0dc5eeda39b0eb3a79903c123092794480d28bb..4a940d5eec33e361563f85faadf9176d1d02b5d7 100644 (file)
@@ -3414,8 +3414,11 @@ pushdecl (tree x)
            }
        }
 
-      /* Check if x is part of a FMV set with b_use.  */
-      if (b_use && TREE_CODE (b_use->decl) == FUNCTION_DECL
+      /* Check if x is part of a FMV set with b_use.
+        FMV is only supported in c for targets with target_version
+        attributes.  */
+      if (!TARGET_HAS_FMV_TARGET_ATTRIBUTE
+         && b_use && TREE_CODE (b_use->decl) == FUNCTION_DECL
          && TREE_CODE (x) == FUNCTION_DECL && DECL_FILE_SCOPE_P (b_use->decl)
          && DECL_FILE_SCOPE_P (x)
          && disjoint_version_decls (x, b_use->decl)
diff --git a/gcc/testsuite/gcc.target/i386/pr122180.c b/gcc/testsuite/gcc.target/i386/pr122180.c
new file mode 100644 (file)
index 0000000..6153d6c
--- /dev/null
@@ -0,0 +1,7 @@
+/* { dg-do compile } */
+
+static void s() __attribute__((target("avx")));
+static void s() { }
+void f() {
+        s();
+}