]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: pinconf-generic: Use scope based of_node_put() cleanups
authorPeng Fan <peng.fan@nxp.com>
Sat, 4 May 2024 13:20:15 +0000 (21:20 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 26 Jun 2024 09:59:22 +0000 (11:59 +0200)
Use scope based of_node_put() cleanup to simplify code.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/20240504-pinctrl-cleanup-v2-17-26c5f2dc1181@nxp.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinconf-generic.c

index 80de389199bd4af2a660632372ab6075cf860ac6..a499b8af5c1f197303cd116b57fbf5282b614324 100644 (file)
@@ -382,7 +382,6 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev *pctldev,
                unsigned int *num_maps, enum pinctrl_map_type type)
 {
        unsigned int reserved_maps;
-       struct device_node *np;
        int ret;
 
        reserved_maps = 0;
@@ -394,13 +393,11 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev *pctldev,
        if (ret < 0)
                goto exit;
 
-       for_each_available_child_of_node(np_config, np) {
+       for_each_available_child_of_node_scoped(np_config, np) {
                ret = pinconf_generic_dt_subnode_to_map(pctldev, np, map,
                                        &reserved_maps, num_maps, type);
-               if (ret < 0) {
-                       of_node_put(np);
+               if (ret < 0)
                        goto exit;
-               }
        }
        return 0;