]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: nuvoton: ma35d1: Fix an IS_ERR() vs NULL check
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 12 Jun 2024 10:43:33 +0000 (13:43 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Jun 2024 09:01:47 +0000 (11:01 +0200)
The fwnode_iomap() function doesn't return error pointers, it returns
NULL.  It's the same as of_iomap() in that way.  Update the check
accordingly.

Fixes: ecc5bf868673 ("pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/840152f9-d3bb-410e-8164-4c5043e1983e@moroto.mountain
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/nuvoton/pinctrl-ma35.c

index fb933cddde91b4fba858b575276a0bd7ec3b0bc1..1fa00a23534a9d6864a74b86ee362490014ba1da 100644 (file)
@@ -571,8 +571,8 @@ static int ma35_gpiolib_register(struct platform_device *pdev, struct ma35_pinct
 static int ma35_get_bank_data(struct ma35_pin_bank *bank)
 {
        bank->reg_base = fwnode_iomap(bank->fwnode, 0);
-       if (IS_ERR(bank->reg_base))
-               return PTR_ERR(bank->reg_base);
+       if (!bank->reg_base)
+               return -ENOMEM;
 
        bank->irq = fwnode_irq_get(bank->fwnode, 0);