]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy
authorStefan Weil via <qemu-trivial@nongnu.org>
Sun, 24 Dec 2023 11:43:14 +0000 (12:43 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 25 Dec 2023 08:01:01 +0000 (11:01 +0300)
Fixes: CID 1532828
Fixes: b6948ab01d ("virtio-blk: add iothread-vq-mapping parameter")
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/block/dataplane/virtio-blk.c

index 6debd4401e0dacd9c93f1b7fa6f7cba13be4fd45..97a302cf4973078d660d0cab0095be2636f3292f 100644 (file)
@@ -152,7 +152,7 @@ bool virtio_blk_data_plane_create(VirtIODevice *vdev, VirtIOBlkConf *conf,
 void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
 {
     VirtIOBlock *vblk;
-    VirtIOBlkConf *conf = s->conf;
+    VirtIOBlkConf *conf;
 
     if (!s) {
         return;
@@ -160,6 +160,7 @@ void virtio_blk_data_plane_destroy(VirtIOBlockDataPlane *s)
 
     vblk = VIRTIO_BLK(s->vdev);
     assert(!vblk->dataplane_started);
+    conf = s->conf;
 
     if (conf->iothread_vq_mapping_list) {
         IOThreadVirtQueueMappingList *node;