]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.15-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Mar 2022 09:14:47 +0000 (11:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Mar 2022 09:14:47 +0000 (11:14 +0200)
added patches:
iommu-iova-improve-32-bit-free-space-estimate.patch

queue-5.15/iommu-iova-improve-32-bit-free-space-estimate.patch [new file with mode: 0644]
queue-5.15/series

diff --git a/queue-5.15/iommu-iova-improve-32-bit-free-space-estimate.patch b/queue-5.15/iommu-iova-improve-32-bit-free-space-estimate.patch
new file mode 100644 (file)
index 0000000..56f2e74
--- /dev/null
@@ -0,0 +1,52 @@
+From 5b61343b50590fb04a3f6be2cdc4868091757262 Mon Sep 17 00:00:00 2001
+From: Robin Murphy <robin.murphy@arm.com>
+Date: Thu, 3 Mar 2022 14:40:08 +0000
+Subject: iommu/iova: Improve 32-bit free space estimate
+
+From: Robin Murphy <robin.murphy@arm.com>
+
+commit 5b61343b50590fb04a3f6be2cdc4868091757262 upstream.
+
+For various reasons based on the allocator behaviour and typical
+use-cases at the time, when the max32_alloc_size optimisation was
+introduced it seemed reasonable to couple the reset of the tracked
+size to the update of cached32_node upon freeing a relevant IOVA.
+However, since subsequent optimisations focused on helping genuine
+32-bit devices make best use of even more limited address spaces, it
+is now a lot more likely for cached32_node to be anywhere in a "full"
+32-bit address space, and as such more likely for space to become
+available from IOVAs below that node being freed.
+
+At this point, the short-cut in __cached_rbnode_delete_update() really
+doesn't hold up any more, and we need to fix the logic to reliably
+provide the expected behaviour. We still want cached32_node to only move
+upwards, but we should reset the allocation size if *any* 32-bit space
+has become available.
+
+Reported-by: Yunfei Wang <yf.wang@mediatek.com>
+Signed-off-by: Robin Murphy <robin.murphy@arm.com>
+Reviewed-by: Miles Chen <miles.chen@mediatek.com>
+Link: https://lore.kernel.org/r/033815732d83ca73b13c11485ac39336f15c3b40.1646318408.git.robin.murphy@arm.com
+Signed-off-by: Joerg Roedel <jroedel@suse.de>
+Cc: Miles Chen <miles.chen@mediatek.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/iommu/iova.c |    5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+--- a/drivers/iommu/iova.c
++++ b/drivers/iommu/iova.c
+@@ -154,10 +154,11 @@ __cached_rbnode_delete_update(struct iov
+       cached_iova = to_iova(iovad->cached32_node);
+       if (free == cached_iova ||
+           (free->pfn_hi < iovad->dma_32bit_pfn &&
+-           free->pfn_lo >= cached_iova->pfn_lo)) {
++           free->pfn_lo >= cached_iova->pfn_lo))
+               iovad->cached32_node = rb_next(&free->node);
++
++      if (free->pfn_lo < iovad->dma_32bit_pfn)
+               iovad->max32_alloc_size = iovad->dma_32bit_pfn;
+-      }
+       cached_iova = to_iova(iovad->cached_node);
+       if (free->pfn_lo >= cached_iova->pfn_lo)
index bb14a2251dbe745088bfa9f415b302acae044c86..6a9e533d1319b5410f9f8060a826e5476ab1cc96 100644 (file)
@@ -26,3 +26,4 @@ selftests-vm-fix-clang-build-error-multiple-output-f.patch
 locking-lockdep-avoid-potential-access-of-invalid-memory-in-lock_class.patch
 drm-amdgpu-move-px-checking-into-amdgpu_device_ip_early_init.patch
 drm-amdgpu-only-check-for-_pr3-on-dgpus.patch
+iommu-iova-improve-32-bit-free-space-estimate.patch