]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Use map for getAppliedPolicyTypeAsString 16458/head
authorJosh Soref <2119212+jsoref@users.noreply.github.com>
Sun, 9 Nov 2025 00:50:18 +0000 (19:50 -0500)
committerJosh Soref <2119212+jsoref@users.noreply.github.com>
Sun, 9 Nov 2025 03:11:40 +0000 (22:11 -0500)
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
contrib/ProtobufLogger.py

index 1fea0a1cf30e9cfca05ec029a019315583fb6ffd..23586d5aeda2e49d083d58ac0b271d3973205230 100644 (file)
@@ -38,6 +38,15 @@ class PDNSPBConnHandler(object):
         self._oturl = oturl
         self._printjson = printjson
 
+    messageTypeToStringMap = {
+        dnsmessage_pb2.PBDNSMessage.UNKNOWN: 'Unknown',
+        dnsmessage_pb2.PBDNSMessage.QNAME: 'QName',
+        dnsmessage_pb2.PBDNSMessage.CLIENTIP: 'Client IP',
+        dnsmessage_pb2.PBDNSMessage.RESPONSEIP: 'Response IP',
+        dnsmessage_pb2.PBDNSMessage.NSDNAME: 'NS DName',
+        dnsmessage_pb2.PBDNSMessage.NSIP: 'NS IP',
+    }
+
     def run(self):
         while True:
             data = self._conn.recv(2)
@@ -150,18 +159,8 @@ class PDNSPBConnHandler(object):
 
     @staticmethod
     def getAppliedPolicyTypeAsString(polType):
-        if polType == dnsmessage_pb2.PBDNSMessage.UNKNOWN:
-            return 'Unknown'
-        elif polType == dnsmessage_pb2.PBDNSMessage.QNAME:
-            return 'QName'
-        elif polType == dnsmessage_pb2.PBDNSMessage.CLIENTIP:
-            return 'Client IP'
-        elif polType == dnsmessage_pb2.PBDNSMessage.RESPONSEIP:
-            return 'Response IP'
-        elif polType == dnsmessage_pb2.PBDNSMessage.NSDNAME:
-            return 'NS DName'
-        elif polType == dnsmessage_pb2.PBDNSMessage.NSIP:
-            return 'NS IP'
+        try:
+            return messageTypeToStringMap.get(polType, "Unrecognized")
 
     @staticmethod
     def getEventAsString(event):