]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-http: client: Fixed potential segfault problem in http_client_connection_server_c...
authorStephan Bosch <stephan@rename-it.nl>
Thu, 30 Jun 2016 20:35:59 +0000 (22:35 +0200)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Thu, 30 Jun 2016 22:04:06 +0000 (01:04 +0300)
Used wrong variable: it is set to NULL by http_client_request_unref() before it is used.
Problem found by Coverity.

src/lib-http/http-client-connection.c

index 66adf75040de1bedd054fb54b90328bc7cbacca9..567a0df375695e5923d5f10f35b4b7cf18a9ad31 100644 (file)
@@ -113,7 +113,7 @@ http_client_connection_server_close(struct http_client_connection **_conn)
                if (!http_client_request_unref(req_idx))
                        continue;
                /* resubmit the request, which may drop it */
-               if ((*req_idx)->state < HTTP_REQUEST_STATE_FINISHED)
+               if (req->state < HTTP_REQUEST_STATE_FINISHED)
                        http_client_request_resubmit(req);
        }       
        array_clear(&conn->request_wait_list);