]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
igb: Enable RSS for Intel I211 Ethernet Controller
authorNick Lowe <nick.lowe@gmail.com>
Mon, 21 Dec 2020 22:25:02 +0000 (22:25 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 May 2021 09:11:23 +0000 (11:11 +0200)
commit 6e6026f2dd2005844fb35c3911e8083c09952c6c upstream.

The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (RSS)
queues. It should not be excluded from having this feature enabled.

Via commit c883de9fd787 ("igb: rename igb define to be more generic")
E1000_MRQC_ENABLE_RSS_4Q was renamed to E1000_MRQC_ENABLE_RSS_MQ to
indicate that this is a generic bit flag to enable queues and not
a flag that is specific to devices that support 4 queues

The bit flag enables 2, 4 or 8 queues appropriately depending on the part.

Tested with a multicore CPU and frames were then distributed as expected.

This issue appears to have been introduced because of confusion caused
by the prior name.

Signed-off-by: Nick Lowe <nick.lowe@gmail.com>
Tested-by: David Switzer <david.switzer@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/igb/igb_main.c

index 0e8c17f7af28ac2555770b1992446132f32b797f..183db8e823795a8e2038f5da92b37e2cb6ec4295 100644 (file)
@@ -4482,8 +4482,7 @@ static void igb_setup_mrqc(struct igb_adapter *adapter)
                else
                        mrqc |= E1000_MRQC_ENABLE_VMDQ;
        } else {
-               if (hw->mac.type != e1000_i211)
-                       mrqc |= E1000_MRQC_ENABLE_RSS_MQ;
+               mrqc |= E1000_MRQC_ENABLE_RSS_MQ;
        }
        igb_vmm_control(adapter);