]> git.ipfire.org Git - thirdparty/git.git/commitdiff
cocci: apply the "cache.h" part of "the_repository.pending"
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Tue, 28 Mar 2023 13:58:46 +0000 (15:58 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 28 Mar 2023 14:36:36 +0000 (07:36 -0700)
Apply the part of "the_repository.pending.cocci" pertaining to
"cache.h".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
79 files changed:
add-patch.c
apply.c
archive.c
branch.c
builtin/am.c
builtin/bisect.c
builtin/blame.c
builtin/branch.c
builtin/checkout.c
builtin/commit-tree.c
builtin/commit.c
builtin/describe.c
builtin/fast-import.c
builtin/fetch.c
builtin/fsck.c
builtin/log.c
builtin/ls-files.c
builtin/ls-tree.c
builtin/merge-base.c
builtin/merge-recursive.c
builtin/merge.c
builtin/name-rev.c
builtin/notes.c
builtin/prune.c
builtin/pull.c
builtin/range-diff.c
builtin/read-tree.c
builtin/rebase.c
builtin/receive-pack.c
builtin/replace.c
builtin/reset.c
builtin/rev-list.c
builtin/rev-parse.c
builtin/rm.c
builtin/show-branch.c
builtin/show-ref.c
builtin/sparse-checkout.c
builtin/stash.c
builtin/submodule--helper.c
builtin/tag.c
builtin/unpack-file.c
builtin/update-ref.c
builtin/verify-commit.c
builtin/verify-tag.c
builtin/worktree.c
cache.h
checkout.c
combine-diff.c
commit.c
contrib/coccinelle/the_repository.cocci [new file with mode: 0644]
contrib/coccinelle/the_repository.pending.cocci
diff-lib.c
diff.c
fmt-merge-msg.c
log-tree.c
mailmap.c
notes-merge.c
notes.c
object-name.c
parse-options-cb.c
range-diff.c
read-cache.c
rebase-interactive.c
ref-filter.c
remote.c
reset.c
revision.c
sequencer.c
submodule-config.c
submodule.c
t/helper/test-fast-rebase.c
t/helper/test-match-trees.c
t/helper/test-oidmap.c
t/helper/test-reach.c
t/helper/test-submodule-config.c
tag.c
transport-helper.c
transport.c
wt-status.c

index a86a92e16461384cbe8ac880fa6515e0f74e243c..3cbb9591945a9b8dbf9ed73e6b6afeeba81fec5c 100644 (file)
@@ -414,7 +414,7 @@ static int parse_diff(struct add_p_state *s, const struct pathspec *ps)
                strvec_push(&args,
                            /* could be on an unborn branch */
                            !strcmp("HEAD", s->revision) &&
-                           get_oid("HEAD", &oid) ?
+                           repo_get_oid(the_repository, "HEAD", &oid) ?
                            empty_tree_oid_hex() : s->revision);
        }
        color_arg_index = args.nr;
diff --git a/apply.c b/apply.c
index 5cc5479c9c356fb955839fc808d0742d1d54b8e5..57f45cedd2b360bf76c4dc7c8c78d833939bde28 100644 (file)
--- a/apply.c
+++ b/apply.c
@@ -3610,7 +3610,7 @@ static int try_threeway(struct apply_state *state,
        /* Preimage the patch was prepared for */
        if (patch->is_new)
                write_object_file("", 0, OBJ_BLOB, &pre_oid);
-       else if (get_oid(patch->old_oid_prefix, &pre_oid) ||
+       else if (repo_get_oid(the_repository, patch->old_oid_prefix, &pre_oid) ||
                 read_blob_object(&buf, &pre_oid, patch->old_mode))
                return error(_("repository lacks the necessary blob to perform 3-way merge."));
 
@@ -4127,7 +4127,7 @@ static int build_fake_ancestor(struct apply_state *state, struct patch *list)
                        else
                                return error(_("sha1 information is lacking or "
                                               "useless for submodule %s"), name);
-               } else if (!get_oid_blob(patch->old_oid_prefix, &oid)) {
+               } else if (!repo_get_oid_blob(the_repository, patch->old_oid_prefix, &oid)) {
                        ; /* ok */
                } else if (!patch->lines_added && !patch->lines_deleted) {
                        /* mode-only change: update the current */
index 9aeaf2bd87dfb884479f6e6a1b609d082ac39896..732e2100544ccbf1a1f32bca96008b9bd19a9d6c 100644 (file)
--- a/archive.c
+++ b/archive.c
@@ -461,7 +461,7 @@ static void parse_treeish_arg(const char **argv,
                dwim_ref(name, strlen(name), &oid, &ref, 0);
        }
 
-       if (get_oid(name, &oid))
+       if (repo_get_oid(the_repository, name, &oid))
                die(_("not a valid object name: %s"), name);
 
        commit = lookup_commit_reference_gently(ar_args->repo, &oid, 1);
index e5614b53b3699d9fc08d41135b16a4a875b0fc68..2efb5fbaa5f660439597ac450f3f0ac832385368 100644 (file)
--- a/branch.c
+++ b/branch.c
@@ -531,7 +531,7 @@ static void dwim_branch_start(struct repository *r, const char *start_name,
                explicit_tracking = 1;
 
        real_ref = NULL;
-       if (get_oid_mb(start_name, &oid)) {
+       if (repo_get_oid_mb(the_repository, start_name, &oid)) {
                if (explicit_tracking) {
                        int code = die_message(_(upstream_missing), start_name);
                        advise_if_enabled(ADVICE_SET_UPSTREAM_FAILURE,
index e0848ddadfeb26617bcf2188b034a3968d1e0b67..c04038f1f3d8855a708e74c389f67301a879b921 100644 (file)
@@ -1066,7 +1066,7 @@ static void am_setup(struct am_state *state, enum patch_format patch_format,
        else
                write_state_text(state, "applying", "");
 
-       if (!get_oid("HEAD", &curr_head)) {
+       if (!repo_get_oid(the_repository, "HEAD", &curr_head)) {
                write_state_text(state, "abort-safety", oid_to_hex(&curr_head));
                if (!state->rebasing)
                        update_ref("am", "ORIG_HEAD", &curr_head, NULL, 0,
@@ -1109,7 +1109,7 @@ static void am_next(struct am_state *state)
        unlink(am_path(state, "original-commit"));
        delete_ref(NULL, "REBASE_HEAD", NULL, REF_NO_DEREF);
 
-       if (!get_oid("HEAD", &head))
+       if (!repo_get_oid(the_repository, "HEAD", &head))
                write_state_text(state, "abort-safety", oid_to_hex(&head));
        else
                write_state_text(state, "abort-safety", "");
@@ -1402,7 +1402,7 @@ static void write_index_patch(const struct am_state *state)
        struct rev_info rev_info;
        FILE *fp;
 
-       if (!get_oid("HEAD", &head)) {
+       if (!repo_get_oid(the_repository, "HEAD", &head)) {
                struct commit *commit = lookup_commit_or_die(&head, "HEAD");
                tree = get_commit_tree(commit);
        } else
@@ -1556,7 +1556,7 @@ static int fall_back_threeway(const struct am_state *state, const char *index_pa
        struct commit *result;
        char *their_tree_name;
 
-       if (get_oid("HEAD", &our_tree) < 0)
+       if (repo_get_oid(the_repository, "HEAD", &our_tree) < 0)
                oidcpy(&our_tree, the_hash_algo->empty_tree);
 
        if (build_fake_ancestor(state, index_path))
@@ -1646,7 +1646,7 @@ static void do_commit(const struct am_state *state)
        if (write_index_as_tree(&tree, &the_index, get_index_file(), 0, NULL))
                die(_("git write-tree failed to write a tree"));
 
-       if (!get_oid_commit("HEAD", &parent)) {
+       if (!repo_get_oid_commit(the_repository, "HEAD", &parent)) {
                old_oid = &parent;
                commit_list_insert(lookup_commit(the_repository, &parent),
                                   &parents);
@@ -2088,7 +2088,7 @@ static void am_skip(struct am_state *state)
 
        am_rerere_clear();
 
-       if (get_oid("HEAD", &head))
+       if (repo_get_oid(the_repository, "HEAD", &head))
                oidcpy(&head, the_hash_algo->empty_tree);
 
        if (clean_index(&head, &head))
@@ -2130,7 +2130,7 @@ static int safe_to_abort(const struct am_state *state)
                oidclr(&abort_safety);
        strbuf_release(&sb);
 
-       if (get_oid("HEAD", &head))
+       if (repo_get_oid(the_repository, "HEAD", &head))
                oidclr(&head);
 
        if (oideq(&head, &abort_safety))
@@ -2163,7 +2163,7 @@ static void am_abort(struct am_state *state)
        if (!has_curr_head)
                oidcpy(&curr_head, the_hash_algo->empty_tree);
 
-       has_orig_head = !get_oid("ORIG_HEAD", &orig_head);
+       has_orig_head = !repo_get_oid(the_repository, "ORIG_HEAD", &orig_head);
        if (!has_orig_head)
                oidcpy(&orig_head, the_hash_algo->empty_tree);
 
index 73017402671d30ce7f868a9691f9bb6f520695e1..7d51eecab8222d902d3a1682eb29bc3203e2a7f8 100644 (file)
@@ -235,7 +235,7 @@ static int bisect_reset(const char *commit)
        } else {
                struct object_id oid;
 
-               if (get_oid_commit(commit, &oid))
+               if (repo_get_oid_commit(the_repository, commit, &oid))
                        return error(_("'%s' is not a valid commit"), commit);
                strbuf_addstr(&branch, commit);
        }
@@ -292,7 +292,7 @@ static int bisect_write(const char *state, const char *rev,
                goto finish;
        }
 
-       if (get_oid(rev, &oid)) {
+       if (repo_get_oid(the_repository, rev, &oid)) {
                res = error(_("couldn't get the oid of the rev '%s'"), rev);
                goto finish;
        }
@@ -775,7 +775,7 @@ static enum bisect_error bisect_start(struct bisect_terms *terms, int argc,
         */
        head = resolve_ref_unsafe("HEAD", 0, &head_oid, &flags);
        if (!head)
-               if (get_oid("HEAD", &head_oid))
+               if (repo_get_oid(the_repository, "HEAD", &head_oid))
                        return error(_("bad HEAD - I need a HEAD"));
 
        /*
@@ -801,11 +801,11 @@ static enum bisect_error bisect_start(struct bisect_terms *terms, int argc,
                }
        } else {
                /* Get the rev from where we start. */
-               if (!get_oid(head, &head_oid) &&
+               if (!repo_get_oid(the_repository, head, &head_oid) &&
                    !starts_with(head, "refs/heads/")) {
                        strbuf_reset(&start_head);
                        strbuf_addstr(&start_head, oid_to_hex(&head_oid));
-               } else if (!get_oid(head, &head_oid) &&
+               } else if (!repo_get_oid(the_repository, head, &head_oid) &&
                           skip_prefix(head, "refs/heads/", &head)) {
                        strbuf_addstr(&start_head, head);
                } else {
@@ -828,7 +828,7 @@ static enum bisect_error bisect_start(struct bisect_terms *terms, int argc,
                write_file(git_path_bisect_first_parent(), "\n");
 
        if (no_checkout) {
-               if (get_oid(start_head.buf, &oid) < 0) {
+               if (repo_get_oid(the_repository, start_head.buf, &oid) < 0) {
                        res = error(_("invalid ref: '%s'"), start_head.buf);
                        goto finish;
                }
@@ -933,11 +933,12 @@ static enum bisect_error bisect_state(struct bisect_terms *terms, int argc,
 
        if (argc == 0) {
                const char *head = "BISECT_HEAD";
-               enum get_oid_result res_head = get_oid(head, &oid);
+               enum get_oid_result res_head = repo_get_oid(the_repository,
+                                                           head, &oid);
 
                if (res_head == MISSING_OBJECT) {
                        head = "HEAD";
-                       res_head = get_oid(head, &oid);
+                       res_head = repo_get_oid(the_repository, head, &oid);
                }
 
                if (res_head)
@@ -953,7 +954,7 @@ static enum bisect_error bisect_state(struct bisect_terms *terms, int argc,
        for (; argc; argc--, argv++) {
                struct commit *commit;
 
-               if (get_oid(*argv, &oid)){
+               if (repo_get_oid(the_repository, *argv, &oid)){
                        error(_("Bad rev input: %s"), *argv);
                        oid_array_clear(&revs);
                        return BISECT_FAILED;
index 71f925e456c34513b85e64e7dd6a72d510a8307e..0155062de11ea8bf5c4cde3084146c98e301046a 100644 (file)
@@ -601,8 +601,9 @@ static int read_ancestry(const char *graft_file)
 
 static int update_auto_abbrev(int auto_abbrev, struct blame_origin *suspect)
 {
-       const char *uniq = find_unique_abbrev(&suspect->commit->object.oid,
-                                             auto_abbrev);
+       const char *uniq = repo_find_unique_abbrev(the_repository,
+                                                  &suspect->commit->object.oid,
+                                                  auto_abbrev);
        int len = strlen(uniq);
        if (auto_abbrev < len)
                return len;
@@ -802,7 +803,7 @@ static int is_a_rev(const char *name)
 {
        struct object_id oid;
 
-       if (get_oid(name, &oid))
+       if (repo_get_oid(the_repository, name, &oid))
                return 0;
        return OBJ_NONE < oid_object_info(the_repository, &oid, NULL);
 }
@@ -845,7 +846,7 @@ static void build_ignorelist(struct blame_scoreboard *sb,
                                                    peel_to_commit_oid, sb);
        }
        for_each_string_list_item(i, ignore_rev_list) {
-               if (get_oid_committish(i->string, &oid) ||
+               if (repo_get_oid_committish(the_repository, i->string, &oid) ||
                    peel_to_commit_oid(&oid, sb))
                        die(_("cannot find revision %s to ignore"), i->string);
                oidset_insert(&sb->ignore_list, &oid);
index f63fd45edb96b513c24e1a9cd7c8a55e5a5f7b13..968ea03c0593c1df4e88265a325ccbbc2d00c40c 100644 (file)
@@ -280,7 +280,7 @@ static int delete_branches(int argc, const char **argv, int force, int kinds,
                item = string_list_append(&refs_to_delete, name);
                item->util = xstrdup((flags & REF_ISBROKEN) ? "broken"
                                    : (flags & REF_ISSYMREF) ? target
-                                   : find_unique_abbrev(&oid, DEFAULT_ABBREV));
+                                   : repo_find_unique_abbrev(the_repository, &oid, DEFAULT_ABBREV));
 
        next:
                free(target);
index a5155cf55c1e5150fd954a5b59363ee899974361..6216bb6bba3e2b33f15666ed43060a9d33dd7db5 100644 (file)
@@ -432,8 +432,8 @@ static int checkout_worktree(const struct checkout_opts *opts,
                                              "Updated %d paths from %s",
                                              nr_checkouts),
                                   nr_checkouts,
-                                  find_unique_abbrev(&opts->source_tree->object.oid,
-                                                     DEFAULT_ABBREV));
+                                  repo_find_unique_abbrev(the_repository, &opts->source_tree->object.oid,
+                                                          DEFAULT_ABBREV));
                else if (!nr_unmerged || nr_checkouts)
                        fprintf_ln(stderr, Q_("Updated %d path from the index",
                                              "Updated %d paths from the index",
@@ -644,10 +644,12 @@ static void describe_detached_head(const char *msg, struct commit *commit)
                pp_commit_easy(CMIT_FMT_ONELINE, commit, &sb);
        if (print_sha1_ellipsis()) {
                fprintf(stderr, "%s %s... %s\n", msg,
-                       find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV), sb.buf);
+                       repo_find_unique_abbrev(the_repository, &commit->object.oid, DEFAULT_ABBREV),
+                       sb.buf);
        } else {
                fprintf(stderr, "%s %s %s\n", msg,
-                       find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV), sb.buf);
+                       repo_find_unique_abbrev(the_repository, &commit->object.oid, DEFAULT_ABBREV),
+                       sb.buf);
        }
        strbuf_release(&sb);
 }
@@ -1060,7 +1062,7 @@ static void suggest_reattach(struct commit *commit, struct rev_info *revs)
                        " git branch <new-branch-name> %s\n\n",
                        /* Give ngettext() the count */
                        lost),
-                       find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV));
+                       repo_find_unique_abbrev(the_repository, &commit->object.oid, DEFAULT_ABBREV));
 }
 
 /*
@@ -1322,7 +1324,7 @@ static int parse_branchname_arg(int argc, const char **argv,
        if (!strcmp(arg, "-"))
                arg = "@{-1}";
 
-       if (get_oid_mb(arg, rev)) {
+       if (repo_get_oid_mb(the_repository, arg, rev)) {
                /*
                 * Either case (3) or (4), with <something> not being
                 * a commit, or an attempt to use case (1) with an
@@ -1748,7 +1750,7 @@ static int checkout_main(int argc, const char **argv, const char *prefix,
        } else if (!opts->accept_ref && opts->from_treeish) {
                struct object_id rev;
 
-               if (get_oid_mb(opts->from_treeish, &rev))
+               if (repo_get_oid_mb(the_repository, opts->from_treeish, &rev))
                        die(_("could not resolve %s"), opts->from_treeish);
 
                setup_new_branch_info_and_source_tree(new_branch_info,
index cc8d584be2f4a9d3b0c950a4b8cbc6c140904d8c..7941512c19f2971c636098decd1387c6b9dcf6bc 100644 (file)
@@ -53,7 +53,7 @@ static int parse_parent_arg_callback(const struct option *opt,
 
        BUG_ON_OPT_NEG_NOARG(unset, arg);
 
-       if (get_oid_commit(arg, &oid))
+       if (repo_get_oid_commit(the_repository, arg, &oid))
                die(_("not a valid object name %s"), arg);
 
        assert_oid_type(&oid, OBJ_COMMIT);
@@ -131,7 +131,7 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
        if (argc != 1)
                die(_("must give exactly one tree"));
 
-       if (get_oid_tree(argv[0], &tree_oid))
+       if (repo_get_oid_tree(the_repository, argv[0], &tree_oid))
                die(_("not a valid object name %s"), argv[0]);
 
        if (!buffer.len) {
index 985a0445b7897c936cc69e828d1e9f4ad98abaf7..80d1e31f25a81d1e21cfb8906264d4ccdcdad390 100644 (file)
@@ -557,7 +557,7 @@ static int run_status(FILE *fp, const char *index_file, const char *prefix, int
        s->index_file = index_file;
        s->fp = fp;
        s->nowarn = nowarn;
-       s->is_initial = get_oid(s->reference, &oid) ? 1 : 0;
+       s->is_initial = repo_get_oid(the_repository, s->reference, &oid) ? 1 : 0;
        if (!s->is_initial)
                oidcpy(&s->oid_commit, &oid);
        s->status_format = status_format;
@@ -1000,7 +1000,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
                if (amend)
                        parent = "HEAD^1";
 
-               if (get_oid(parent, &oid)) {
+               if (repo_get_oid(the_repository, parent, &oid)) {
                        int i, ita_nr = 0;
 
                        /* TODO: audit for interaction with sparse-index. */
@@ -1567,7 +1567,7 @@ int cmd_status(int argc, const char **argv, const char *prefix)
        else
                fd = -1;
 
-       s.is_initial = get_oid(s.reference, &oid) ? 1 : 0;
+       s.is_initial = repo_get_oid(the_repository, s.reference, &oid) ? 1 : 0;
        if (!s.is_initial)
                oidcpy(&s.oid_commit, &oid);
 
@@ -1714,7 +1714,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
        status_format = STATUS_FORMAT_NONE; /* Ignore status.short */
        s.colopts = 0;
 
-       if (get_oid("HEAD", &oid))
+       if (repo_get_oid(the_repository, "HEAD", &oid))
                current_head = NULL;
        else {
                current_head = lookup_commit_or_die(&oid, "HEAD");
index eea1e330c00c62a649b5a059bbfcf6e351f95269..c85bf9c418b0bb32f1078c2d86dafd986dc5461f 100644 (file)
@@ -298,7 +298,8 @@ static void append_name(struct commit_name *n, struct strbuf *dst)
 
 static void append_suffix(int depth, const struct object_id *oid, struct strbuf *dst)
 {
-       strbuf_addf(dst, "-%d-g%s", depth, find_unique_abbrev(oid, abbrev));
+       strbuf_addf(dst, "-%d-g%s", depth,
+                   repo_find_unique_abbrev(the_repository, oid, abbrev));
 }
 
 static void describe_commit(struct object_id *oid, struct strbuf *dst)
@@ -531,7 +532,7 @@ static void describe(const char *arg, int last_one)
        if (debug)
                fprintf(stderr, _("describe %s\n"), arg);
 
-       if (get_oid(arg, &oid))
+       if (repo_get_oid(the_repository, arg, &oid))
                die(_("Not a valid object name %s"), arg);
        cmit = lookup_commit_reference_gently(the_repository, &oid, 1);
 
index 7134683ab93f96d4c213d478fc7fadc8a17856c0..f533b768efbf64f05aab436e6f2607f87d919df0 100644 (file)
@@ -2486,7 +2486,7 @@ static void note_change_n(const char *p, struct branch *b, unsigned char *old_fa
                if (commit_oe->type != OBJ_COMMIT)
                        die("Mark :%" PRIuMAX " not a commit", commit_mark);
                oidcpy(&commit_oid, &commit_oe->idx.oid);
-       } else if (!get_oid(p, &commit_oid)) {
+       } else if (!repo_get_oid(the_repository, p, &commit_oid)) {
                unsigned long size;
                char *buf = read_object_with_reference(the_repository,
                                                       &commit_oid,
@@ -2599,7 +2599,7 @@ static int parse_objectish(struct branch *b, const char *objectish)
                        } else
                                parse_from_existing(b);
                }
-       } else if (!get_oid(objectish, &b->oid)) {
+       } else if (!repo_get_oid(the_repository, objectish, &b->oid)) {
                parse_from_existing(b);
                if (is_null_oid(&b->oid))
                        b->delete = 1;
@@ -2654,7 +2654,7 @@ static struct hash_list *parse_merge(unsigned int *count)
                        if (oe->type != OBJ_COMMIT)
                                die("Mark :%" PRIuMAX " not a commit", idnum);
                        oidcpy(&n->oid, &oe->idx.oid);
-               } else if (!get_oid(from, &n->oid)) {
+               } else if (!repo_get_oid(the_repository, from, &n->oid)) {
                        unsigned long size;
                        char *buf = read_object_with_reference(the_repository,
                                                               &n->oid,
@@ -2827,7 +2827,7 @@ static void parse_new_tag(const char *arg)
                oe = find_mark(marks, from_mark);
                type = oe->type;
                oidcpy(&oid, &oe->idx.oid);
-       } else if (!get_oid(from, &oid)) {
+       } else if (!repo_get_oid(the_repository, from, &oid)) {
                struct object_entry *oe = find_object(&oid);
                if (!oe) {
                        type = oid_object_info(the_repository, &oid, NULL);
index a09606b472622c133a683513ffdbe184952f2b01..80cf1d0158395f5358e1c8f968d631517b02879a 100644 (file)
@@ -1487,7 +1487,7 @@ static void add_negotiation_tips(struct git_transport_options *smart_options)
                int old_nr;
                if (!has_glob_specials(s)) {
                        struct object_id oid;
-                       if (get_oid(s, &oid))
+                       if (repo_get_oid(the_repository, s, &oid))
                                die(_("%s is not a valid object"), s);
                        if (!has_object(the_repository, &oid, 0))
                                die(_("the object %s does not exist"), s);
index d207bd909b4b6da0671628c20bb29e98f427b550..2bf183a43be061c64e9185f211fcec44de83f147 100644 (file)
@@ -923,7 +923,7 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)
        for (i = 0; i < argc; i++) {
                const char *arg = argv[i];
                struct object_id oid;
-               if (!get_oid(arg, &oid)) {
+               if (!repo_get_oid(the_repository, arg, &oid)) {
                        struct object *obj = lookup_object(the_repository,
                                                           &oid);
 
index a70fba198f9451c9005b3ecd14cfce8765e1d838..b4c38f6ad872cd469f5353aaefbee199215c7d4a 100644 (file)
@@ -1642,7 +1642,7 @@ static struct commit *get_base_commit(const char *base_commit,
                        struct commit *commit;
                        struct object_id oid;
 
-                       if (get_oid(upstream, &oid)) {
+                       if (repo_get_oid(the_repository, upstream, &oid)) {
                                if (die_on_failure)
                                        die(_("failed to resolve '%s' as a valid ref"), upstream);
                                else
@@ -2396,7 +2396,7 @@ done:
 static int add_pending_commit(const char *arg, struct rev_info *revs, int flags)
 {
        struct object_id oid;
-       if (get_oid(arg, &oid) == 0) {
+       if (repo_get_oid(the_repository, arg, &oid) == 0) {
                struct commit *commit = lookup_commit_reference(the_repository,
                                                                &oid);
                if (commit) {
@@ -2418,12 +2418,12 @@ static void print_commit(char sign, struct commit *commit, int verbose,
 {
        if (!verbose) {
                fprintf(file, "%c %s\n", sign,
-                      find_unique_abbrev(&commit->object.oid, abbrev));
+                      repo_find_unique_abbrev(the_repository, &commit->object.oid, abbrev));
        } else {
                struct strbuf buf = STRBUF_INIT;
                pp_commit_easy(CMIT_FMT_ONELINE, commit, &buf);
                fprintf(file, "%c %s %s\n", sign,
-                      find_unique_abbrev(&commit->object.oid, abbrev),
+                      repo_find_unique_abbrev(the_repository, &commit->object.oid, abbrev),
                       buf.buf);
                strbuf_release(&buf);
        }
index a03b559ecaab4caeba9a9a18bb268f22274e7b2a..c10d51a969dfee7ddbbe706cccc44ed87891f0db 100644 (file)
@@ -360,7 +360,7 @@ static void show_ru_info(struct index_state *istate)
                        if (!ui->mode[i])
                                continue;
                        printf("%s%06o %s %d\t", tag_resolve_undo, ui->mode[i],
-                              find_unique_abbrev(&ui->oid[i], abbrev),
+                              repo_find_unique_abbrev(the_repository, &ui->oid[i], abbrev),
                               i + 1);
                        write_name(path);
                }
@@ -575,7 +575,7 @@ void overlay_tree_on_index(struct index_state *istate,
        read_tree_fn_t fn = NULL;
        int err;
 
-       if (get_oid(tree_name, &oid))
+       if (repo_get_oid(the_repository, tree_name, &oid))
                die("tree-ish %s not found.", tree_name);
        tree = parse_tree_indirect(&oid);
        if (!tree)
index 8cc8c995df9399cd84465060965d065d33cd5d3b..ebcc8fd6ff8392a5b913a1b128f02b16f7f2795d 100644 (file)
@@ -228,7 +228,7 @@ static int show_tree_default(const struct object_id *oid, struct strbuf *base,
                return early;
 
        printf("%06o %s %s\t", mode, type_name(object_type(mode)),
-              find_unique_abbrev(oid, options->abbrev));
+              repo_find_unique_abbrev(the_repository, oid, options->abbrev));
        show_tree_common_default_long(options, base, pathname, base->len);
        return recurse;
 }
@@ -259,7 +259,8 @@ static int show_tree_long(const struct object_id *oid, struct strbuf *base,
        }
 
        printf("%06o %s %s %7s\t", mode, type_name(type),
-              find_unique_abbrev(oid, options->abbrev), size_text);
+              repo_find_unique_abbrev(the_repository, oid, options->abbrev),
+              size_text);
        show_tree_common_default_long(options, base, pathname, base->len);
        return recurse;
 }
@@ -310,7 +311,7 @@ static int show_tree_object(const struct object_id *oid, struct strbuf *base,
        if (early >= 0)
                return early;
 
-       str = find_unique_abbrev(oid, options->abbrev);
+       str = repo_find_unique_abbrev(the_repository, oid, options->abbrev);
        if (options->null_termination) {
                fputs(str, stdout);
                fputc('\0', stdout);
@@ -433,7 +434,7 @@ int cmd_ls_tree(int argc, const char **argv, const char *prefix)
                        ls_tree_usage, ls_tree_options);
        if (argc < 1)
                usage_with_options(ls_tree_usage, ls_tree_options);
-       if (get_oid(argv[0], &oid))
+       if (repo_get_oid(the_repository, argv[0], &oid))
                die("Not a valid object name %s", argv[0]);
 
        /*
index 6f3941f2a49ce51ee295158a4d78f5c80c1afeb7..688d5c29b76440df8c9c8e6fc1c7609142b9ee2d 100644 (file)
@@ -42,7 +42,7 @@ static struct commit *get_commit_reference(const char *arg)
        struct object_id revkey;
        struct commit *r;
 
-       if (get_oid(arg, &revkey))
+       if (repo_get_oid(the_repository, arg, &revkey))
                die("Not a valid object name %s", arg);
        r = lookup_commit_reference(the_repository, &revkey);
        if (!r)
@@ -118,7 +118,7 @@ static int handle_fork_point(int argc, const char **argv)
        const char *commitname;
 
        commitname = (argc == 2) ? argv[1] : "HEAD";
-       if (get_oid(commitname, &oid))
+       if (repo_get_oid(the_repository, commitname, &oid))
                die("Not a valid object name: '%s'", commitname);
 
        derived = lookup_commit_reference(the_repository, &oid);
index b9acbf5d3427e7dd88533351db5d2fc245cc25f6..a50b328d9436dee8bad6bfe1fb131b31f8a64494 100644 (file)
@@ -49,7 +49,7 @@ int cmd_merge_recursive(int argc, const char **argv, const char *prefix)
                }
                if (bases_count < ARRAY_SIZE(bases)-1) {
                        struct object_id *oid = xmalloc(sizeof(struct object_id));
-                       if (get_oid(argv[i], oid))
+                       if (repo_get_oid(the_repository, argv[i], oid))
                                die(_("could not parse object '%s'"), argv[i]);
                        bases[bases_count++] = oid;
                }
@@ -70,9 +70,9 @@ int cmd_merge_recursive(int argc, const char **argv, const char *prefix)
        o.branch1 = argv[++i];
        o.branch2 = argv[++i];
 
-       if (get_oid(o.branch1, &h1))
+       if (repo_get_oid(the_repository, o.branch1, &h1))
                die(_("could not resolve ref '%s'"), o.branch1);
-       if (get_oid(o.branch2, &h2))
+       if (repo_get_oid(the_repository, o.branch2, &h2))
                die(_("could not resolve ref '%s'"), o.branch2);
 
        o.branch1 = better1 = better_branch_name(o.branch1);
index 0a3c10a0966bdfc8f354cffb19d8f27987298600..7331a0cd9118246703979544d58e6f264f9fd77e 100644 (file)
@@ -337,7 +337,7 @@ static int save_state(struct object_id *stash)
        else if (!len)          /* no changes */
                goto out;
        strbuf_setlen(&buffer, buffer.len-1);
-       if (get_oid(buffer.buf, stash))
+       if (repo_get_oid(the_repository, buffer.buf, stash))
                die(_("not a valid object: %s"), buffer.buf);
        rc = 0;
 out:
@@ -1567,10 +1567,10 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
 
                if (verbosity >= 0) {
                        printf(_("Updating %s..%s\n"),
-                              find_unique_abbrev(&head_commit->object.oid,
-                                                 DEFAULT_ABBREV),
-                              find_unique_abbrev(&remoteheads->item->object.oid,
-                                                 DEFAULT_ABBREV));
+                              repo_find_unique_abbrev(the_repository, &head_commit->object.oid,
+                                                      DEFAULT_ABBREV),
+                              repo_find_unique_abbrev(the_repository, &remoteheads->item->object.oid,
+                                                      DEFAULT_ABBREV));
                }
                commit = remoteheads->item;
                if (!commit) {
index 97959bfaf9eb018dbe83780f60093e3f04f7be42..35fd89f794d4bdeb7720ce2114bab5a1565ad1f9 100644 (file)
@@ -493,7 +493,8 @@ static void show_name(const struct object *obj,
        else if (allow_undefined)
                printf("undefined\n");
        else if (always)
-               printf("%s\n", find_unique_abbrev(oid, DEFAULT_ABBREV));
+               printf("%s\n",
+                      repo_find_unique_abbrev(the_repository, oid, DEFAULT_ABBREV));
        else
                die("cannot describe '%s'", oid_to_hex(oid));
        strbuf_release(&buf);
@@ -527,7 +528,7 @@ static void name_rev_line(char *p, struct name_ref_data *data)
                        counter = 0;
 
                        *(p+1) = 0;
-                       if (!get_oid(p - (hexsz - 1), &oid)) {
+                       if (!repo_get_oid(the_repository, p - (hexsz - 1), &oid)) {
                                struct object *o =
                                        lookup_object(the_repository, &oid);
                                if (o)
@@ -604,7 +605,7 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
                struct object *object;
                struct commit *commit;
 
-               if (get_oid(*argv, &oid)) {
+               if (repo_get_oid(the_repository, *argv, &oid)) {
                        fprintf(stderr, "Could not get sha1 for %s. Skipping.\n",
                                        *argv);
                        continue;
index 80d9dfd25cad2afcb90c0219894529bcc1558cac..d98460e5d617a2300632ca01c22bbb3ca31788fd 100644 (file)
@@ -257,7 +257,7 @@ static int parse_reuse_arg(const struct option *opt, const char *arg, int unset)
        if (d->buf.len)
                strbuf_addch(&d->buf, '\n');
 
-       if (get_oid(arg, &object))
+       if (repo_get_oid(the_repository, arg, &object))
                die(_("failed to resolve '%s' as a valid ref."), arg);
        if (!(buf = read_object_file(&object, &type, &len)))
                die(_("failed to read object '%s'."), arg);
@@ -307,9 +307,9 @@ static int notes_copy_from_stdin(int force, const char *rewrite_cmd)
                        die(_("malformed input line: '%s'."), buf.buf);
                strbuf_rtrim(split[0]);
                strbuf_rtrim(split[1]);
-               if (get_oid(split[0]->buf, &from_obj))
+               if (repo_get_oid(the_repository, split[0]->buf, &from_obj))
                        die(_("failed to resolve '%s' as a valid ref."), split[0]->buf);
-               if (get_oid(split[1]->buf, &to_obj))
+               if (repo_get_oid(the_repository, split[1]->buf, &to_obj))
                        die(_("failed to resolve '%s' as a valid ref."), split[1]->buf);
 
                if (rewrite_cmd)
@@ -377,7 +377,7 @@ static int list(int argc, const char **argv, const char *prefix)
 
        t = init_notes_check("list", 0);
        if (argc) {
-               if (get_oid(argv[0], &object))
+               if (repo_get_oid(the_repository, argv[0], &object))
                        die(_("failed to resolve '%s' as a valid ref."), argv[0]);
                note = get_note(t, &object);
                if (note) {
@@ -432,7 +432,7 @@ static int add(int argc, const char **argv, const char *prefix)
 
        object_ref = argc > 1 ? argv[1] : "HEAD";
 
-       if (get_oid(object_ref, &object))
+       if (repo_get_oid(the_repository, object_ref, &object))
                die(_("failed to resolve '%s' as a valid ref."), object_ref);
 
        t = init_notes_check("add", NOTES_INIT_WRITABLE);
@@ -520,12 +520,12 @@ static int copy(int argc, const char **argv, const char *prefix)
                usage_with_options(git_notes_copy_usage, options);
        }
 
-       if (get_oid(argv[0], &from_obj))
+       if (repo_get_oid(the_repository, argv[0], &from_obj))
                die(_("failed to resolve '%s' as a valid ref."), argv[0]);
 
        object_ref = 1 < argc ? argv[1] : "HEAD";
 
-       if (get_oid(object_ref, &object))
+       if (repo_get_oid(the_repository, object_ref, &object))
                die(_("failed to resolve '%s' as a valid ref."), object_ref);
 
        t = init_notes_check("copy", NOTES_INIT_WRITABLE);
@@ -604,7 +604,7 @@ static int append_edit(int argc, const char **argv, const char *prefix)
 
        object_ref = 1 < argc ? argv[1] : "HEAD";
 
-       if (get_oid(object_ref, &object))
+       if (repo_get_oid(the_repository, object_ref, &object))
                die(_("failed to resolve '%s' as a valid ref."), object_ref);
 
        t = init_notes_check(argv[0], NOTES_INIT_WRITABLE);
@@ -666,7 +666,7 @@ static int show(int argc, const char **argv, const char *prefix)
 
        object_ref = argc ? argv[0] : "HEAD";
 
-       if (get_oid(object_ref, &object))
+       if (repo_get_oid(the_repository, object_ref, &object))
                die(_("failed to resolve '%s' as a valid ref."), object_ref);
 
        t = init_notes_check("show", 0);
@@ -716,7 +716,7 @@ static int merge_commit(struct notes_merge_options *o)
         * and target notes ref from .git/NOTES_MERGE_REF.
         */
 
-       if (get_oid("NOTES_MERGE_PARTIAL", &oid))
+       if (repo_get_oid(the_repository, "NOTES_MERGE_PARTIAL", &oid))
                die(_("failed to read ref NOTES_MERGE_PARTIAL"));
        else if (!(partial = lookup_commit_reference(the_repository, &oid)))
                die(_("could not find commit from NOTES_MERGE_PARTIAL."));
@@ -895,7 +895,7 @@ static int remove_one_note(struct notes_tree *t, const char *name, unsigned flag
 {
        int status;
        struct object_id oid;
-       if (get_oid(name, &oid))
+       if (repo_get_oid(the_repository, name, &oid))
                return error(_("Failed to resolve '%s' as a valid ref."), name);
        status = remove_note(t, oid.hash);
        if (status)
index 27192201086877115157d6f5cedb2f8fc1e231a6..93be90825dcb16484afa1075ecfef98d77e399b5 100644 (file)
@@ -168,7 +168,7 @@ int cmd_prune(int argc, const char **argv, const char *prefix)
                struct object_id oid;
                const char *name = *argv++;
 
-               if (!get_oid(name, &oid)) {
+               if (!repo_get_oid(the_repository, name, &oid)) {
                        struct object *object = parse_object_or_die(&oid,
                                                                    name);
                        add_pending_object(&revs, object, "");
index 1ab4de0005da3f6d2aa4b6a93d61544818af8700..880eebcdd657bfa19fc78e2d20e855a2a36436ca 100644 (file)
@@ -1036,7 +1036,7 @@ int cmd_pull(int argc, const char **argv, const char *prefix)
        if (file_exists(git_path_merge_head(the_repository)))
                die_conclude_merge();
 
-       if (get_oid("HEAD", &orig_head))
+       if (repo_get_oid(the_repository, "HEAD", &orig_head))
                oidclr(&orig_head);
 
        if (opt_rebase) {
@@ -1061,7 +1061,7 @@ int cmd_pull(int argc, const char **argv, const char *prefix)
        if (opt_dry_run)
                return 0;
 
-       if (get_oid("HEAD", &curr_head))
+       if (repo_get_oid(the_repository, "HEAD", &curr_head))
                oidclr(&curr_head);
 
        if (!is_null_oid(&orig_head) && !is_null_oid(&curr_head) &&
index aecfae12d3ae0777a57bec2c02dffa7cffde3d8f..556ee84b6d36d71c63cfbcaaba328a03d40541f5 100644 (file)
@@ -65,20 +65,20 @@ int cmd_range_diff(int argc, const char **argv, const char *prefix)
 
        if (dash_dash == 3 ||
            (dash_dash < 0 && argc > 2 &&
-            !get_oid_committish(argv[0], &oid) &&
-            !get_oid_committish(argv[1], &oid) &&
-            !get_oid_committish(argv[2], &oid))) {
+            !repo_get_oid_committish(the_repository, argv[0], &oid) &&
+            !repo_get_oid_committish(the_repository, argv[1], &oid) &&
+            !repo_get_oid_committish(the_repository, argv[2], &oid))) {
                if (dash_dash < 0)
                        ; /* already validated arguments */
-               else if (get_oid_committish(argv[0], &oid))
+               else if (repo_get_oid_committish(the_repository, argv[0], &oid))
                        usage_msg_optf(_("not a revision: '%s'"),
                                       builtin_range_diff_usage, options,
                                       argv[0]);
-               else if (get_oid_committish(argv[1], &oid))
+               else if (repo_get_oid_committish(the_repository, argv[1], &oid))
                        usage_msg_optf(_("not a revision: '%s'"),
                                       builtin_range_diff_usage, options,
                                       argv[1]);
-               else if (get_oid_committish(argv[2], &oid))
+               else if (repo_get_oid_committish(the_repository, argv[2], &oid))
                        usage_msg_optf(_("not a revision: '%s'"),
                                       builtin_range_diff_usage, options,
                                       argv[2]);
index 3ce75417833bf9f57ca1ddfa17a53c67ef39a9d8..a1c6aa9641ce6e4632232f887d671cf3895cb5ba 100644 (file)
@@ -198,7 +198,7 @@ int cmd_read_tree(int argc, const char **argv, const char *cmd_prefix)
        for (i = 0; i < argc; i++) {
                const char *arg = argv[i];
 
-               if (get_oid(arg, &oid))
+               if (repo_get_oid(the_repository, arg, &oid))
                        die("Not a valid object name %s", arg);
                if (list_tree(&oid) < 0)
                        die("failed to unpack tree object %s", arg);
index 6635f10d5294d16d017eae225de799efb7b1b9aa..d5358ca89d2a77d6a83c5b493532f4df8c492049 100644 (file)
@@ -218,13 +218,15 @@ static int get_revision_ranges(struct commit *upstream, struct commit *onto,
        *revisions = xstrfmt("%s...%s", oid_to_hex(&base_rev->object.oid),
                             oid_to_hex(orig_head));
 
-       shorthead = find_unique_abbrev(orig_head, DEFAULT_ABBREV);
+       shorthead = repo_find_unique_abbrev(the_repository, orig_head,
+                                           DEFAULT_ABBREV);
 
        if (upstream) {
                const char *shortrev;
 
-               shortrev = find_unique_abbrev(&base_rev->object.oid,
-                                             DEFAULT_ABBREV);
+               shortrev = repo_find_unique_abbrev(the_repository,
+                                                  &base_rev->object.oid,
+                                                  DEFAULT_ABBREV);
 
                *shortrevisions = xstrfmt("%s..%s", shortrev, shorthead);
        } else
@@ -1261,7 +1263,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
                int fd;
 
                /* Sanity check */
-               if (get_oid("HEAD", &head))
+               if (repo_get_oid(the_repository, "HEAD", &head))
                        die(_("Cannot read HEAD"));
 
                fd = repo_hold_locked_index(the_repository, &lock_file, 0);
@@ -1680,7 +1682,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
        } else if (!options.onto_name)
                options.onto_name = options.upstream_name;
        if (strstr(options.onto_name, "...")) {
-               if (get_oid_mb(options.onto_name, &branch_base) < 0) {
+               if (repo_get_oid_mb(the_repository, options.onto_name, &branch_base) < 0) {
                        if (keep_base)
                                die(_("'%s': need exactly one merge base with branch"),
                                    options.upstream_name);
index cd5c7a28eff08f048b79a9d739800709c443c160..b5816624d25fa2b3898e9a2fa5af80a635eac315 100644 (file)
@@ -1347,7 +1347,7 @@ static int head_has_history(void)
 {
        struct object_id oid;
 
-       return !get_oid("HEAD", &oid);
+       return !repo_get_oid(the_repository, "HEAD", &oid);
 }
 
 static const char *push_to_deploy(unsigned char *sha1,
@@ -1681,11 +1681,11 @@ static void check_aliased_update_internal(struct command *cmd,
        rp_error("refusing inconsistent update between symref '%s' (%s..%s) and"
                 " its target '%s' (%s..%s)",
                 cmd->ref_name,
-                find_unique_abbrev(&cmd->old_oid, DEFAULT_ABBREV),
-                find_unique_abbrev(&cmd->new_oid, DEFAULT_ABBREV),
+                repo_find_unique_abbrev(the_repository, &cmd->old_oid, DEFAULT_ABBREV),
+                repo_find_unique_abbrev(the_repository, &cmd->new_oid, DEFAULT_ABBREV),
                 dst_cmd->ref_name,
-                find_unique_abbrev(&dst_cmd->old_oid, DEFAULT_ABBREV),
-                find_unique_abbrev(&dst_cmd->new_oid, DEFAULT_ABBREV));
+                repo_find_unique_abbrev(the_repository, &dst_cmd->old_oid, DEFAULT_ABBREV),
+                repo_find_unique_abbrev(the_repository, &dst_cmd->new_oid, DEFAULT_ABBREV));
 
        cmd->error_string = dst_cmd->error_string =
                "inconsistent aliased update";
index a29e911d3099be9d327ecc030d68c56fe046a04a..33c6cdb79c8143a301b5887d6e1eb477a9ca1463 100644 (file)
@@ -54,7 +54,7 @@ static int show_reference(struct repository *r, const char *refname,
                        struct object_id object;
                        enum object_type obj_type, repl_type;
 
-                       if (get_oid(refname, &object))
+                       if (repo_get_oid(the_repository, refname, &object))
                                return error(_("failed to resolve '%s' as a valid ref"), refname);
 
                        obj_type = oid_object_info(r, &object, NULL);
@@ -112,7 +112,7 @@ static int for_each_replace_name(const char **argv, each_replace_name_fn fn)
        base_len = ref.len;
 
        for (p = argv; *p; p++) {
-               if (get_oid(*p, &oid)) {
+               if (repo_get_oid(the_repository, *p, &oid)) {
                        error("failed to resolve '%s' as a valid ref", *p);
                        had_error = 1;
                        continue;
@@ -206,10 +206,10 @@ static int replace_object(const char *object_ref, const char *replace_ref, int f
 {
        struct object_id object, repl;
 
-       if (get_oid(object_ref, &object))
+       if (repo_get_oid(the_repository, object_ref, &object))
                return error(_("failed to resolve '%s' as a valid ref"),
                             object_ref);
-       if (get_oid(replace_ref, &repl))
+       if (repo_get_oid(the_repository, replace_ref, &repl))
                return error(_("failed to resolve '%s' as a valid ref"),
                             replace_ref);
 
@@ -320,7 +320,7 @@ static int edit_and_replace(const char *object_ref, int force, int raw)
        struct object_id old_oid, new_oid, prev;
        struct strbuf ref = STRBUF_INIT;
 
-       if (get_oid(object_ref, &old_oid) < 0)
+       if (repo_get_oid(the_repository, object_ref, &old_oid) < 0)
                return error(_("not a valid object name: '%s'"), object_ref);
 
        type = oid_object_info(the_repository, &old_oid, NULL);
@@ -375,7 +375,7 @@ static int replace_parents(struct strbuf *buf, int argc, const char **argv)
                struct object_id oid;
                struct commit *commit;
 
-               if (get_oid(argv[i], &oid) < 0) {
+               if (repo_get_oid(the_repository, argv[i], &oid) < 0) {
                        strbuf_release(&new_parents);
                        return error(_("not a valid object name: '%s'"),
                                     argv[i]);
@@ -422,7 +422,7 @@ static int check_one_mergetag(struct commit *commit,
        /* iterate over new parents */
        for (i = 1; i < mergetag_data->argc; i++) {
                struct object_id oid;
-               if (get_oid(mergetag_data->argv[i], &oid) < 0)
+               if (repo_get_oid(the_repository, mergetag_data->argv[i], &oid) < 0)
                        return error(_("not a valid object name: '%s'"),
                                     mergetag_data->argv[i]);
                if (oideq(get_tagged_oid(tag), &oid))
@@ -452,7 +452,7 @@ static int create_graft(int argc, const char **argv, int force, int gentle)
        const char *buffer;
        unsigned long size;
 
-       if (get_oid(old_ref, &old_oid) < 0)
+       if (repo_get_oid(the_repository, old_ref, &old_oid) < 0)
                return error(_("not a valid object name: '%s'"), old_ref);
        commit = lookup_commit_reference(the_repository, &old_oid);
        if (!commit)
index 0697fa89de22414a58cce94b5f129c9e97d03fa1..75b447ffdc67ed3bd343c27135b3e998c57557de 100644 (file)
@@ -89,7 +89,7 @@ static int reset_index(const char *ref, const struct object_id *oid, int reset_t
 
        if (reset_type == KEEP) {
                struct object_id head_oid;
-               if (get_oid("HEAD", &head_oid))
+               if (repo_get_oid(the_repository, "HEAD", &head_oid))
                        return error(_("You do not have a valid HEAD."));
                if (!fill_tree_descriptor(the_repository, desc + nr, &head_oid))
                        return error(_("Failed to find tree of HEAD."));
@@ -124,7 +124,7 @@ static void print_new_head_line(struct commit *commit)
        struct strbuf buf = STRBUF_INIT;
 
        printf(_("HEAD is now at %s"),
-               find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV));
+               repo_find_unique_abbrev(the_repository, &commit->object.oid, DEFAULT_ABBREV));
 
        pp_commit_easy(CMIT_FMT_ONELINE, commit, &buf);
        if (buf.len > 0)
@@ -260,8 +260,8 @@ static void parse_args(struct pathspec *pathspec,
                 * has to be unambiguous. If there is a single argument, it
                 * can not be a tree
                 */
-               else if ((!argv[1] && !get_oid_committish(argv[0], &unused)) ||
-                        (argv[1] && !get_oid_treeish(argv[0], &unused))) {
+               else if ((!argv[1] && !repo_get_oid_committish(the_repository, argv[0], &unused)) ||
+                        (argv[1] && !repo_get_oid_treeish(the_repository, argv[0], &unused))) {
                        /*
                         * Ok, argv[0] looks like a commit/tree; it should not
                         * be a filename.
@@ -288,9 +288,9 @@ static int reset_refs(const char *rev, const struct object_id *oid)
        struct object_id *orig = NULL, oid_orig,
                *old_orig = NULL, oid_old_orig;
 
-       if (!get_oid("ORIG_HEAD", &oid_old_orig))
+       if (!repo_get_oid(the_repository, "ORIG_HEAD", &oid_old_orig))
                old_orig = &oid_old_orig;
-       if (!get_oid("HEAD", &oid_orig)) {
+       if (!repo_get_oid(the_repository, "HEAD", &oid_orig)) {
                orig = &oid_orig;
                set_reflog_message(&msg, "updating ORIG_HEAD", NULL);
                update_ref(msg.buf, "ORIG_HEAD", orig, old_orig, 0,
@@ -365,13 +365,14 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
                die(_("the option '%s' requires '%s'"), "--pathspec-file-nul", "--pathspec-from-file");
        }
 
-       unborn = !strcmp(rev, "HEAD") && get_oid("HEAD", &oid);
+       unborn = !strcmp(rev, "HEAD") && repo_get_oid(the_repository, "HEAD",
+                                                     &oid);
        if (unborn) {
                /* reset on unborn branch: treat as reset to empty tree */
                oidcpy(&oid, the_hash_algo->empty_tree);
        } else if (!pathspec.nr && !patch_mode) {
                struct commit *commit;
-               if (get_oid_committish(rev, &oid))
+               if (repo_get_oid_committish(the_repository, rev, &oid))
                        die(_("Failed to resolve '%s' as a valid revision."), rev);
                commit = lookup_commit_reference(the_repository, &oid);
                if (!commit)
@@ -379,7 +380,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
                oidcpy(&oid, &commit->object.oid);
        } else {
                struct tree *tree;
-               if (get_oid_treeish(rev, &oid))
+               if (repo_get_oid_treeish(the_repository, rev, &oid))
                        die(_("Failed to resolve '%s' as a valid tree."), rev);
                tree = parse_tree_indirect(&oid);
                if (!tree)
index d42db0b0cc9fa22ad8674ceddef8d1c735791f37..0f55eae22eb8f1185ceeee3c9e8d70fb6b516c90 100644 (file)
@@ -134,7 +134,7 @@ static void show_commit(struct commit *commit, void *data)
                if (!revs->graph)
                        fputs(get_revision_mark(revs, commit), stdout);
                if (revs->abbrev_commit && revs->abbrev)
-                       fputs(find_unique_abbrev(&commit->object.oid, revs->abbrev),
+                       fputs(repo_find_unique_abbrev(the_repository, &commit->object.oid, revs->abbrev),
                              stdout);
                else
                        fputs(oid_to_hex(&commit->object.oid), stdout);
index e67999e5ebc5ef640fe5dcd45dfa1b4126a9c7a8..eb53a303de66db9c67f5a8da20f84cadcd776d94 100644 (file)
@@ -162,7 +162,8 @@ static void show_rev(int type, const struct object_id *oid, const char *name)
                }
        }
        else if (abbrev)
-               show_with_type(type, find_unique_abbrev(oid, abbrev));
+               show_with_type(type,
+                              repo_find_unique_abbrev(the_repository, oid, abbrev));
        else
                show_with_type(type, oid_to_hex(oid));
 }
@@ -187,7 +188,7 @@ static int show_default(void)
                struct object_id oid;
 
                def = NULL;
-               if (!get_oid(s, &oid)) {
+               if (!repo_get_oid(the_repository, s, &oid)) {
                        show_rev(NORMAL, &oid, s);
                        return 1;
                }
@@ -279,7 +280,7 @@ static int try_difference(const char *arg)
                return 0;
        }
 
-       if (!get_oid_committish(start, &start_oid) && !get_oid_committish(end, &end_oid)) {
+       if (!repo_get_oid_committish(the_repository, start, &start_oid) && !repo_get_oid_committish(the_repository, end, &end_oid)) {
                show_rev(NORMAL, &end_oid, end);
                show_rev(symmetric ? NORMAL : REVERSED, &start_oid, start);
                if (symmetric) {
@@ -337,7 +338,7 @@ static int try_parent_shorthands(const char *arg)
                return 0;
 
        *dotdot = 0;
-       if (get_oid_committish(arg, &oid) ||
+       if (repo_get_oid_committish(the_repository, arg, &oid) ||
            !(commit = lookup_commit_reference(the_repository, &oid))) {
                *dotdot = '^';
                return 0;
@@ -868,7 +869,8 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)
                                continue;
                        }
                        if (skip_prefix(arg, "--disambiguate=", &arg)) {
-                               for_each_abbrev(arg, show_abbrev, NULL);
+                               repo_for_each_abbrev(the_repository, arg,
+                                                    show_abbrev, NULL);
                                continue;
                        }
                        if (!strcmp(arg, "--bisect")) {
index 8844f90655799b16f59080c8a69ca86fcbb9fd6f..25130f1b19e5225ab97c2c0862b529bb5e6782ce 100644 (file)
@@ -370,7 +370,7 @@ int cmd_rm(int argc, const char **argv, const char *prefix)
         */
        if (!force) {
                struct object_id oid;
-               if (get_oid("HEAD", &oid))
+               if (repo_get_oid(the_repository, "HEAD", &oid))
                        oidclr(&oid);
                if (check_local_mod(&oid, index_only))
                        exit(1);
index 358ac3e519a717f1a354b5d6fa00a8fcd8d77ca5..9e3b8ed27e14174d2b7ecf76a2c584a8e0fc5e1b 100644 (file)
@@ -312,8 +312,8 @@ static void show_one_commit(struct commit *commit, int no_name)
                }
                else
                        printf("[%s] ",
-                              find_unique_abbrev(&commit->object.oid,
-                                                 DEFAULT_ABBREV));
+                              repo_find_unique_abbrev(the_repository, &commit->object.oid,
+                                                      DEFAULT_ABBREV));
        }
        puts(pretty_str);
        strbuf_release(&pretty);
@@ -414,7 +414,7 @@ static int append_head_ref(const char *refname, const struct object_id *oid,
        /* If both heads/foo and tags/foo exists, get_sha1 would
         * get confused.
         */
-       if (get_oid(refname + ofs, &tmp) || !oideq(&tmp, oid))
+       if (repo_get_oid(the_repository, refname + ofs, &tmp) || !oideq(&tmp, oid))
                ofs = 5;
        return append_ref(refname + ofs, oid, 0);
 }
@@ -429,7 +429,7 @@ static int append_remote_ref(const char *refname, const struct object_id *oid,
        /* If both heads/foo and tags/foo exists, get_sha1 would
         * get confused.
         */
-       if (get_oid(refname + ofs, &tmp) || !oideq(&tmp, oid))
+       if (repo_get_oid(the_repository, refname + ofs, &tmp) || !oideq(&tmp, oid))
                ofs = 5;
        return append_ref(refname + ofs, oid, 0);
 }
@@ -533,7 +533,7 @@ static int show_independent(struct commit **rev,
 static void append_one_rev(const char *av)
 {
        struct object_id revkey;
-       if (!get_oid(av, &revkey)) {
+       if (!repo_get_oid(the_repository, av, &revkey)) {
                append_ref(av, &revkey, 0);
                return;
        }
@@ -836,7 +836,7 @@ int cmd_show_branch(int ac, const char **av, const char *prefix)
                        die(Q_("cannot handle more than %d rev.",
                               "cannot handle more than %d revs.",
                               MAX_REVS), MAX_REVS);
-               if (get_oid(ref_name[num_rev], &revkey))
+               if (repo_get_oid(the_repository, ref_name[num_rev], &revkey))
                        die(_("'%s' is not a valid ref."), ref_name[num_rev]);
                commit = lookup_commit_reference(the_repository, &revkey);
                if (!commit)
index 3af6a53ee9750ef5d4e45031ae0088d5e12f37a4..eb3ad1688ba3614cb273de27438538bbfeacd1b4 100644 (file)
@@ -33,7 +33,7 @@ static void show_one(const char *refname, const struct object_id *oid)
        if (quiet)
                return;
 
-       hex = find_unique_abbrev(oid, abbrev);
+       hex = repo_find_unique_abbrev(the_repository, oid, abbrev);
        if (hash_only)
                printf("%s\n", hex);
        else
@@ -43,7 +43,7 @@ static void show_one(const char *refname, const struct object_id *oid)
                return;
 
        if (!peel_iterated_oid(oid, &peeled)) {
-               hex = find_unique_abbrev(&peeled, abbrev);
+               hex = repo_find_unique_abbrev(the_repository, &peeled, abbrev);
                printf("%s %s^{}\n", hex, refname);
        }
 }
index c37381549181837ce4afe3659e5790e88485a816..c5c8b7b89c76f1031bc726e9761c1ba7eee61ce7 100644 (file)
@@ -471,7 +471,7 @@ static int sparse_checkout_init(int argc, const char **argv, const char *prefix)
                return update_working_directory(NULL);
        }
 
-       if (get_oid("HEAD", &oid)) {
+       if (repo_get_oid(the_repository, "HEAD", &oid)) {
                FILE *fp;
 
                /* assume we are in a fresh repo, but update the sparse-checkout file */
index 3a4f9fd566d27cfea7039f9c92f7a9730f37f912..ed1275829e7e4adb0136969c3b13cde2a40074f0 100644 (file)
@@ -201,7 +201,7 @@ static int get_stash_info(struct stash_info *info, int argc, const char **argv)
 
        revision = info->revision.buf;
 
-       if (get_oid(revision, &info->w_commit))
+       if (repo_get_oid(the_repository, revision, &info->w_commit))
                return error(_("%s is not a valid reference"), revision);
 
        assert_stash_like(info, revision);
@@ -231,7 +231,7 @@ static int get_stash_info(struct stash_info *info, int argc, const char **argv)
 static int do_clear_stash(void)
 {
        struct object_id obj;
-       if (get_oid(ref_stash, &obj))
+       if (repo_get_oid(the_repository, ref_stash, &obj))
                return 0;
 
        return delete_ref(NULL, ref_stash, &obj, 0);
@@ -1083,7 +1083,7 @@ static int check_changes_tracked_files(const struct pathspec *ps)
        int ret = 0;
 
        /* No initial commit. */
-       if (get_oid("HEAD", &dummy))
+       if (repo_get_oid(the_repository, "HEAD", &dummy))
                return -1;
 
        if (repo_read_index(the_repository) < 0)
@@ -1355,7 +1355,7 @@ static int do_create_stash(const struct pathspec *ps, struct strbuf *stash_msg_b
                goto done;
        }
 
-       if (get_oid("HEAD", &info->b_commit)) {
+       if (repo_get_oid(the_repository, "HEAD", &info->b_commit)) {
                if (!quiet)
                        fprintf_ln(stderr, _("You do not have "
                                             "the initial commit yet"));
@@ -1373,8 +1373,9 @@ static int do_create_stash(const struct pathspec *ps, struct strbuf *stash_msg_b
        branch_ref = resolve_ref_unsafe("HEAD", 0, NULL, &flags);
        if (flags & REF_ISSYMREF)
                skip_prefix(branch_ref, "refs/heads/", &branch_name);
-       head_short_sha1 = find_unique_abbrev(&head_commit->object.oid,
-                                            DEFAULT_ABBREV);
+       head_short_sha1 = repo_find_unique_abbrev(the_repository,
+                                                 &head_commit->object.oid,
+                                                 DEFAULT_ABBREV);
        strbuf_addf(&msg, "%s: %s ", branch_name, head_short_sha1);
        pp_commit_easy(CMIT_FMT_ONELINE, head_commit, &msg);
 
index 4c173d8b37adfc72ec840fd88ca27e36f432aef3..25c70f415f11eed1992b5c334365db170c3c0295 100644 (file)
@@ -1174,7 +1174,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)
        if (!summary_limit)
                return 0;
 
-       if (!get_oid(argc ? argv[0] : "HEAD", &head_oid)) {
+       if (!repo_get_oid(the_repository, argc ? argv[0] : "HEAD", &head_oid)) {
                if (argc) {
                        argv++;
                        argc--;
@@ -1187,7 +1187,7 @@ static int module_summary(int argc, const char **argv, const char *prefix)
                        argc--;
                }
        } else {
-               if (get_oid("HEAD", &head_oid))
+               if (repo_get_oid(the_repository, "HEAD", &head_oid))
                        die(_("could not fetch a revision for HEAD"));
        }
 
index d428c45dc8d812255336ed5da20804981d3be4ab..e6cbf6e5a8d2740d39b944ddab67746abbd8fec0 100644 (file)
@@ -137,7 +137,7 @@ static int delete_tags(const char **argv)
                if (!ref_exists(name))
                        printf(_("Deleted tag '%s' (was %s)\n"),
                                item->string + 10,
-                               find_unique_abbrev(oid, DEFAULT_ABBREV));
+                               repo_find_unique_abbrev(the_repository, oid, DEFAULT_ABBREV));
 
                free(oid);
        }
@@ -593,7 +593,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
        if (argc > 2)
                die(_("too many arguments"));
 
-       if (get_oid(object_ref, &object))
+       if (repo_get_oid(the_repository, object_ref, &object))
                die(_("Failed to resolve '%s' as a valid ref."), object_ref);
 
        if (strbuf_check_tag_ref(&ref, tag))
@@ -634,7 +634,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
        ref_transaction_free(transaction);
        if (force && !is_null_oid(&prev) && !oideq(&prev, &object))
                printf(_("Updated tag '%s' (was %s)\n"), tag,
-                      find_unique_abbrev(&prev, DEFAULT_ABBREV));
+                      repo_find_unique_abbrev(the_repository, &prev, DEFAULT_ABBREV));
 
 cleanup:
        ref_sorting_release(sorting);
index 88de32b7d7e66e3d7e1c57775b5f0a1b0b045175..e0d5178acc5fd30aaf78c2218a66cd9d23ff3ed8 100644 (file)
@@ -29,7 +29,7 @@ int cmd_unpack_file(int argc, const char **argv, const char *prefix)
 
        if (argc != 2 || !strcmp(argv[1], "-h"))
                usage("git unpack-file <blob>");
-       if (get_oid(argv[1], &oid))
+       if (repo_get_oid(the_repository, argv[1], &oid))
                die("Not a valid object name %s", argv[1]);
 
        git_config(git_default_config, NULL);
index a84e7b47a20620b421b9ab3782cdad4e52bc9e90..1ba0727ba77404252554196dc3bfa7812d89d2f7 100644 (file)
@@ -116,7 +116,7 @@ static int parse_next_oid(const char **next, const char *end,
                (*next)++;
                *next = parse_arg(*next, &arg);
                if (arg.len) {
-                       if (get_oid(arg.buf, oid))
+                       if (repo_get_oid(the_repository, arg.buf, oid))
                                goto invalid;
                } else {
                        /* Without -z, an empty value means all zeros: */
@@ -134,7 +134,7 @@ static int parse_next_oid(const char **next, const char *end,
                *next += arg.len;
 
                if (arg.len) {
-                       if (get_oid(arg.buf, oid))
+                       if (repo_get_oid(the_repository, arg.buf, oid))
                                goto invalid;
                } else if (flags & PARSE_SHA1_ALLOW_EMPTY) {
                        /* With -z, treat an empty value as all zeros: */
@@ -549,7 +549,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
                refname = argv[0];
                value = argv[1];
                oldval = argv[2];
-               if (get_oid(value, &oid))
+               if (repo_get_oid(the_repository, value, &oid))
                        die("%s: not a valid SHA1", value);
        }
 
@@ -560,7 +560,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
                         * must not already exist:
                         */
                        oidclr(&oldoid);
-               else if (get_oid(oldval, &oldoid))
+               else if (repo_get_oid(the_repository, oldval, &oldoid))
                        die("%s: not a valid old SHA1", oldval);
        }
 
index 3ebad32b0f14fffb5cfafce87411a534bccdf724..424b43083cb09a8b3bb60f721d6c09fac4a0af2a 100644 (file)
@@ -39,7 +39,7 @@ static int verify_commit(const char *name, unsigned flags)
        struct object_id oid;
        struct object *obj;
 
-       if (get_oid(name, &oid))
+       if (repo_get_oid(the_repository, name, &oid))
                return error("commit '%s' not found.", name);
 
        obj = parse_object(the_repository, &oid);
index 217566952d83ce0c657128d6d5e253bebc72f3bb..050fd29251514588ea59e7c2ab4f6c67a8ebaf70 100644 (file)
@@ -60,7 +60,7 @@ int cmd_verify_tag(int argc, const char **argv, const char *prefix)
                struct object_id oid;
                const char *name = argv[i++];
 
-               if (get_oid(name, &oid)) {
+               if (repo_get_oid(the_repository, name, &oid)) {
                        had_error = !!error("tag '%s' not found.", name);
                        continue;
                }
index 254283aa6f5716ab2ab83a477972b4630c056b1b..16fa30f01c81aaa2aa1b4a218481ddfcdc9f74c7 100644 (file)
@@ -552,7 +552,7 @@ static void print_preparing_worktree_line(int detach,
                else
                        fprintf_ln(stderr, _("Preparing worktree (resetting branch '%s'; was at %s)"),
                                  new_branch,
-                                 find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV));
+                                 repo_find_unique_abbrev(the_repository, &commit->object.oid, DEFAULT_ABBREV));
        } else if (new_branch) {
                fprintf_ln(stderr, _("Preparing worktree (new branch '%s')"), new_branch);
        } else {
@@ -566,7 +566,7 @@ static void print_preparing_worktree_line(int detach,
                        if (!commit)
                                die(_("invalid reference: %s"), branch);
                        fprintf_ln(stderr, _("Preparing worktree (detached HEAD %s)"),
-                                 find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV));
+                                 repo_find_unique_abbrev(the_repository, &commit->object.oid, DEFAULT_ABBREV));
                }
                strbuf_release(&s);
        }
@@ -756,7 +756,7 @@ static void show_worktree(struct worktree *wt, int path_maxlen, int abbrev_len)
                strbuf_addstr(&sb, "(bare)");
        else {
                strbuf_addf(&sb, "%-*s ", abbrev_len,
-                               find_unique_abbrev(&wt->head_oid, DEFAULT_ABBREV));
+                               repo_find_unique_abbrev(the_repository, &wt->head_oid, DEFAULT_ABBREV));
                if (wt->is_detached)
                        strbuf_addstr(&sb, "(detached HEAD)");
                else if (wt->head_ref) {
@@ -793,7 +793,7 @@ static void measure_widths(struct worktree **wt, int *abbrev, int *maxlen)
 
                if (path_len > *maxlen)
                        *maxlen = path_len;
-               sha1_len = strlen(find_unique_abbrev(&wt[i]->head_oid, *abbrev));
+               sha1_len = strlen(repo_find_unique_abbrev(the_repository, &wt[i]->head_oid, *abbrev));
                if (sha1_len > *abbrev)
                        *abbrev = sha1_len;
        }
diff --git a/cache.h b/cache.h
index 12789903e883df94783b75defa89fbbd5cbcca1f..d835ac8b4d204cc67bd470482c95214d42bb06b8 100644 (file)
--- a/cache.h
+++ b/cache.h
@@ -1211,9 +1211,7 @@ void check_repository_format(struct repository_format *fmt);
  * reentrant, as it calls into other non-reentrant git code.
  */
 const char *repo_find_unique_abbrev(struct repository *r, const struct object_id *oid, int len);
-#define find_unique_abbrev(oid, len) repo_find_unique_abbrev(the_repository, oid, len)
 int repo_find_unique_abbrev_r(struct repository *r, char *hex, const struct object_id *oid, int len);
-#define find_unique_abbrev_r(hex, oid, len) repo_find_unique_abbrev_r(the_repository, hex, oid, len)
 
 /* set default permissions by passing mode arguments to open(2) */
 int git_mkstemps_mode(char *pattern, int suffix_len, int mode);
@@ -1488,17 +1486,8 @@ enum get_oid_result get_oid_with_context(struct repository *repo, const char *st
                                         unsigned flags, struct object_id *oid,
                                         struct object_context *oc);
 
-#define get_oid(str, oid)              repo_get_oid(the_repository, str, oid)
-#define get_oid_commit(str, oid)       repo_get_oid_commit(the_repository, str, oid)
-#define get_oid_committish(str, oid)   repo_get_oid_committish(the_repository, str, oid)
-#define get_oid_tree(str, oid)         repo_get_oid_tree(the_repository, str, oid)
-#define get_oid_treeish(str, oid)      repo_get_oid_treeish(the_repository, str, oid)
-#define get_oid_blob(str, oid)         repo_get_oid_blob(the_repository, str, oid)
-#define get_oid_mb(str, oid)           repo_get_oid_mb(the_repository, str, oid)
-
 typedef int each_abbrev_fn(const struct object_id *oid, void *);
 int repo_for_each_abbrev(struct repository *r, const char *prefix, each_abbrev_fn, void *);
-#define for_each_abbrev(prefix, fn, data) repo_for_each_abbrev(the_repository, prefix, fn, data)
 
 int set_disambiguate_hint_config(const char *var, const char *value);
 
@@ -1608,8 +1597,6 @@ int repo_interpret_branch_name(struct repository *r,
                               const char *str, int len,
                               struct strbuf *buf,
                               const struct interpret_branch_name_options *options);
-#define interpret_branch_name(str, len, buf, options) \
-       repo_interpret_branch_name(the_repository, str, len, buf, options)
 
 int validate_headref(const char *ref);
 
@@ -1629,8 +1616,6 @@ void *read_object_with_reference(struct repository *r,
 struct object *repo_peel_to_type(struct repository *r,
                                 const char *name, int namelen,
                                 struct object *o, enum object_type);
-#define peel_to_type(name, namelen, obj, type) \
-       repo_peel_to_type(the_repository, name, namelen, obj, type)
 
 #define IDENT_STRICT          1
 #define IDENT_NO_DATE         2
index 2e39dae684f8f0a048d172f36b21740f92e7de57..1247b8822481a6face3fc47a45ec2ce1bf298c06 100644 (file)
@@ -23,7 +23,7 @@ static int check_tracking_name(struct remote *remote, void *cb_data)
        memset(&query, 0, sizeof(struct refspec_item));
        query.src = cb->src_ref;
        if (remote_find_tracking(remote, &query) ||
-           get_oid(query.dst, cb->dst_oid)) {
+           repo_get_oid(the_repository, query.dst, cb->dst_oid)) {
                free(query.dst);
                return 0;
        }
index 1a39b5dde0946df0c1e36c7b1f4c48552885985a..d84ab878b72fd3dcec73af65f9fe421a39be539c 100644 (file)
@@ -948,11 +948,11 @@ static void show_combined_header(struct combine_diff_path *elem,
                         "", elem->path, line_prefix, c_meta, c_reset);
        printf("%s%sindex ", line_prefix, c_meta);
        for (i = 0; i < num_parent; i++) {
-               abb = find_unique_abbrev(&elem->parent[i].oid,
-                                        abbrev);
+               abb = repo_find_unique_abbrev(the_repository,
+                                             &elem->parent[i].oid, abbrev);
                printf("%s%s", i ? "," : "", abb);
        }
-       abb = find_unique_abbrev(&elem->oid, abbrev);
+       abb = repo_find_unique_abbrev(the_repository, &elem->oid, abbrev);
        printf("..%s%s\n", abb, c_reset);
 
        if (mode_differs) {
index e433c33bb01fa6e3688a0b163c44d62f204d62d0..06a7c728e80d8fac3d2dc1f0dadf40c43159e241 100644 (file)
--- a/commit.c
+++ b/commit.c
@@ -80,7 +80,7 @@ struct commit *lookup_commit_reference_by_name(const char *name)
        struct object_id oid;
        struct commit *commit;
 
-       if (get_oid_committish(name, &oid))
+       if (repo_get_oid_committish(the_repository, name, &oid))
                return NULL;
        commit = lookup_commit_reference(the_repository, &oid);
        if (parse_commit(commit))
@@ -1271,7 +1271,8 @@ void verify_merge_signature(struct commit *commit, int verbosity,
 
        ret = check_commit_signature(commit, &signature_check);
 
-       find_unique_abbrev_r(hex, &commit->object.oid, DEFAULT_ABBREV);
+       repo_find_unique_abbrev_r(the_repository, hex, &commit->object.oid,
+                                 DEFAULT_ABBREV);
        switch (signature_check.result) {
        case 'G':
                if (ret || (check_trust && signature_check.trust_level < TRUST_MARGINAL))
@@ -1632,10 +1633,11 @@ struct commit *get_merge_parent(const char *name)
        struct object *obj;
        struct commit *commit;
        struct object_id oid;
-       if (get_oid(name, &oid))
+       if (repo_get_oid(the_repository, name, &oid))
                return NULL;
        obj = parse_object(the_repository, &oid);
-       commit = (struct commit *)peel_to_type(name, 0, obj, OBJ_COMMIT);
+       commit = (struct commit *)repo_peel_to_type(the_repository, name, 0,
+                                                   obj, OBJ_COMMIT);
        if (commit && !merge_remote_util(commit))
                set_merge_remote_desc(commit, name, obj);
        return commit;
diff --git a/contrib/coccinelle/the_repository.cocci b/contrib/coccinelle/the_repository.cocci
new file mode 100644 (file)
index 0000000..dcdba31
--- /dev/null
@@ -0,0 +1,44 @@
+// Fully migrated "the_repository" additions
+@@
+@@
+(
+// cache.h
+- get_oid
++ repo_get_oid
+|
+- get_oid_commit
++ repo_get_oid_commit
+|
+- get_oid_committish
++ repo_get_oid_committish
+|
+- get_oid_tree
++ repo_get_oid_tree
+|
+- get_oid_treeish
++ repo_get_oid_treeish
+|
+- get_oid_blob
++ repo_get_oid_blob
+|
+- get_oid_mb
++ repo_get_oid_mb
+|
+- find_unique_abbrev
++ repo_find_unique_abbrev
+|
+- find_unique_abbrev_r
++ repo_find_unique_abbrev_r
+|
+- for_each_abbrev
++ repo_for_each_abbrev
+|
+- interpret_branch_name
++ repo_interpret_branch_name
+|
+- peel_to_type
++ repo_peel_to_type
+)
+  (
++ the_repository,
+  ...)
index 8b3f2580e6b9b0eadbca3d83eafeefa0e0ddad40..2d200ab83e767d3cdc6927157806dd263d73c38c 100644 (file)
@@ -5,44 +5,7 @@
 @@
 @@
 (
-// cache.h
-- get_oid
-+ repo_get_oid
-|
-- get_oid_commit
-+ repo_get_oid_commit
-|
-- get_oid_committish
-+ repo_get_oid_committish
-|
-- get_oid_tree
-+ repo_get_oid_tree
-|
-- get_oid_treeish
-+ repo_get_oid_treeish
-|
-- get_oid_blob
-+ repo_get_oid_blob
-|
-- get_oid_mb
-+ repo_get_oid_mb
-|
-- find_unique_abbrev
-+ repo_find_unique_abbrev
-|
-- find_unique_abbrev_r
-+ repo_find_unique_abbrev_r
-|
-- for_each_abbrev
-+ repo_for_each_abbrev
-|
-- interpret_branch_name
-+ repo_interpret_branch_name
-|
-- peel_to_type
-+ repo_peel_to_type
 // commit-reach.h
-|
 - get_merge_bases
 + repo_get_merge_bases
 |
index dec040c366c82a71bc57bad9cf9db865182efe20..24470b21612a27c826a882afc29c4463ccd74a74 100644 (file)
@@ -581,7 +581,7 @@ void diff_get_merge_base(const struct rev_info *revs, struct object_id *mb)
        if (revs->pending.nr == 1) {
                struct object_id oid;
 
-               if (get_oid("HEAD", &oid))
+               if (repo_get_oid(the_repository, "HEAD", &oid))
                        die(_("unable to get HEAD"));
 
                mb_child[1] = lookup_commit_reference(the_repository, &oid);
diff --git a/diff.c b/diff.c
index 469e18aed20ed0128bfa85774cb617d455287eaa..3abeca9d46c1dadd53f154110a3dffb69e3eb952 100644 (file)
--- a/diff.c
+++ b/diff.c
@@ -4351,7 +4351,7 @@ static int similarity_index(struct diff_filepair *p)
 static const char *diff_abbrev_oid(const struct object_id *oid, int abbrev)
 {
        if (startup_info->have_repository)
-               return find_unique_abbrev(oid, abbrev);
+               return repo_find_unique_abbrev(the_repository, oid, abbrev);
        else {
                char *hex = oid_to_hex(oid);
                if (abbrev < 0)
@@ -4988,7 +4988,7 @@ static int diff_opt_find_object(const struct option *option,
        struct object_id oid;
 
        BUG_ON_OPT_NEG(unset);
-       if (get_oid(arg, &oid))
+       if (repo_get_oid(the_repository, arg, &oid))
                return error(_("unable to resolve '%s'"), arg);
 
        if (!opt->objfind)
index f48f44f9cd1dbdd3aeafbe5a4bd3598e783d0e25..e8e2d4ea0d0330f974a894b580bbdbe15ead7836 100644 (file)
@@ -605,7 +605,9 @@ static void find_merge_parents(struct merge_parents *result,
                 * util field yet.
                 */
                obj = parse_object(the_repository, &oid);
-               parent = (struct commit *)peel_to_type(NULL, 0, obj, OBJ_COMMIT);
+               parent = (struct commit *)repo_peel_to_type(the_repository,
+                                                           NULL, 0, obj,
+                                                           OBJ_COMMIT);
                if (!parent)
                        continue;
                commit_list_insert(parent, &parents);
index 1dd5fcbf7be433740d83382db4c401d438a51720..f36adb947e8def5d8cff1d59d2cc1d5f3dcc654d 100644 (file)
@@ -233,7 +233,8 @@ static void show_parents(struct commit *commit, int abbrev, FILE *file)
        struct commit_list *p;
        for (p = commit->parents; p ; p = p->next) {
                struct commit *parent = p->item;
-               fprintf(file, " %s", find_unique_abbrev(&parent->object.oid, abbrev));
+               fprintf(file, " %s",
+                       repo_find_unique_abbrev(the_repository, &parent->object.oid, abbrev));
        }
 }
 
@@ -241,7 +242,8 @@ static void show_children(struct rev_info *opt, struct commit *commit, int abbre
 {
        struct commit_list *p = lookup_decoration(&opt->children, &commit->object);
        for ( ; p; p = p->next) {
-               fprintf(opt->diffopt.file, " %s", find_unique_abbrev(&p->item->object.oid, abbrev));
+               fprintf(opt->diffopt.file, " %s",
+                       repo_find_unique_abbrev(the_repository, &p->item->object.oid, abbrev));
        }
 }
 
@@ -644,7 +646,8 @@ void show_log(struct rev_info *opt)
 
                if (!opt->graph)
                        put_revision_mark(opt, commit);
-               fputs(find_unique_abbrev(&commit->object.oid, abbrev_commit), opt->diffopt.file);
+               fputs(repo_find_unique_abbrev(the_repository, &commit->object.oid, abbrev_commit),
+                     opt->diffopt.file);
                if (opt->print_parents)
                        show_parents(commit, abbrev_commit, opt->diffopt.file);
                if (opt->children.name)
@@ -706,8 +709,8 @@ void show_log(struct rev_info *opt)
 
                if (!opt->graph)
                        put_revision_mark(opt, commit);
-               fputs(find_unique_abbrev(&commit->object.oid,
-                                        abbrev_commit),
+               fputs(repo_find_unique_abbrev(the_repository, &commit->object.oid,
+                                             abbrev_commit),
                      opt->diffopt.file);
                if (opt->print_parents)
                        show_parents(commit, abbrev_commit, opt->diffopt.file);
@@ -715,7 +718,7 @@ void show_log(struct rev_info *opt)
                        show_children(opt, commit, abbrev_commit);
                if (parent)
                        fprintf(opt->diffopt.file, " (from %s)",
-                              find_unique_abbrev(&parent->object.oid, abbrev_commit));
+                              repo_find_unique_abbrev(the_repository, &parent->object.oid, abbrev_commit));
                fputs(diff_get_color_opt(&opt->diffopt, DIFF_RESET), opt->diffopt.file);
                show_decorations(opt, commit);
                if (opt->commit_format == CMIT_FMT_ONELINE) {
index da2589b08229813963347115a001d8ce6f45ae32..ed8289aea58bb434156ead76152b48c2a817fcd8 100644 (file)
--- a/mailmap.c
+++ b/mailmap.c
@@ -213,7 +213,7 @@ static int read_mailmap_blob(struct string_list *map, const char *name)
 
        if (!name)
                return 0;
-       if (get_oid(name, &oid) < 0)
+       if (repo_get_oid(the_repository, name, &oid) < 0)
                return 0;
 
        buf = read_object_file(&oid, &type, &size);
index b4cc594a790965aca297fe87392a50b643e6fb41..d290c7478e27a803c99aebc7558593b51c307553 100644 (file)
@@ -566,7 +566,7 @@ int notes_merge(struct notes_merge_options *o,
        trace_printf("\tlocal commit: %.7s\n", oid_to_hex(&local_oid));
 
        /* Dereference o->remote_ref into remote_oid */
-       if (get_oid(o->remote_ref, &remote_oid)) {
+       if (repo_get_oid(the_repository, o->remote_ref, &remote_oid)) {
                /*
                 * Failed to get remote_oid. If o->remote_ref looks like an
                 * unborn ref, perform the merge using an empty notes tree.
diff --git a/notes.c b/notes.c
index f2805d51bb15131c46d41fa9554c43ab2e9a492d..750e18c4004d454fc02358034c51129d24bed685 100644 (file)
--- a/notes.c
+++ b/notes.c
@@ -944,7 +944,7 @@ void string_list_add_refs_by_glob(struct string_list *list, const char *glob)
                for_each_glob_ref(string_list_add_one_ref, glob, list);
        } else {
                struct object_id oid;
-               if (get_oid(glob, &oid))
+               if (repo_get_oid(the_repository, glob, &oid))
                        warning("notes ref %s is invalid", glob);
                if (!unsorted_string_list_has_string(list, glob))
                        string_list_append(list, glob);
@@ -1021,7 +1021,7 @@ void init_notes(struct notes_tree *t, const char *notes_ref,
        t->dirty = 0;
 
        if (flags & NOTES_INIT_EMPTY || !notes_ref ||
-           get_oid_treeish(notes_ref, &object_oid))
+           repo_get_oid_treeish(the_repository, notes_ref, &object_oid))
                return;
        if (flags & NOTES_INIT_WRITABLE && read_ref(notes_ref, &object_oid))
                die("Cannot use notes ref %s", notes_ref);
@@ -1348,7 +1348,7 @@ void expand_loose_notes_ref(struct strbuf *sb)
 {
        struct object_id object;
 
-       if (get_oid(sb->buf, &object)) {
+       if (repo_get_oid(the_repository, sb->buf, &object)) {
                /* fallback to expand_notes_ref */
                expand_notes_ref(sb);
        }
index 2dd1a0f56e1e442dec47dfbbcdd46d58aecc812c..21e8f67489e0292ce6e5f86e32e7f0b18c89ff8e 100644 (file)
@@ -1666,7 +1666,8 @@ void strbuf_branchname(struct strbuf *sb, const char *name, unsigned allowed)
        struct interpret_branch_name_options options = {
                .allowed = allowed
        };
-       int used = interpret_branch_name(name, len, sb, &options);
+       int used = repo_interpret_branch_name(the_repository, name, len, sb,
+                                             &options);
 
        if (used < 0)
                used = 0;
@@ -1719,7 +1720,7 @@ int get_oidf(struct object_id *oid, const char *fmt, ...)
        strbuf_vaddf(&sb, fmt, ap);
        va_end(ap);
 
-       ret = get_oid(sb.buf, oid);
+       ret = repo_get_oid(the_repository, sb.buf, oid);
        strbuf_release(&sb);
 
        return ret;
index d346dbe2100ddceb53f8ce149ad4ed794b772f53..0f7b40d0c08fd46209c5457bd1c7444d01cd2ab4 100644 (file)
@@ -91,7 +91,7 @@ int parse_opt_commits(const struct option *opt, const char *arg, int unset)
 
        if (!arg)
                return -1;
-       if (get_oid(arg, &oid))
+       if (repo_get_oid(the_repository, arg, &oid))
                return error("malformed object name %s", arg);
        commit = lookup_commit_reference(the_repository, &oid);
        if (!commit)
@@ -110,7 +110,7 @@ int parse_opt_commit(const struct option *opt, const char *arg, int unset)
 
        if (!arg)
                return -1;
-       if (get_oid(arg, &oid))
+       if (repo_get_oid(the_repository, arg, &oid))
                return error("malformed object name %s", arg);
        commit = lookup_commit_reference(the_repository, &oid);
        if (!commit)
@@ -129,7 +129,7 @@ int parse_opt_object_name(const struct option *opt, const char *arg, int unset)
        }
        if (!arg)
                return -1;
-       if (get_oid(arg, &oid))
+       if (repo_get_oid(the_repository, arg, &oid))
                return error(_("malformed object name '%s'"), arg);
        oid_array_append(opt->value, &oid);
        return 0;
@@ -146,7 +146,7 @@ int parse_opt_object_id(const struct option *opt, const char *arg, int unset)
        }
        if (!arg)
                return -1;
-       if (get_oid(arg, &oid))
+       if (repo_get_oid(the_repository, arg, &oid))
                return error(_("malformed object name '%s'"), arg);
        *target = oid;
        return 0;
index 4bd65ab7496ebf8c6f0ca9420ff16e8532cce71d..5bcf966f6c5d2332cca08f5bd21d2fdbaa6064cf 100644 (file)
@@ -94,7 +94,7 @@ static int read_patches(const char *range, struct string_list *list,
                                strbuf_reset(&buf);
                        }
                        CALLOC_ARRAY(util, 1);
-                       if (get_oid(p, &util->oid)) {
+                       if (repo_get_oid(the_repository, p, &util->oid)) {
                                error(_("could not parse commit '%s'"), p);
                                FREE_AND_NULL(util);
                                string_list_clear(list, 1);
@@ -390,7 +390,7 @@ static void output_pair_header(struct diff_options *diffopt,
 
        if (!dashes->len)
                strbuf_addchars(dashes, '-',
-                               strlen(find_unique_abbrev(oid, abbrev)));
+                               strlen(repo_find_unique_abbrev(the_repository, oid, abbrev)));
 
        if (!b_util) {
                color = color_old;
@@ -412,7 +412,7 @@ static void output_pair_header(struct diff_options *diffopt,
                strbuf_addf(buf, "%*s:  %s ", patch_no_width, "-", dashes->buf);
        else
                strbuf_addf(buf, "%*d:  %s ", patch_no_width, a_util->i + 1,
-                           find_unique_abbrev(&a_util->oid, abbrev));
+                           repo_find_unique_abbrev(the_repository, &a_util->oid, abbrev));
 
        if (status == '!')
                strbuf_addf(buf, "%s%s", color_reset, color);
@@ -424,7 +424,7 @@ static void output_pair_header(struct diff_options *diffopt,
                strbuf_addf(buf, " %*s:  %s", patch_no_width, "-", dashes->buf);
        else
                strbuf_addf(buf, " %*d:  %s", patch_no_width, b_util->i + 1,
-                           find_unique_abbrev(&b_util->oid, abbrev));
+                           repo_find_unique_abbrev(the_repository, &b_util->oid, abbrev));
 
        commit = lookup_commit_reference(the_repository, oid);
        if (commit) {
index 35e5657877c7a4ebd070654f7b252a99f05d702f..d6c69164d0fbf24484cd18445587d208a63a899e 100644 (file)
@@ -2628,7 +2628,7 @@ int repo_index_has_changes(struct repository *repo,
 
        if (tree)
                cmp = tree->object.oid;
-       if (tree || !get_oid_tree("HEAD", &cmp)) {
+       if (tree || !repo_get_oid_tree(the_repository, "HEAD", &cmp)) {
                struct diff_options opt;
 
                repo_diff_setup(repo, &opt);
index 7407c593191679c757573e567a28f35c65c9cb33..c151db0ad2f3748ceb54149bf6f2cbd95a6b1dcb 100644 (file)
@@ -187,7 +187,7 @@ int todo_list_check(struct todo_list *old_todo, struct todo_list *new_todo)
                struct commit *commit = item->commit;
                if (commit && !*commit_seen_at(&commit_seen, commit)) {
                        strbuf_addf(&missing, " - %s %.*s\n",
-                                   find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV),
+                                   repo_find_unique_abbrev(the_repository, &commit->object.oid, DEFAULT_ABBREV),
                                    item->arg_len,
                                    todo_item_get_arg(old_todo, item));
                        *commit_seen_at(&commit_seen, commit) = 1;
index f8203c6b05254b624cf98e6d4590d07064cbb101..c6cd131e70bb1aff61541585757b89898e46814b 100644 (file)
@@ -1075,9 +1075,11 @@ static const char *do_grab_oid(const char *field, const struct object_id *oid,
        case O_FULL:
                return oid_to_hex(oid);
        case O_LENGTH:
-               return find_unique_abbrev(oid, atom->u.oid.length);
+               return repo_find_unique_abbrev(the_repository, oid,
+                                              atom->u.oid.length);
        case O_SHORT:
-               return find_unique_abbrev(oid, DEFAULT_ABBREV);
+               return repo_find_unique_abbrev(the_repository, oid,
+                                              DEFAULT_ABBREV);
        default:
                BUG("unknown %%(%s) option", field);
        }
@@ -2765,7 +2767,7 @@ int parse_opt_merge_filter(const struct option *opt, const char *arg, int unset)
 
        BUG_ON_OPT_NEG(unset);
 
-       if (get_oid(arg, &oid))
+       if (repo_get_oid(the_repository, arg, &oid))
                die(_("malformed object name %s"), arg);
 
        merge_commit = lookup_commit_reference_gently(the_repository, &oid, 0);
index 60869beebe7364a594cd45938d4ed97dcdd28840..ff9b02383189429e8d7ee4f702067f44b8a1fdcc 100644 (file)
--- a/remote.c
+++ b/remote.c
@@ -1163,7 +1163,7 @@ static int try_explicit_object_name(const char *name,
                return 0;
        }
 
-       if (get_oid(name, &oid))
+       if (repo_get_oid(the_repository, name, &oid))
                return -1;
 
        if (match) {
@@ -1251,7 +1251,7 @@ static void show_push_unqualified_ref_name_error(const char *dst_value,
        if (!advice_enabled(ADVICE_PUSH_UNQUALIFIED_REF_NAME))
                return;
 
-       if (get_oid(matched_src_name, &oid))
+       if (repo_get_oid(the_repository, matched_src_name, &oid))
                BUG("'%s' is not a valid object, "
                    "match_explicit_lhs() should catch this!",
                    matched_src_name);
@@ -2505,7 +2505,7 @@ static int parse_push_cas_option(struct push_cas_option *cas, const char *arg, i
                entry->use_tracking = 1;
        else if (!colon[1])
                oidclr(&entry->expect);
-       else if (get_oid(colon + 1, &entry->expect))
+       else if (repo_get_oid(the_repository, colon + 1, &entry->expect))
                return error(_("cannot parse expected object name '%s'"),
                             colon + 1);
        return 0;
diff --git a/reset.c b/reset.c
index 5ded23611f3f7316e2327872a54474ce6e4f6200..3a9c6dfdd0a3650bf3cb36a76c40653dee29ec4b 100644 (file)
--- a/reset.c
+++ b/reset.c
@@ -38,7 +38,7 @@ static int update_refs(const struct reset_head_opts *opts,
        prefix_len = msg.len;
 
        if (update_orig_head) {
-               if (!get_oid("ORIG_HEAD", &oid_old_orig))
+               if (!repo_get_oid(the_repository, "ORIG_HEAD", &oid_old_orig))
                        old_orig = &oid_old_orig;
                if (head) {
                        if (!reflog_orig_head) {
@@ -106,7 +106,7 @@ int reset_head(struct repository *r, const struct reset_head_opts *opts)
                goto leave_reset_head;
        }
 
-       if (!get_oid("HEAD", &head_oid)) {
+       if (!repo_get_oid(the_repository, "HEAD", &head_oid)) {
                head = &head_oid;
        } else if (!oid || !reset_hard) {
                ret = error(_("could not determine HEAD revision"));
index 21f5f572c22ec7054da6bc20fef26ee2a59a19d5..0f775ee2e90058feeb3a1d6cd2731ab739840267 100644 (file)
@@ -324,7 +324,8 @@ static void add_pending_object_with_path(struct rev_info *revs,
        if (revs->reflog_info && obj->type == OBJ_COMMIT) {
                struct strbuf buf = STRBUF_INIT;
                size_t namelen = strlen(name);
-               int len = interpret_branch_name(name, namelen, &buf, &options);
+               int len = repo_interpret_branch_name(the_repository, name,
+                                                    namelen, &buf, &options);
 
                if (0 < len && len < namelen && buf.len)
                        strbuf_addstr(&buf, name + len);
@@ -354,7 +355,7 @@ void add_head_to_pending(struct rev_info *revs)
 {
        struct object_id oid;
        struct object *obj;
-       if (get_oid("HEAD", &oid))
+       if (repo_get_oid(the_repository, "HEAD", &oid))
                return;
        obj = parse_object(revs->repo, &oid);
        if (!obj)
@@ -1867,7 +1868,7 @@ static int add_parents_only(struct rev_info *revs, const char *arg_, int flags,
                flags ^= UNINTERESTING | BOTTOM;
                arg++;
        }
-       if (get_oid_committish(arg, &oid))
+       if (repo_get_oid_committish(the_repository, arg, &oid))
                return 0;
        while (1) {
                it = get_reference(revs, arg, &oid, 0);
@@ -1948,10 +1949,10 @@ static void prepare_show_merge(struct rev_info *revs)
        int i, prune_num = 1; /* counting terminating NULL */
        struct index_state *istate = revs->repo->index;
 
-       if (get_oid("HEAD", &oid))
+       if (repo_get_oid(the_repository, "HEAD", &oid))
                die("--merge without HEAD?");
        head = lookup_commit_or_die(&oid, "HEAD");
-       if (get_oid("MERGE_HEAD", &oid))
+       if (repo_get_oid(the_repository, "MERGE_HEAD", &oid))
                die("--merge without MERGE_HEAD?");
        other = lookup_commit_or_die(&oid, "MERGE_HEAD");
        add_pending_object(revs, &head->object, "HEAD");
index 1c96a75b1e9f8bbe9a7a2e40a3d4dd7bb80a9335..818932a630a18c3bb608ede09e43dbf6254dc688 100644 (file)
@@ -419,7 +419,8 @@ struct commit_message {
 
 static const char *short_commit_name(struct commit *commit)
 {
-       return find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV);
+       return repo_find_unique_abbrev(the_repository, &commit->object.oid,
+                                      DEFAULT_ABBREV);
 }
 
 static int get_message(struct commit *commit, struct commit_message *out)
@@ -561,7 +562,7 @@ static void update_abort_safety_file(void)
        if (!file_exists(git_path_seq_dir()))
                return;
 
-       if (!get_oid("HEAD", &head))
+       if (!repo_get_oid(the_repository, "HEAD", &head))
                write_file(git_path_abort_safety_file(), "%s", oid_to_hex(&head));
        else
                write_file(git_path_abort_safety_file(), "%s", "");
@@ -1406,7 +1407,7 @@ static int parse_head(struct repository *r, struct commit **head)
        struct commit *current_head;
        struct object_id oid;
 
-       if (get_oid("HEAD", &oid)) {
+       if (repo_get_oid(the_repository, "HEAD", &oid)) {
                current_head = NULL;
        } else {
                current_head = lookup_commit_reference(r, &oid);
@@ -1997,7 +1998,7 @@ static int update_squash_messages(struct repository *r,
                struct commit *head_commit;
                const char *head_message, *body;
 
-               if (get_oid("HEAD", &head))
+               if (repo_get_oid(the_repository, "HEAD", &head))
                        return error(_("need a HEAD to fixup"));
                if (!(head_commit = lookup_commit_reference(r, &head)))
                        return error(_("could not read HEAD"));
@@ -2067,7 +2068,7 @@ static void flush_rewritten_pending(void)
        FILE *out;
 
        if (strbuf_read_file(&buf, rebase_path_rewritten_pending(), (GIT_MAX_HEXSZ + 1) * 2) > 0 &&
-           !get_oid("HEAD", &newoid) &&
+           !repo_get_oid(the_repository, "HEAD", &newoid) &&
            (out = fopen_or_warn(rebase_path_rewritten_list(), "a"))) {
                char *bol = buf.buf, *eol;
 
@@ -2152,7 +2153,7 @@ static int do_pick_commit(struct repository *r,
                if (write_index_as_tree(&head, r->index, r->index_file, 0, NULL))
                        return error(_("your index file is unmerged."));
        } else {
-               unborn = get_oid("HEAD", &head);
+               unborn = repo_get_oid(the_repository, "HEAD", &head);
                /* Do we want to generate a root commit? */
                if (is_pick_or_similar(command) && opts->have_squash_onto &&
                    oideq(&head, &opts->squash_onto)) {
@@ -2606,7 +2607,7 @@ static int parse_insn_line(struct repository *r, struct todo_item *item,
        end_of_object_name = (char *) bol + strcspn(bol, " \t\n");
        saved = *end_of_object_name;
        *end_of_object_name = '\0';
-       status = get_oid(bol, &commit_oid);
+       status = repo_get_oid(the_repository, bol, &commit_oid);
        if (status < 0)
                error(_("could not parse '%s'"), bol); /* return later */
        *end_of_object_name = saved;
@@ -3022,7 +3023,7 @@ static int read_populate_opts(struct replay_opts *opts)
                }
 
                if (read_oneliner(&buf, rebase_path_squash_onto(), 0)) {
-                       if (get_oid_committish(buf.buf, &opts->squash_onto) < 0) {
+                       if (repo_get_oid_committish(the_repository, buf.buf, &opts->squash_onto) < 0) {
                                ret = error(_("unusable squash-onto"));
                                goto done_rebase_i;
                        }
@@ -3223,7 +3224,7 @@ static int rollback_is_safe(void)
        else
                die_errno(_("could not read '%s'"), git_path_abort_safety_file());
 
-       if (get_oid("HEAD", &actual_head))
+       if (repo_get_oid(the_repository, "HEAD", &actual_head))
                oidclr(&actual_head);
 
        return oideq(&actual_head, &expected_head);
@@ -3534,7 +3535,7 @@ static int intend_to_amend(void)
        struct object_id head;
        char *p;
 
-       if (get_oid("HEAD", &head))
+       if (repo_get_oid(the_repository, "HEAD", &head))
                return error(_("cannot read HEAD"));
 
        p = oid_to_hex(&head);
@@ -3700,7 +3701,7 @@ static int do_label(struct repository *r, const char *name, int len)
        if (!transaction) {
                error("%s", err.buf);
                ret = -1;
-       } else if (get_oid("HEAD", &head_oid)) {
+       } else if (repo_get_oid(the_repository, "HEAD", &head_oid)) {
                error(_("could not read HEAD"));
                ret = -1;
        } else if (ref_transaction_update(transaction, ref_name.buf, &head_oid,
@@ -4456,7 +4457,7 @@ void create_autostash(struct repository *r, const char *path)
                if (capture_command(&stash, &buf, GIT_MAX_HEXSZ))
                        die(_("Cannot autostash"));
                strbuf_trim_trailing_newline(&buf);
-               if (get_oid(buf.buf, &oid))
+               if (repo_get_oid(the_repository, buf.buf, &oid))
                        die(_("Unexpected stash response: '%s'"),
                            buf.buf);
                strbuf_reset(&buf);
@@ -4581,7 +4582,7 @@ static int stopped_at_head(struct repository *r)
        struct commit *commit;
        struct commit_message message;
 
-       if (get_oid("HEAD", &head) ||
+       if (repo_get_oid(the_repository, "HEAD", &head) ||
            !(commit = lookup_commit(r, &head)) ||
            parse_commit(commit) || get_message(commit, &message))
                fprintf(stderr, _("Stopped at HEAD\n"));
@@ -4731,7 +4732,7 @@ static int pick_commits(struct repository *r,
                                 * otherwise we do not.
                                 */
                                if (item->command == TODO_REWORD &&
-                                   !get_oid("HEAD", &oid) &&
+                                   !repo_get_oid(the_repository, "HEAD", &oid) &&
                                    (oideq(&item->commit->object.oid, &oid) ||
                                     (opts->have_squash_onto &&
                                      oideq(&opts->squash_onto, &oid))))
@@ -4820,7 +4821,7 @@ static int pick_commits(struct repository *r,
                        struct object_id head, orig;
                        int res;
 
-                       if (get_oid("HEAD", &head)) {
+                       if (repo_get_oid(the_repository, "HEAD", &head)) {
                                res = error(_("cannot read HEAD"));
 cleanup_head_ref:
                                strbuf_release(&head_ref);
@@ -4867,8 +4868,8 @@ cleanup_head_ref:
                        log_tree_opt.disable_stdin = 1;
 
                        if (read_oneliner(&buf, rebase_path_orig_head(), 0) &&
-                           !get_oid(buf.buf, &orig) &&
-                           !get_oid("HEAD", &head)) {
+                           !repo_get_oid(the_repository, buf.buf, &orig) &&
+                           !repo_get_oid(the_repository, "HEAD", &head)) {
                                diff_tree_oid(&orig, &head, "",
                                              &log_tree_opt.diffopt);
                                log_tree_diff_flush(&log_tree_opt);
@@ -4960,7 +4961,7 @@ static int commit_staged_changes(struct repository *r,
                struct strbuf rev = STRBUF_INIT;
                struct object_id head, to_amend;
 
-               if (get_oid("HEAD", &head))
+               if (repo_get_oid(the_repository, "HEAD", &head))
                        return error(_("cannot amend non-existing commit"));
                if (!read_oneliner(&rev, rebase_path_amend(), 0))
                        return error(_("invalid file: '%s'"), rebase_path_amend());
@@ -5185,7 +5186,7 @@ int sequencer_pick_revisions(struct repository *r,
                if (!strlen(name))
                        continue;
 
-               if (!get_oid(name, &oid)) {
+               if (!repo_get_oid(the_repository, name, &oid)) {
                        if (!lookup_commit_reference_gently(r, &oid, 1)) {
                                enum object_type type = oid_object_info(r,
                                                                        &oid,
@@ -5228,7 +5229,7 @@ int sequencer_pick_revisions(struct repository *r,
        if (walk_revs_populate_todo(&todo_list, opts) ||
                        create_seq_dir(r) < 0)
                return -1;
-       if (get_oid("HEAD", &oid) && (opts->action == REPLAY_REVERT))
+       if (repo_get_oid(the_repository, "HEAD", &oid) && (opts->action == REPLAY_REVERT))
                return error(_("can't revert as initial commit"));
        if (save_head(oid_to_hex(&oid)))
                return -1;
@@ -5360,7 +5361,8 @@ static const char *label_oid(struct object_id *oid, const char *label,
                strbuf_grow(&state->buf, GIT_MAX_HEXSZ);
                label = p = state->buf.buf;
 
-               find_unique_abbrev_r(p, oid, default_abbrev);
+               repo_find_unique_abbrev_r(the_repository, p, oid,
+                                         default_abbrev);
 
                /*
                 * We may need to extend the abbreviated hash so that there is
@@ -6093,7 +6095,8 @@ int complete_action(struct repository *r, struct replay_opts *opts, unsigned fla
        struct object_id oid = onto->object.oid;
        int res;
 
-       find_unique_abbrev_r(shortonto, &oid, DEFAULT_ABBREV);
+       repo_find_unique_abbrev_r(the_repository, shortonto, &oid,
+                                 DEFAULT_ABBREV);
 
        if (buf->len == 0) {
                struct todo_item *item = append_new_todo(todo_list);
@@ -6369,8 +6372,8 @@ int sequencer_determine_whence(struct repository *r, enum commit_whence *whence)
                if (file_exists(git_path_seq_dir()))
                        *whence = FROM_CHERRY_PICK_MULTI;
                if (file_exists(rebase_path()) &&
-                   !get_oid("REBASE_HEAD", &rebase_head) &&
-                   !get_oid("CHERRY_PICK_HEAD", &cherry_pick_head) &&
+                   !repo_get_oid(the_repository, "REBASE_HEAD", &rebase_head) &&
+                   !repo_get_oid(the_repository, "CHERRY_PICK_HEAD", &cherry_pick_head) &&
                    oideq(&rebase_head, &cherry_pick_head))
                        *whence = FROM_REBASE_PICK;
                else
index 4dc61b3a78a2916d737edf613af0f9c0e03d39c8..336732ed785dc99292ac29457f6fce8922454586 100644 (file)
@@ -535,7 +535,7 @@ static int gitmodule_oid_from_commit(const struct object_id *treeish_name,
        }
 
        strbuf_addf(rev, "%s:.gitmodules", oid_to_hex(treeish_name));
-       if (get_oid(rev->buf, gitmodules_oid) >= 0)
+       if (repo_get_oid(the_repository, rev->buf, gitmodules_oid) >= 0)
                ret = 1;
 
        return ret;
index 3a0dfc417c05b627a5100f518768a1b32ee22339..5936553464a04821ee4d2aceaa0e04c359069e4e 100644 (file)
@@ -65,7 +65,7 @@ int is_writing_gitmodules_ok(void)
 {
        struct object_id oid;
        return file_exists(GITMODULES_FILE) ||
-               (get_oid(GITMODULES_INDEX, &oid) < 0 && get_oid(GITMODULES_HEAD, &oid) < 0);
+               (repo_get_oid(the_repository, GITMODULES_INDEX, &oid) < 0 && repo_get_oid(the_repository, GITMODULES_HEAD, &oid) < 0);
 }
 
 /*
@@ -1625,7 +1625,7 @@ get_fetch_task_from_changed(struct submodule_parallel_fetch *spf,
                if (!task->repo) {
                        strbuf_addf(err, _("Could not access submodule '%s' at commit %s\n"),
                                    cs_data->path,
-                                   find_unique_abbrev(cs_data->super_oid, DEFAULT_ABBREV));
+                                   repo_find_unique_abbrev(the_repository, cs_data->super_oid, DEFAULT_ABBREV));
 
                        fetch_task_release(task);
                        free(task);
@@ -1636,8 +1636,8 @@ get_fetch_task_from_changed(struct submodule_parallel_fetch *spf,
                        strbuf_addf(err,
                                    _("Fetching submodule %s%s at commit %s\n"),
                                    spf->prefix, task->sub->path,
-                                   find_unique_abbrev(cs_data->super_oid,
-                                                      DEFAULT_ABBREV));
+                                   repo_find_unique_abbrev(the_repository, cs_data->super_oid,
+                                                           DEFAULT_ABBREV));
 
                spf->changed_count++;
                /*
index efc82dd80c5b5711ecb4947b3c082433845e1e50..5d1284328d075f0b6c2ea75de53350ccd51ca31c 100644 (file)
@@ -25,7 +25,8 @@
 
 static const char *short_commit_name(struct commit *commit)
 {
-       return find_unique_abbrev(&commit->object.oid, DEFAULT_ABBREV);
+       return repo_find_unique_abbrev(the_repository, &commit->object.oid,
+                                      DEFAULT_ABBREV);
 }
 
 static struct commit *peel_committish(const char *name)
@@ -33,10 +34,11 @@ static struct commit *peel_committish(const char *name)
        struct object *obj;
        struct object_id oid;
 
-       if (get_oid(name, &oid))
+       if (repo_get_oid(the_repository, name, &oid))
                return NULL;
        obj = parse_object(the_repository, &oid);
-       return (struct commit *)peel_to_type(name, 0, obj, OBJ_COMMIT);
+       return (struct commit *)repo_peel_to_type(the_repository, name, 0, obj,
+                                                 OBJ_COMMIT);
 }
 
 static char *get_author(const char *message)
@@ -119,7 +121,7 @@ int cmd__fast_rebase(int argc, const char **argv)
        strbuf_addf(&branch_name, "refs/heads/%s", argv[4]);
 
        /* Sanity check */
-       if (get_oid("HEAD", &head))
+       if (repo_get_oid(the_repository, "HEAD", &head))
                die(_("Cannot read HEAD"));
        assert(oideq(&onto->object.oid, &head));
 
index 4079fdee06776c8179fbc15283141f3890ff013e..daadf3827aa3492868cd168901c64d66707b2006 100644 (file)
@@ -9,9 +9,9 @@ int cmd__match_trees(int ac, const char **av)
 
        setup_git_directory();
 
-       if (get_oid(av[1], &hash1))
+       if (repo_get_oid(the_repository, av[1], &hash1))
                die("cannot parse %s as an object name", av[1]);
-       if (get_oid(av[2], &hash2))
+       if (repo_get_oid(the_repository, av[2], &hash2))
                die("cannot parse %s as an object name", av[2]);
        one = parse_tree_indirect(&hash1);
        if (!one)
index 0acf99931ee176982d61078dc0e2d882377c05fd..7b194edde2b052f6fec56bda69825242f051b9b4 100644 (file)
@@ -49,7 +49,7 @@ int cmd__oidmap(int argc, const char **argv)
 
                if (!strcmp("put", cmd) && p1 && p2) {
 
-                       if (get_oid(p1, &oid)) {
+                       if (repo_get_oid(the_repository, p1, &oid)) {
                                printf("Unknown oid: %s\n", p1);
                                continue;
                        }
@@ -67,7 +67,7 @@ int cmd__oidmap(int argc, const char **argv)
 
                } else if (!strcmp("get", cmd) && p1) {
 
-                       if (get_oid(p1, &oid)) {
+                       if (repo_get_oid(the_repository, p1, &oid)) {
                                printf("Unknown oid: %s\n", p1);
                                continue;
                        }
@@ -80,7 +80,7 @@ int cmd__oidmap(int argc, const char **argv)
 
                } else if (!strcmp("remove", cmd) && p1) {
 
-                       if (get_oid(p1, &oid)) {
+                       if (repo_get_oid(the_repository, p1, &oid)) {
                                printf("Unknown oid: %s\n", p1);
                                continue;
                        }
index 2f65c7f6a55bc146ea69ea9ef85d45a1f6172ac3..00f0f29a6a61daae3ab0961aea594a22dc0b9406 100644 (file)
@@ -57,7 +57,7 @@ int cmd__reach(int ac, const char **av)
                if (buf.len < 3)
                        continue;
 
-               if (get_oid_committish(buf.buf + 2, &oid))
+               if (repo_get_oid_committish(the_repository, buf.buf + 2, &oid))
                        die("failed to resolve %s", buf.buf + 2);
 
                orig = parse_object(r, &oid);
index 22a41c409263c077843598e4cc51881a52b0ce30..91c82d4159db9d1ebd304dafdd6c0c2a9c4bc047 100644 (file)
@@ -42,7 +42,7 @@ int cmd__submodule_config(int argc, const char **argv)
 
                if (commit[0] == '\0')
                        oidclr(&commit_oid);
-               else if (get_oid(commit, &commit_oid) < 0)
+               else if (repo_get_oid(the_repository, commit, &commit_oid) < 0)
                        die_usage(argc, argv, "Commit not found.");
 
                if (lookup_name) {
diff --git a/tag.c b/tag.c
index dfbcd7fcc244ac2500d41655afac3136758bb331..dfc900e62e0ecead865488a5008468867d83f1b8 100644 (file)
--- a/tag.c
+++ b/tag.c
@@ -51,7 +51,7 @@ int gpg_verify_tag(const struct object_id *oid, const char *name_to_report,
                return error("%s: cannot verify a non-tag object of type %s.",
                                name_to_report ?
                                name_to_report :
-                               find_unique_abbrev(oid, DEFAULT_ABBREV),
+                               repo_find_unique_abbrev(the_repository, oid, DEFAULT_ABBREV),
                                type_name(type));
 
        buf = read_object_file(oid, &type, &size);
@@ -59,7 +59,7 @@ int gpg_verify_tag(const struct object_id *oid, const char *name_to_report,
                return error("%s: unable to read file.",
                                name_to_report ?
                                name_to_report :
-                               find_unique_abbrev(oid, DEFAULT_ABBREV));
+                               repo_find_unique_abbrev(the_repository, oid, DEFAULT_ABBREV));
 
        ret = run_gpg_verify(buf, size, flags);
 
index 3ea7c2bb5ad8c462ae0f54c9466af210bc27d0c2..2a1b4497caa65410fb32a797857d6ca514305832 100644 (file)
@@ -1081,7 +1081,7 @@ static int push_refs_with_export(struct transport *transport,
                struct object_id oid;
 
                private = apply_refspecs(&data->rs, ref->name);
-               if (private && !get_oid(private, &oid)) {
+               if (private && !repo_get_oid(the_repository, private, &oid)) {
                        strbuf_addf(&buf, "^%s", private);
                        string_list_append_nodup(&revlist_args,
                                                 strbuf_detach(&buf, NULL));
index 77a61a9d7bb06a5cfc7992c6fc4f9f3aa8a8ada5..7488622e77db7aff7408377c01f569dc6998edc9 100644 (file)
@@ -776,7 +776,8 @@ static int print_one_push_status(struct ref *ref, const char *dest, int count,
 static int measure_abbrev(const struct object_id *oid, int sofar)
 {
        char hex[GIT_MAX_HEXSZ + 1];
-       int w = find_unique_abbrev_r(hex, oid, DEFAULT_ABBREV);
+       int w = repo_find_unique_abbrev_r(the_repository, hex, oid,
+                                         DEFAULT_ABBREV);
 
        return (w < sofar) ? sofar : w;
 }
index 3162241a570cb60393607f06a8a12963b71afb78..c55c51b19244d728f872e3f49949928f1eba23dd 100644 (file)
@@ -1337,7 +1337,7 @@ static void abbrev_oid_in_line(struct strbuf *line)
                 * it after abbreviation.
                 */
                strbuf_trim(split[1]);
-               if (!get_oid(split[1]->buf, &oid)) {
+               if (!repo_get_oid(the_repository, split[1]->buf, &oid)) {
                        strbuf_reset(split[1]);
                        strbuf_add_unique_abbrev(split[1], &oid,
                                                 DEFAULT_ABBREV);
@@ -1503,8 +1503,8 @@ static void show_cherry_pick_in_progress(struct wt_status *s,
        else
                status_printf_ln(s, color,
                        _("You are currently cherry-picking commit %s."),
-                       find_unique_abbrev(&s->state.cherry_pick_head_oid,
-                                          DEFAULT_ABBREV));
+                       repo_find_unique_abbrev(the_repository, &s->state.cherry_pick_head_oid,
+                                               DEFAULT_ABBREV));
 
        if (s->hints) {
                if (has_unmerged(s))
@@ -1533,8 +1533,8 @@ static void show_revert_in_progress(struct wt_status *s,
        else
                status_printf_ln(s, color,
                        _("You are currently reverting commit %s."),
-                       find_unique_abbrev(&s->state.revert_head_oid,
-                                          DEFAULT_ABBREV));
+                       repo_find_unique_abbrev(the_repository, &s->state.revert_head_oid,
+                                               DEFAULT_ABBREV));
        if (s->hints) {
                if (has_unmerged(s))
                        status_printf_ln(s, color,
@@ -1676,9 +1676,9 @@ static void wt_status_get_detached_from(struct repository *r,
                state->detached_from = xstrdup(from);
        } else
                state->detached_from =
-                       xstrdup(find_unique_abbrev(&cb.noid, DEFAULT_ABBREV));
+                       xstrdup(repo_find_unique_abbrev(the_repository, &cb.noid, DEFAULT_ABBREV));
        oidcpy(&state->detached_oid, &cb.noid);
-       state->detached_at = !get_oid("HEAD", &oid) &&
+       state->detached_at = !repo_get_oid(the_repository, "HEAD", &oid) &&
                             oideq(&oid, &state->detached_oid);
 
        free(ref);
@@ -1769,13 +1769,13 @@ void wt_status_get_state(struct repository *r,
        } else if (wt_status_check_rebase(NULL, state)) {
                ;               /* all set */
        } else if (refs_ref_exists(get_main_ref_store(r), "CHERRY_PICK_HEAD") &&
-                  !get_oid("CHERRY_PICK_HEAD", &oid)) {
+                  !repo_get_oid(the_repository, "CHERRY_PICK_HEAD", &oid)) {
                state->cherry_pick_in_progress = 1;
                oidcpy(&state->cherry_pick_head_oid, &oid);
        }
        wt_status_check_bisect(NULL, state);
        if (refs_ref_exists(get_main_ref_store(r), "REVERT_HEAD") &&
-           !get_oid("REVERT_HEAD", &oid)) {
+           !repo_get_oid(the_repository, "REVERT_HEAD", &oid)) {
                state->revert_in_progress = 1;
                oidcpy(&state->revert_head_oid, &oid);
        }