]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
coverity CID 398388: useless <0 check on unsigned value
authorPeter van Dijk <peter.van.dijk@powerdns.com>
Tue, 15 Aug 2023 08:28:46 +0000 (10:28 +0200)
committerPeter van Dijk <peter.van.dijk@powerdns.com>
Tue, 15 Aug 2023 08:28:46 +0000 (10:28 +0200)
pdns/dnsdistdist/dnsdist-discovery.cc

index ead9daf55f1f85e6cb64280792223ddfdb37def4..2d3c66e722cd11c1dd10d543b005020fcbef8c18 100644 (file)
@@ -275,7 +275,7 @@ bool ServiceDiscovery::getDiscoveredConfig(const UpgradeableBackend& upgradeable
     const struct timeval remainingTime = {.tv_sec = backend->d_config.tcpRecvTimeout, .tv_usec = 0};
     uint16_t responseSize = 0;
     auto got = readn2WithTimeout(sock.getHandle(), &responseSize, sizeof(responseSize), remainingTime);
-    if (got < 0 || static_cast<size_t>(got) != sizeof(responseSize)) {
+    if (static_cast<size_t>(got) != sizeof(responseSize)) {
       if (g_verbose) {
         warnlog("Error while waiting for the ADD upgrade response size from backend %s: %d", addr.toStringWithPort(), got);
       }