]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
virtio_net: Remove u64_stats_update_begin()/end() for stats fetch
authorLi RongQing <lirongqing@baidu.com>
Fri, 21 Jun 2024 09:45:52 +0000 (17:45 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Jun 2024 23:42:26 +0000 (16:42 -0700)
This place is fetching the stats, u64_stats_update_begin()/end()
should not be used, and the fetcher of stats is in the same context
as the updater of the stats, so don't need any protection

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Link: https://lore.kernel.org/20240621094552.53469-1-lirongqing@baidu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/virtio_net.c

index b1f8b720733e559a8bb87e40bfda6b9407544485..f212977513107137bcd6219b184e9124b4e9c649 100644 (file)
@@ -2382,12 +2382,13 @@ static void virtnet_rx_dim_update(struct virtnet_info *vi, struct receive_queue
        if (!rq->packets_in_napi)
                return;
 
-       u64_stats_update_begin(&rq->stats.syncp);
+       /* Don't need protection when fetching stats, since fetcher and
+        * updater of the stats are in same context
+        */
        dim_update_sample(rq->calls,
                          u64_stats_read(&rq->stats.packets),
                          u64_stats_read(&rq->stats.bytes),
                          &cur_sample);
-       u64_stats_update_end(&rq->stats.syncp);
 
        net_dim(&rq->dim, cur_sample);
        rq->packets_in_napi = 0;