pg_restore: Fix memory and file descriptor leak with directory format

found by Coverity

diff --git a/src/bin/pg_dump/pg_backup_directory.c b/src/bin/pg_dump/pg_backup_directory.c
index df95411cfd976a191b4c8eed1702ddc2ce771fd9..4b59516fe46d425e5c1fa8158feb8f05e30f73b0 100644 (file)
--- a/src/bin/pg_dump/pg_backup_directory.c
+++ b/src/bin/pg_dump/pg_backup_directory.c
@@ -356,6 +356,9 @@ _PrintFileData(ArchiveHandle *AH, char *filename, RestoreOptions *ropt)
                ahwrite(buf, 1, cnt, AH);
 
        free(buf);
+       if (cfclose(cfp) != 0)
+               die_horribly(AH, modulename, "could not close data file: %s\n",
+                                        strerror(errno));
 }
 
 /*