trans-decl.c (generate_local_decl): Emit warning on unused parameter on "-Wall -Wextr...

gcc/fortran:
2007-08-01  Daniel Franke  <franke.daniel@gmail.com>

	* trans-decl.c (generate_local_decl): Emit warning on unused parameter
	on "-Wall -Wextra" or "-Wunused-parameter" but not on "-Wall", changed
	messages that start with lower case to upper case.
	* invoke.texi (-Wparameter-unused): Document differences between gcc
	and gfortran regarding this option.

gcc/testsuite:
2007-08-01  Daniel Franke  <franke.daniel@gmail.com>

	* gfortran.dg/parameter_unused.f90: Adjusted dg-options and
	error message text.

From-SVN: r127126

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 81ba111c86308c0e6a21b45ebdb14344b5f152a6..5db8979973b0aabd966b8371bb44942c38e2f694 100644 (file)
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,11 @@
+2007-08-01  Daniel Franke  <franke.daniel@gmail.com>
+
+       * trans-decl.c (generate_local_decl): Emit warning on unused parameter
+       on "-Wall -Wextra" or "-Wunused-parameter" but not on "-Wall", changed
+       messages that start with lower case to upper case.
+       * invoke.texi (-Wparameter-unused): Document differences between gcc
+       and gfortran regarding this option.
+
 2007-08-01  Daniel Franke  <franke.daniel@gmail.com>
 
        PR fortran/32945

diff --git a/gcc/fortran/invoke.texi b/gcc/fortran/invoke.texi
index 3064633cd50e675b48271fead70d390c497aa309..e52bff85dbf4d492220e22e5ceac6f9dfa023672 100644 (file)
--- a/gcc/fortran/invoke.texi
+++ b/gcc/fortran/invoke.texi
@@ -130,7 +130,7 @@ and warnings}.
 -fsyntax-only  -pedantic  -pedantic-errors @gol
 -Wall  -Waliasing  -Wampersand  -Wcharacter-truncation  -Wconversion @gol
 -Wimplicit-interface  -Wline-truncation  -Wnonstd-intrinsics  -Wsurprising @gol
--Wno-tabs  -Wunderflow}
+-Wno-tabs  -Wunderflow -Wunused-parameter}
 
 @item Debugging Options
 @xref{Debugging Options,,Options for debugging your program or GNU Fortran}.
@@ -488,6 +488,16 @@ for @option{-pedantic}, @option{-std=f95}, @option{-std=f2003}, and
 Produce a warning when numerical constant expressions are
 encountered, which yield an UNDERFLOW during compilation.
 
+@item -Wunused-parameter
+@opindex @code{Wunused-parameter}
+@cindex warnings, unused parameter
+@cindex unused parameter
+Contrary to @command{gcc}'s meaning of @option{-Wunused-parameter},
+@command{gfortran}'s implementation of this option does not warn
+about unused dummy arguments, but about unused @code{PARAMETER} values.
+@option{-Wunused-parameter} is not included in @option{-Wall} but is
+implied by @option{-Wall -Wextra}.
+
 @item -Werror
 @opindex @code{Werror}
 @cindex warnings, to errors

diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c
index 2e144735cf1ac7ba054bb81776e284141776f865..97d6e5c72bfcf9b591ed416499ab66cdeb66c909 100644 (file)
--- a/gcc/fortran/trans-decl.c
+++ b/gcc/fortran/trans-decl.c
@@ -2998,17 +2998,17 @@ generate_local_decl (gfc_symbol * sym)
       else if (warn_unused_variable
               && sym->attr.dummy
               && sym->attr.intent == INTENT_OUT)
-       gfc_warning ("dummy argument '%s' at %L was declared INTENT(OUT) but was not set",
+       gfc_warning ("Dummy argument '%s' at %L was declared INTENT(OUT) but was not set",
                     sym->name, &sym->declared_at);
       /* Specific warning for unused dummy arguments. */
       else if (warn_unused_variable && sym->attr.dummy)
-       gfc_warning ("unused dummy argument '%s' at %L", sym->name,
+       gfc_warning ("Unused dummy argument '%s' at %L", sym->name,
                     &sym->declared_at);
       /* Warn for unused variables, but not if they're inside a common
         block or are use-associated.  */
       else if (warn_unused_variable
               && !(sym->attr.in_common || sym->attr.use_assoc))
-       gfc_warning ("unused variable '%s' declared at %L", sym->name,
+       gfc_warning ("Unused variable '%s' declared at %L", sym->name,
                     &sym->declared_at);
       /* For variable length CHARACTER parameters, the PARM_DECL already
         references the length variable, so force gfc_get_symbol_decl
@@ -3031,10 +3031,10 @@ generate_local_decl (gfc_symbol * sym)
     }
   else if (sym->attr.flavor == FL_PARAMETER)
     {
-      if (warn_unused_variable 
+      if (warn_unused_parameter
            && !sym->attr.referenced
            && !sym->attr.use_assoc)
-       gfc_warning ("unused parameter '%s' declared at %L", sym->name,
+       gfc_warning ("Unused parameter '%s' declared at %L", sym->name,
                     &sym->declared_at);
     }
 

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 81e92962e07bbc3c3549b964e7c388231b15dcfe..641db860de554902437441f27439def301d010ac 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2007-08-01  Daniel Franke  <franke.daniel@gmail.com>
+
+       * gfortran.dg/parameter_unused.f90: Adjusted dg-options and
+       error message text.
+
 2007-08-01  Daniel Franke  <franke.daniel@gmail.com>
 
        PR fortran/32945

diff --git a/gcc/testsuite/gfortran.dg/parameter_unused.f90 b/gcc/testsuite/gfortran.dg/parameter_unused.f90
index 7496169361a3c1447ad054812fcd551d7c60df82..86d50851a133ac982e6dc3fb7fa345096b512202 100644 (file)
--- a/gcc/testsuite/gfortran.dg/parameter_unused.f90
+++ b/gcc/testsuite/gfortran.dg/parameter_unused.f90
@@ -1,9 +1,9 @@
 ! { dg-do compile }
-! { dg-options "-Wunused" }
+! { dg-options "-Wunused-parameter" }
 !
 ! PR fortran/31129 - No warning on unused parameters
 !
 program fred
-integer,parameter :: j = 9     ! { dg-warning "unused parameter" }
+integer,parameter :: j = 9     ! { dg-warning "Unused parameter" }
 end