arm64: dts: mediatek: cherry: Specify pull resistance for RSEL GPIOs

GPIOs 34 and 35 on MT8195 are of type MTK_PULL_PU_PD_RSEL_TYPE, meaning
not only can they be configured as pull-up or pull-down, but the pull
resistance can also be configured.

The current bias setting however doesn't specify a resistance value,
resulting on the following errors:

mt8195-pinctrl 10005000.pinctrl: Not support rsel value 1 Ohm for pin = 34 (GPIO34)
mt8195-pinctrl 10005000.pinctrl: Not support rsel value 1 Ohm for pin = 35 (GPIO35)

Specify the pull resistance for those GPIOs to fix the errors.

Fixes: 5bf7dabe40f2 ("arm64: dts: mediatek: cherry: Document gpios and add default pin config")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://lore.kernel.org/r/20240531-tomato-rsel-gpio34-35-fix-v1-1-64ab2545f182@collabora.com
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-dojo-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-dojo-r1.dts
index 88123842c818d3109b8fad562aa226106f5b9be3..49664de99b882700dd8566658b21fafc3cc8c2ad 100644 (file)
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-dojo-r1.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-dojo-r1.dts
@@ -82,12 +82,17 @@
        pins-low-power-hdmi-disable {
                pinmux = <PINMUX_GPIO31__FUNC_GPIO31>,
                         <PINMUX_GPIO32__FUNC_GPIO32>,
-                        <PINMUX_GPIO33__FUNC_GPIO33>,
-                        <PINMUX_GPIO34__FUNC_GPIO34>,
-                        <PINMUX_GPIO35__FUNC_GPIO35>;
+                        <PINMUX_GPIO33__FUNC_GPIO33>;
                input-enable;
                bias-pull-down;
        };
+
+       pins-low-power-hdmi-rsel-disable {
+               pinmux = <PINMUX_GPIO34__FUNC_GPIO34>,
+                        <PINMUX_GPIO35__FUNC_GPIO35>;
+               input-enable;
+               bias-pull-down = <75000>;
+       };
 };
 
 &sound {

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
index 2fe20e0dad836d8b191d3f1e8b997d4e864cde19..2d6522c144b751736e5a5e57044f75e9e3ddc2d9 100644 (file)
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
@@ -19,13 +19,18 @@
        pins-low-power-hdmi-disable {
                pinmux = <PINMUX_GPIO31__FUNC_GPIO31>,
                         <PINMUX_GPIO32__FUNC_GPIO32>,
-                        <PINMUX_GPIO33__FUNC_GPIO33>,
-                        <PINMUX_GPIO34__FUNC_GPIO34>,
-                        <PINMUX_GPIO35__FUNC_GPIO35>;
+                        <PINMUX_GPIO33__FUNC_GPIO33>;
                input-enable;
                bias-pull-down;
        };
 
+       pins-low-power-hdmi-rsel-disable {
+               pinmux = <PINMUX_GPIO34__FUNC_GPIO34>,
+                        <PINMUX_GPIO35__FUNC_GPIO35>;
+               input-enable;
+               bias-pull-down = <75000>;
+       };
+
        pins-low-power-pcie0-disable {
                pinmux = <PINMUX_GPIO19__FUNC_GPIO19>,
                         <PINMUX_GPIO20__FUNC_GPIO20>,

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
index dd294ca98194ccfb2853f8f4a0b2e175618983b6..9049d362a5e015e70626071e70bcdaf17afc2108 100644 (file)
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
@@ -20,13 +20,18 @@
        pins-low-power-hdmi-disable {
                pinmux = <PINMUX_GPIO31__FUNC_GPIO31>,
                         <PINMUX_GPIO32__FUNC_GPIO32>,
-                        <PINMUX_GPIO33__FUNC_GPIO33>,
-                        <PINMUX_GPIO34__FUNC_GPIO34>,
-                        <PINMUX_GPIO35__FUNC_GPIO35>;
+                        <PINMUX_GPIO33__FUNC_GPIO33>;
                input-enable;
                bias-pull-down;
        };
 
+       pins-low-power-hdmi-rsel-disable {
+               pinmux = <PINMUX_GPIO34__FUNC_GPIO34>,
+                        <PINMUX_GPIO35__FUNC_GPIO35>;
+               input-enable;
+               bias-pull-down = <75000>;
+       };
+
        pins-low-power-pcie0-disable {
                pinmux = <PINMUX_GPIO19__FUNC_GPIO19>,
                         <PINMUX_GPIO20__FUNC_GPIO20>,