]> git.ipfire.org Git - people/ms/linux.git/commitdiff
pinctrl: stm32: return proper error code in pin_config_set
authorAlexandre Torgue <alexandre.torgue@st.com>
Mon, 15 Jun 2020 12:59:50 +0000 (14:59 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 20 Jun 2020 21:08:00 +0000 (23:08 +0200)
".pin_config_set" or ".pin_config_group_set" can be called with a
configuration not supported (i.e. PIN_CONFIG_PERSIST_STATE). In this case,
it is more suitable to return -ENOTSUPP instead of -EINVAL.

Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
Link: https://lore.kernel.org/r/20200615125951.28008-2-alexandre.torgue@st.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/stm32/pinctrl-stm32.c

index 162535e7c94dd3c508bc68c45bcb3614a67c50ca..cdf6b01d1956f2ebb52b81b05581a44eec6f01bc 100644 (file)
@@ -1085,7 +1085,7 @@ static int stm32_pconf_parse_conf(struct pinctrl_dev *pctldev,
                ret = stm32_pmx_gpio_set_direction(pctldev, range, pin, false);
                break;
        default:
-               ret = -EINVAL;
+               ret = -ENOTSUPP;
        }
 
        return ret;