Remove that fix, analyzer is for debug with assertions.

- Fix clang analyzer for optimize compile analysis.

git-svn-id: file:///svn/unbound/trunk@4929 be551aaa-1e26-0410-a405-d3ace91eadb9

diff --git a/doc/Changelog b/doc/Changelog
index b7d3c565026c0f7bde7cf0fb762f43fe6ebb5ed4..1319cb28698fa67cbb67ff2c56465d546b0a88be 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,7 +1,6 @@
 2 October 2018: Wouter
        - updated contrib/fastrpz.patch to apply for this version
        - dnscrypt.c removed sizeof to get array bounds.
-       - Fix clang analyzer for optimize compile analysis.
        - Fix testlock code to set noreturn on error routine.
        - Remove unused variable from contrib fastrpz/rpz.c and
          remove unused diagnostic pragmas that themselves generate warnings

diff --git a/services/authzone.c b/services/authzone.c
index 4d0dd1b5ae9cadba374382afb8ae0e0e426a2510..1f29c3ae90800cdb260865c888d8252911b00799 100644 (file)
--- a/services/authzone.c
+++ b/services/authzone.c
@@ -2828,7 +2828,7 @@ az_generate_any_answer(struct auth_zone* z, struct regional* region,
                if(!msg_add_rrset_an(z, region, msg, node, rrset)) return 0;
                added++;
        }
-       if(added == 0 && node->rrsets) {
+       if(added == 0 && node && node->rrsets) {
                if(!msg_add_rrset_an(z, region, msg, node,
                        node->rrsets)) return 0;
        }

diff --git a/util/log.h b/util/log.h
index f171dabefcf26fd0a66decf810b356d14284cfa0..f73c0754d657f0661d0afc3922db9f82c01e3277 100644 (file)
--- a/util/log.h
+++ b/util/log.h
@@ -201,13 +201,8 @@ void log_vmsg(int pri, const char* type, const char* format, va_list args);
        } while(0);
 #endif
 #else
-#ifdef __clang_analyzer__
-/* tell clang analyzer that the code path with !x is not there */
-#define log_assert(x) if(!(x)) fatal_exit("error")
-#else
 #  define log_assert(x) /*nothing*/
 #endif
-#endif
 
 #ifdef USE_WINSOCK
 /**