]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net/mlx5: Warn when write combining is not supported
authorMaor Gottlieb <maorg@nvidia.com>
Tue, 8 Jul 2025 21:16:26 +0000 (00:16 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Jul 2025 02:47:43 +0000 (19:47 -0700)
Warn if write combining is not supported, as it can impact latency.
Add the warning message to be printed only when the driver actually
run the test and detect unsupported state, rather than when
inheriting parent's result for SFs.

Signed-off-by: Maor Gottlieb <maorg@nvidia.com>
Reviewed-by: Michael Guralnik <michaelgur@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/1752009387-13300-5-git-send-email-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/wc.c

index 740b719e7072df683d4476640e5814a196a56a0d..2f0316616fa40b3a13fdf9d3d5817d99df454c79 100644 (file)
@@ -378,6 +378,9 @@ err_create_cq:
        mlx5_free_bfreg(mdev, &sq->bfreg);
 err_alloc_bfreg:
        kfree(sq);
+
+       if (mdev->wc_state == MLX5_WC_STATE_UNSUPPORTED)
+               mlx5_core_warn(mdev, "Write combining is not supported\n");
 }
 
 bool mlx5_wc_support_get(struct mlx5_core_dev *mdev)