]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: fixed_phy: remove not needed initialization of phy_device members
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 19 Nov 2025 06:55:47 +0000 (07:55 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 21 Nov 2025 02:18:54 +0000 (18:18 -0800)
All these members are populated by the phylib state machine once the
PHY has been started, based on the fixed autoneg results.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/bc666a53-5469-4e9c-85a1-dd285aadfe4f@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/fixed_phy.c

index 1ea67119f08f96b55fc18607c2138a005a1dcbc7..50684271f81a9c22121f5d87e5fa5b0e02edae48 100644 (file)
@@ -173,13 +173,6 @@ struct phy_device *fixed_phy_register(const struct fixed_phy_status *status,
                return ERR_PTR(-EINVAL);
        }
 
-       /* propagate the fixed link values to struct phy_device */
-       phy->link = 1;
-       phy->speed = status->speed;
-       phy->duplex = status->duplex;
-       phy->pause = status->pause;
-       phy->asym_pause = status->asym_pause;
-
        of_node_get(np);
        phy->mdio.dev.of_node = np;
        phy->is_pseudo_fixed_link = true;