]> git.ipfire.org Git - thirdparty/babel.git/commitdiff
Mark PyPy test failing in CI as xfail (#1197)
authorAarni Koskela <akx@iki.fi>
Wed, 5 Mar 2025 07:18:05 +0000 (09:18 +0200)
committerGitHub <noreply@github.com>
Wed, 5 Mar 2025 07:18:05 +0000 (09:18 +0200)
.github/workflows/ci.yml
tests/messages/test_setuptools_frontend.py

index 2fb4b37145d8b69bfd4eeba977f8a0bd598405a5..a5ed97f22248aeb92a27253d8d2763bdcd6d72e9 100644 (file)
@@ -61,7 +61,6 @@ jobs:
       env:
         COVERAGE_XML_PATH: ${{ runner.temp }}
         BABEL_TOX_EXTRA_DEPS: pytest-github-actions-annotate-failures
-        LC_ALL: C  # Python 3.10.16[pypy-7.3.19-final] in GHA failed with "unsupported locale setting"
     - uses: codecov/codecov-action@v5
       with:
         directory: ${{ runner.temp }}
index a623efd29985cc2b6b1b3d8aeecf7117943e40fa..5c3f4433bcb25384e0eee01bf4a4540cb63d9ce8 100644 (file)
@@ -45,6 +45,13 @@ def test_extract_distutils_keyword_arg_388(kwarg, expected):
     assert set(cmdinst.add_comments) == {"Bar", "Foo"}
 
 
+@pytest.mark.xfail(
+    # Python 3.10.16[pypy-7.3.19-final] in GHA fails with "unsupported locale setting"
+    # in the subprocesses this test spawns.  Hard to say why because it doesn't do that
+    # locally.
+    condition=(sys.implementation.name == "pypy" and "BABEL_TOX_INI_DIR" in os.environ),
+    reason="Test will likely fail with 'unsupported locale setting' in subprocesses; see comment",
+)
 def test_setuptools_commands(tmp_path, monkeypatch):
     """
     Smoke-tests all of the setuptools versions of the commands in turn.