]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
can: rockchip_canfd: rkcanfd_chip_fifo_setup(): remove duplicated setup of RX FIFO
authorRobin van der Gracht <robin@protonic.nl>
Mon, 27 Jan 2025 12:16:44 +0000 (13:16 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 19 Feb 2025 11:17:40 +0000 (12:17 +0100)
The rockchip_canfd driver doesn't make use of the TXE FIFO.

Although the comment states that the TXE FIFO is setup, it's actually
a setup of the RX FIFO. The regular setup of the RX FIFO follows.

Remove the duplicated setup of the RX FIFO.

Fixes: ff60bfbaf67f ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
Signed-off-by: Robin van der Gracht <robin@protonic.nl>
Link: https://patch.msgid.link/20250219-rk3568-canfd-v1-1-453869358c72@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/rockchip/rockchip_canfd-core.c

index d9a937ba126c3cfd2453b511f117272c6fd960da..46201c126703ced892469aaaa17bf224d9905103 100644 (file)
@@ -236,11 +236,6 @@ static void rkcanfd_chip_fifo_setup(struct rkcanfd_priv *priv)
 {
        u32 reg;
 
-       /* TXE FIFO */
-       reg = rkcanfd_read(priv, RKCANFD_REG_RX_FIFO_CTRL);
-       reg |= RKCANFD_REG_RX_FIFO_CTRL_RX_FIFO_ENABLE;
-       rkcanfd_write(priv, RKCANFD_REG_RX_FIFO_CTRL, reg);
-
        /* RX FIFO */
        reg = rkcanfd_read(priv, RKCANFD_REG_RX_FIFO_CTRL);
        reg |= RKCANFD_REG_RX_FIFO_CTRL_RX_FIFO_ENABLE;