]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
CLEANUP: peers: Remove useless test on peer variable in peer_trace()
authorChristopher Faulet <cfaulet@haproxy.com>
Mon, 15 Nov 2021 08:40:57 +0000 (09:40 +0100)
committerChristopher Faulet <cfaulet@haproxy.com>
Mon, 15 Nov 2021 08:41:00 +0000 (09:41 +0100)
A useless test on peer variable was reported by cppcheck in peer_trace().

This patch should fix the issue #1165.

src/peers.c

index 94ef22e6840310810f5a8da95fb17bbbbc3059e3..5cd2f745801fddf868c49749159a8d4082a9715a 100644 (file)
@@ -443,7 +443,7 @@ static void peers_trace(enum trace_level level, uint64_t mask,
                        const struct peer *peer = a2;
                        struct peers *peers = NULL;
 
-                       if (peer && peer->appctx) {
+                       if (peer->appctx) {
                                struct stream_interface *si;
 
                                si = peer->appctx->owner;
@@ -456,8 +456,7 @@ static void peers_trace(enum trace_level level, uint64_t mask,
 
                        if (peers)
                                chunk_appendf(&trace_buf, " %s", peers->local->id);
-                       if (peer)
-                               chunk_appendf(&trace_buf, " -> %s", peer->id);
+                       chunk_appendf(&trace_buf, " -> %s", peer->id);
                }
 
                if (a3) {