]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
NFSD: Remove a never-true comparison
authorChuck Lever <chuck.lever@oracle.com>
Thu, 17 Oct 2024 15:03:52 +0000 (11:03 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Tue, 19 Nov 2024 01:23:01 +0000 (20:23 -0500)
fh_size is an unsigned int, thus it can never be less than 0.

Fixes: d8b26071e65e ("NFSD: simplify struct nfsfh")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfsfh.c

index 871de925a3df56b990a762884a2e208fbda1203a..6a831cb242dfb2dff8a9d8fc496b84c00ffc2892 100644 (file)
@@ -766,7 +766,7 @@ char * SVCFH_fmt(struct svc_fh *fhp)
        struct knfsd_fh *fh = &fhp->fh_handle;
        static char buf[2+1+1+64*3+1];
 
-       if (fh->fh_size < 0 || fh->fh_size> 64)
+       if (fh->fh_size > 64)
                return "bad-fh";
        sprintf(buf, "%d: %*ph", fh->fh_size, fh->fh_size, fh->fh_raw);
        return buf;