]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtc: test: Also test time and wday outcome of rtc_time64_to_tm()
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Mon, 28 Apr 2025 10:06:50 +0000 (12:06 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 1 Jun 2025 22:10:18 +0000 (00:10 +0200)
To cover calculation of the time and wday in the rtc kunit test also check
tm_hour, tm_min, tm_sec and tm_wday of the rtc_time calculated by
rtc_time64_to_tm().

There are no surprises, the two tests making use of
rtc_time64_to_tm_test_date_range() continue to succeed.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
Link: https://lore.kernel.org/r/20250428-enable-rtc-v4-4-2b2f7e3f9349@baylibre.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/lib_test.c

index c0faddc04c9bbcd421cbdc030c4a073056c6a9a6..b1ac0701d42e5562b8eae5b191012c8b56a06902 100644 (file)
@@ -6,8 +6,10 @@
 /*
  * Advance a date by one day.
  */
-static void advance_date(int *year, int *month, int *mday, int *yday)
+static void advance_date(int *year, int *month, int *mday, int *yday, int *wday)
 {
+       *wday = (*wday + 1) % 7;
+
        if (*mday != rtc_month_days(*month - 1, *year)) {
                ++*mday;
                ++*yday;
@@ -43,23 +45,29 @@ static void rtc_time64_to_tm_test_date_range(struct kunit *test, int years)
        int month       = 1;
        int mday        = 1;
        int yday        = 1;
+       int wday        = 4; /* Jan 1st 1970 was a Thursday */
 
        struct rtc_time result;
        time64_t secs;
+       const time64_t sec_offset = ((1 * 60) + 2) * 60 + 3;
 
        for (secs = 0; secs <= total_secs; secs += 86400) {
 
-               rtc_time64_to_tm(secs, &result);
+               rtc_time64_to_tm(secs + sec_offset, &result);
 
-               #define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \
-                       year, month, mday, yday, secs
+               #define FAIL_MSG "%d/%02d/%02d (%2d, %d) : %lld", \
+                       year, month, mday, yday, wday, secs + sec_offset
 
                KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG);
                KUNIT_ASSERT_EQ_MSG(test, month - 1, result.tm_mon, FAIL_MSG);
                KUNIT_ASSERT_EQ_MSG(test, mday, result.tm_mday, FAIL_MSG);
                KUNIT_ASSERT_EQ_MSG(test, yday, result.tm_yday, FAIL_MSG);
+               KUNIT_ASSERT_EQ_MSG(test, 1, result.tm_hour, FAIL_MSG);
+               KUNIT_ASSERT_EQ_MSG(test, 2, result.tm_min, FAIL_MSG);
+               KUNIT_ASSERT_EQ_MSG(test, 3, result.tm_sec, FAIL_MSG);
+               KUNIT_ASSERT_EQ_MSG(test, wday, result.tm_wday, FAIL_MSG);
 
-               advance_date(&year, &month, &mday, &yday);
+               advance_date(&year, &month, &mday, &yday, &wday);
        }
 }