sound: rt5677: Cannot test unsigned for being negative

In rt5677_bic_or the call to rt5677_i2c_read returns an int so old
should also be an int to receive that value and then be able to test it
for being negative which would indicate an error.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

diff --git a/drivers/sound/rt5677.c b/drivers/sound/rt5677.c
index b5c997c6dd53407fd56c2113ca28f73c197efa22..a9d1e94951a55945b05198e98a2ccdc6de49d6fb 100644 (file)
--- a/drivers/sound/rt5677.c
+++ b/drivers/sound/rt5677.c
@@ -94,8 +94,8 @@ static int rt5677_i2c_write(struct rt5677_priv *priv, uint reg, uint data)
 static int rt5677_bic_or(struct rt5677_priv *priv, uint reg, uint bic,
                         uint set)
 {
-       uint old, new_value;
-       int ret;
+       uint new_value;
+       int old, ret;
 
        old = rt5677_i2c_read(priv, reg);
        if (old < 0)