]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: mptcp: close server file descriptors
authorGeliang Tang <tanggeliang@kylinos.cn>
Fri, 12 Sep 2025 16:36:47 +0000 (18:36 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 16 Sep 2025 01:14:22 +0000 (18:14 -0700)
The server file descriptor ('fd') is opened in server() but never closed.
While accepted connections are properly closed in process_one_client(),
the main listening socket remains open, causing a resource leak.

This patch ensures the server fd is properly closed after processing
clients, bringing the sockopt and inq test cases in line with proper
resource cleanup practices.

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250912-net-next-mptcp-minor-fixes-6-18-v1-1-99d179b483ad@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_inq.c
tools/testing/selftests/net/mptcp/mptcp_sockopt.c

index f3bcaa48df8f22e8f4833fcc3b919d21764bf7fb..40f2a1b24763e3b84e12bfae7b893c35e6c2af71 100644 (file)
@@ -502,6 +502,7 @@ static int server(int unixfd)
 
        process_one_client(r, unixfd);
 
+       close(fd);
        return 0;
 }
 
index e934dd26a59d9b50445d61e8b8013ce3c8d2a8a0..b44b6c9b05507780fa85221e61813182cf7c082e 100644 (file)
@@ -722,6 +722,7 @@ static int server(int pipefd)
 
        process_one_client(r, pipefd);
 
+       close(fd);
        return 0;
 }