]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib: net - Set ip before port in net_listen_full()
authorAki Tuomi <aki.tuomi@open-xchange.com>
Thu, 21 Apr 2022 10:43:09 +0000 (13:43 +0300)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Mon, 25 Apr 2022 11:25:00 +0000 (11:25 +0000)
sin_set_ip() sets address family which is required in sin_set_port().

In linux, sin_port and sin6_port are in same place of the sockaddr union,
so previous use did not break anything.

src/lib/net.c

index 1eb04ffd76e5968eb57a942162f10672694ade72..d960d81fa18a183c004e2f4d1cbadb7f293824b2 100644 (file)
@@ -468,8 +468,8 @@ int net_listen_full(const struct ip_addr *my_ip, in_port_t *port,
        socklen_t len;
 
        i_zero(&so);
-       sin_set_port(&so, *port);
        sin_set_ip(&so, my_ip);
+       sin_set_port(&so, *port);
 
        /* create the socket */
        fd = socket(so.sin.sin_family, SOCK_STREAM, 0);