Bug 3490: Crash writing Referer/Username logs

diff --git a/src/log/FormatSquidReferer.cc b/src/log/FormatSquidReferer.cc
index 16f8b3d17b0197194ebfea4f039f5a991d0d7727..a498af9b49aa33219af453f63bf6f9cd35b3779f 100644 (file)
--- a/src/log/FormatSquidReferer.cc
+++ b/src/log/FormatSquidReferer.cc
@@ -43,6 +43,10 @@
 void
 Log::Format::SquidReferer(AccessLogEntry *al, Logfile *logfile)
 {
+    // do not log unless there is something to be displayed
+    if (!al || !al->request)
+        return;
+
     const char *referer = al->request->header.getStr(HDR_REFERER);
 
     // do not log unless there is something to be displayed

diff --git a/src/log/FormatSquidUseragent.cc b/src/log/FormatSquidUseragent.cc
index 9eb825006f05d8a31c186e8a153c455eab9499ec..470629e1f4f49c6238fe6111a5a14eccce74f97c 100644 (file)
--- a/src/log/FormatSquidUseragent.cc
+++ b/src/log/FormatSquidUseragent.cc
@@ -43,6 +43,10 @@
 void
 Log::Format::SquidUserAgent(AccessLogEntry * al, Logfile * logfile)
 {
+    // do not log unless there is something to be displayed.
+    if (!al || !al->request)
+        return;
+
     const char *agent = al->request->header.getStr(HDR_USER_AGENT);
 
     // do not log unless there is something to be displayed.