]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fri, 17 Feb 2023 09:25:29 +0000 (17:25 +0800)
committerKalle Valo <kvalo@kernel.org>
Wed, 22 Feb 2023 12:30:04 +0000 (14:30 +0200)
Variable bcnfunc_enable is not effectively used, so delete it.

drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:1050:5: warning: variable 'bcnfunc_enable' set but not used.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4110
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230217092529.105899-1-jiapeng.chong@linux.alibaba.com
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c

index 2aecb2583f75ed3ffd609477a0213e89dd8cb380..df1e36fbc348ac123d663d6460baf94c5f829b37 100644 (file)
@@ -1047,7 +1047,6 @@ static int _rtl92de_set_media_status(struct ieee80211_hw *hw,
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        u8 bt_msr = rtl_read_byte(rtlpriv, MSR);
        enum led_ctl_mode ledaction = LED_CTL_NO_LINK;
-       u8 bcnfunc_enable;
 
        bt_msr &= 0xfc;
 
@@ -1064,31 +1063,26 @@ static int _rtl92de_set_media_status(struct ieee80211_hw *hw,
                        "Set HW_VAR_MEDIA_STATUS: No such media status(%x)\n",
                        type);
        }
-       bcnfunc_enable = rtl_read_byte(rtlpriv, REG_BCN_CTRL);
        switch (type) {
        case NL80211_IFTYPE_UNSPECIFIED:
                bt_msr |= MSR_NOLINK;
                ledaction = LED_CTL_LINK;
-               bcnfunc_enable &= 0xF7;
                rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
                        "Set Network type to NO LINK!\n");
                break;
        case NL80211_IFTYPE_ADHOC:
                bt_msr |= MSR_ADHOC;
-               bcnfunc_enable |= 0x08;
                rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
                        "Set Network type to Ad Hoc!\n");
                break;
        case NL80211_IFTYPE_STATION:
                bt_msr |= MSR_INFRA;
                ledaction = LED_CTL_LINK;
-               bcnfunc_enable &= 0xF7;
                rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
                        "Set Network type to STA!\n");
                break;
        case NL80211_IFTYPE_AP:
                bt_msr |= MSR_AP;
-               bcnfunc_enable |= 0x08;
                rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
                        "Set Network type to AP!\n");
                break;