]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
erofs: fix potential return value overflow of z_erofs_shrink_scan()
authorGao Xiang <hsiangkao@linux.alibaba.com>
Tue, 14 Jan 2025 04:00:58 +0000 (12:00 +0800)
committerGao Xiang <hsiangkao@linux.alibaba.com>
Thu, 16 Jan 2025 19:19:39 +0000 (03:19 +0800)
z_erofs_shrink_scan() could return small numbers due to the mistyped
`freed`.

Although I don't think it has any visible impact.

Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support")
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20250114040058.459981-1-hsiangkao@linux.alibaba.com
fs/erofs/zdata.c

index 19ef4ff2a1345d6716d906747334141a5c04f5d7..f416b73e0ca31ab0c21b2d9540517fbcb55ac6c7 100644 (file)
@@ -927,8 +927,7 @@ unsigned long z_erofs_shrink_scan(struct erofs_sb_info *sbi,
                                  unsigned long nr_shrink)
 {
        struct z_erofs_pcluster *pcl;
-       unsigned int freed = 0;
-       unsigned long index;
+       unsigned long index, freed = 0;
 
        xa_lock(&sbi->managed_pslots);
        xa_for_each(&sbi->managed_pslots, index, pcl) {