]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: ismt: Use non-hybrid PCI devres API
authorPhilipp Stanner <phasta@kernel.org>
Thu, 17 Apr 2025 08:25:11 +0000 (10:25 +0200)
committerAndi Shyti <andi@smida.it>
Mon, 19 May 2025 20:23:57 +0000 (22:23 +0200)
ismt enables its PCI device with pcim_enable_device(). This,
implicitly, switches the function pci_request_region() into managed
mode, where it becomes a devres function.

The PCI subsystem wants to remove this hybrid nature from its
interfaces. To do so, users of the aforementioned combination of
functions must be ported to non-hybrid functions.

Replace the call to sometimes-managed pci_request_region() with one to
the always-managed pcim_request_region().

Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://lore.kernel.org/r/20250417082511.22272-2-phasta@kernel.org
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-ismt.c

index c93c02aa6ac8cce5ae6a3898a8487ed5d2b0a9c8..7aaefb21416ab65a62f0b66e64a123ed826e9179 100644 (file)
@@ -933,7 +933,7 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id)
                return err;
        }
 
-       err = pci_request_region(pdev, SMBBAR, ismt_driver.name);
+       err = pcim_request_region(pdev, SMBBAR, ismt_driver.name);
        if (err) {
                dev_err(&pdev->dev,
                        "Failed to request SMBus region 0x%lx-0x%lx\n",