]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: camss: Point sm8250 at the correct vdda regulators
authorBryan O'Donoghue <bryan.odonoghue@linaro.org>
Tue, 11 Jan 2022 12:52:12 +0000 (13:52 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 7 Mar 2022 10:47:27 +0000 (11:47 +0100)
Reviewing the RB5 schematic its clear that we have missed out on defining
both of the power-rails associated with the CSI PHY.

Other PHYs such as the UFS, PCIe and USB connect to these rails and define
each regulator individually.

This means if we were to switch off the other various PHYs which enable
these rails, the CAMSS would not appropriately power-on the CSI PHY.

Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/qcom/camss/camss.c

index c23d7b06edb3abf498647aff93c385a1c49cdb2e..79ad82e233cb1ad59020b01016b19e15d149ae5a 100644 (file)
@@ -723,7 +723,7 @@ static const struct resources csiphy_res_8250[] = {
 static const struct resources csid_res_8250[] = {
        /* CSID0 */
        {
-               .regulators = { NULL },
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "vfe0_csid", "vfe0_cphy_rx", "vfe0", "vfe0_areg", "vfe0_ahb" },
                .clock_rate = { { 400000000 },
                                { 400000000 },
@@ -735,7 +735,7 @@ static const struct resources csid_res_8250[] = {
        },
        /* CSID1 */
        {
-               .regulators = { NULL },
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "vfe1_csid", "vfe1_cphy_rx", "vfe1", "vfe1_areg", "vfe1_ahb" },
                .clock_rate = { { 400000000 },
                                { 400000000 },
@@ -747,7 +747,7 @@ static const struct resources csid_res_8250[] = {
        },
        /* CSID2 */
        {
-               .regulators = { NULL },
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx", "vfe_lite",  "vfe_lite_ahb" },
                .clock_rate = { { 400000000 },
                                { 400000000 },
@@ -758,7 +758,7 @@ static const struct resources csid_res_8250[] = {
        },
        /* CSID3 */
        {
-               .regulators = { NULL },
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx", "vfe_lite",  "vfe_lite_ahb" },
                .clock_rate = { { 400000000 },
                                { 400000000 },