]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init()
authorMarek Behún <kabel@kernel.org>
Sat, 31 Aug 2024 09:20:46 +0000 (11:20 +0200)
committerArnd Bergmann <arnd@arndb.de>
Mon, 2 Sep 2024 09:42:10 +0000 (09:42 +0000)
Use devm_mutex_init() instead of mutex_init(), to properly call
mutex_destroy() on probe failure / driver unbind.

Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://lore.kernel.org/r/20240831092050.23093-13-kabel@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/firmware/turris-mox-rwtm.c

index d12e296250222af51a8448e5adfc82f470daebc0..9f6bda969943dc8f2a8fdb61b352b98ea317c37c 100644 (file)
@@ -456,7 +456,10 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, rwtm);
 
-       mutex_init(&rwtm->busy);
+       ret = devm_mutex_init(dev, &rwtm->busy);
+       if (ret)
+               return ret;
+
        init_completion(&rwtm->cmd_done);
 
        rwtm->mbox_client.dev = dev;