]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: stmmac: remove calls to xpcs_config_eee()
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Mon, 10 Feb 2025 10:54:00 +0000 (10:54 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 14 Feb 2025 21:42:52 +0000 (13:42 -0800)
Remove the explicit calls to xpcs_config_eee() from the stmmac driver,
preferring instead for phylink to manage the EEE configuration at the
PCS.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1thRQO-003w7I-Ap@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

index d99ff4146512d8c794c68fe1fff4f58766e4ac77..fd8ca1524e43bce612b6faadec63bb338ac93bf2 100644 (file)
@@ -1046,10 +1046,6 @@ static void stmmac_mac_disable_tx_lpi(struct phylink_config *config)
        priv->tx_path_in_lpi_mode = false;
 
        stmmac_set_eee_timer(priv, priv->hw, 0, STMMAC_DEFAULT_TWT_LS);
-       if (priv->hw->xpcs)
-               xpcs_config_eee(priv->hw->xpcs, priv->plat->mult_fact_100ns,
-                               false);
-
        mutex_unlock(&priv->lock);
 }
 
@@ -1068,9 +1064,6 @@ static int stmmac_mac_enable_tx_lpi(struct phylink_config *config, u32 timer,
 
        stmmac_set_eee_timer(priv, priv->hw, STMMAC_DEFAULT_LIT_LS,
                             STMMAC_DEFAULT_TWT_LS);
-       if (priv->hw->xpcs)
-               xpcs_config_eee(priv->hw->xpcs, priv->plat->mult_fact_100ns,
-                               true);
 
        /* Try to cnfigure the hardware timer. */
        ret = stmmac_set_lpi_mode(priv, priv->hw, STMMAC_LPI_TIMER,