]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/xe: proper setting of irq enabled flag
authorDani Liberman <dliberman@habana.ai>
Mon, 18 Sep 2023 11:48:46 +0000 (14:48 +0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:41:15 +0000 (11:41 -0500)
IRQ enabled flag should be set only after request irq succeeds.

Reviewed-by: Ohad Sharabi <osharabi@habana.ai>
Signed-off-by: Dani Liberman <dliberman@habana.ai>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_irq.c

index dec3d518b3fc4030af8e0301743c2506b6929f0b..e1126eccb50e6f2d0331f680460a90b0af0d7436 100644 (file)
@@ -579,16 +579,14 @@ int xe_irq_install(struct xe_device *xe)
                return -EINVAL;
        }
 
-       xe->irq.enabled = true;
-
        xe_irq_reset(xe);
 
        err = request_irq(irq, irq_handler,
                          IRQF_SHARED, DRIVER_NAME, xe);
-       if (err < 0) {
-               xe->irq.enabled = false;
+       if (err < 0)
                return err;
-       }
+
+       xe->irq.enabled = true;
 
        xe_irq_postinstall(xe);