]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Nov 2018 09:12:09 +0000 (10:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Nov 2018 09:12:09 +0000 (10:12 +0100)
added patches:
revert-acpica-aml-interpreter-add-region-addresses-in.patch

queue-4.19/revert-acpica-aml-interpreter-add-region-addresses-in.patch [new file with mode: 0644]
queue-4.19/series

diff --git a/queue-4.19/revert-acpica-aml-interpreter-add-region-addresses-in.patch b/queue-4.19/revert-acpica-aml-interpreter-add-region-addresses-in.patch
new file mode 100644 (file)
index 0000000..0d1bfa0
--- /dev/null
@@ -0,0 +1,56 @@
+From 4958acb345ce568e7757b5be1f1b7470c792dc2b Mon Sep 17 00:00:00 2001
+From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+Date: Tue, 20 Nov 2018 10:08:18 +0100
+Subject: Revert "ACPICA: AML interpreter: add region addresses in global list during initialization"
+
+From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+This reverts commit 22083c028d0b3ee419232d25ce90367e5b25df8f which is
+commit 4abb951b73ff0a8a979113ef185651aa3c8da19b upstream.
+
+Jean writes:
+
+       This commit was tagged with:
+
+           Link: https://bugzilla.kernel.org/show_bug.cgi?id=200011
+           Tested-by: Jean-Marc Lenoir
+           Cc: All applicable <stable@vger.kernel.org>
+
+       making it sound like it was fixing an actual bug. This is not the case.
+       The commit fixes a side issue discovered while investigating bug
+       #200011. It does NOT fix bug #200011 itself (as explicitly reported by
+       Jean-Marc at https://bugzilla.kernel.org/show_bug.cgi?id=200011#c65 ).
+
+       It does however cause regressions, despite what the commit message says. See:
+
+       https://bugzilla.kernel.org/show_bug.cgi?id=201721
+
+       and I expect more similar regressions, as ACPI resource conflicts are
+       very frequent.
+
+       This commit was not stable material to start with. It is intrusive,
+       presents a risk of side effects, and does not solve an actual bug that
+       is bothering users.
+
+Reported-by: Jean Delvare <jdelvare@suse.de>
+Cc: Jean-Marc Lenoir <archlinux@jihemel.com>
+Cc: Erik Schmauss <erik.schmauss@intel.com>
+Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/acpi/acpica/dsopcode.c |    4 ----
+ 1 file changed, 4 deletions(-)
+
+--- a/drivers/acpi/acpica/dsopcode.c
++++ b/drivers/acpi/acpica/dsopcode.c
+@@ -417,10 +417,6 @@ acpi_ds_eval_region_operands(struct acpi
+                         ACPI_FORMAT_UINT64(obj_desc->region.address),
+                         obj_desc->region.length));
+-      status = acpi_ut_add_address_range(obj_desc->region.space_id,
+-                                         obj_desc->region.address,
+-                                         obj_desc->region.length, node);
+-
+       /* Now the address and length are valid for this opregion */
+       obj_desc->region.flags |= AOPOBJ_DATA_VALID;
index d81edd8993da8b8e8a23293d9c021e8fefb06cf3..feb999fbd38b8ef8a197711108135d471f440ed2 100644 (file)
@@ -202,3 +202,4 @@ drm-i915-fix-possible-race-in-intel_dp_add_mst_connector.patch
 drm-i915-fix-null-deref-when-re-enabling-hpd-irqs-on-systems-with-mst.patch
 drm-i915-fix-hpd-handling-for-pins-with-two-encoders.patch
 config_xen_pv-breaks-xen_create_contiguous_region-on-arm.patch
+revert-acpica-aml-interpreter-add-region-addresses-in.patch