]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: rockchip: Add avdd supplies to hdmi on rock64
authorDiederik de Haas <didi.debian@cknow.org>
Thu, 4 Jul 2024 19:18:33 +0000 (21:18 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 8 Jul 2024 14:25:35 +0000 (16:25 +0200)
Pine64's Rock64 was missing the avdd supply properties on the hdmi node,
causing the following warnings:

  dwhdmi-rockchip ff3c0000.hdmi: supply avdd-0v9 not found, using dummy regulator
  dwhdmi-rockchip ff3c0000.hdmi: supply avdd-1v8 not found, using dummy regulator

In the Rock64 Schematic document version 2.0 those supplies are marked
as DVIDEO_AVDD_1V0 and DVIDEO_AVDD_1V8 respectively, but in version 3.0
those are named HDMI_AVDD_1V0 and HDMI_AVDD_1V8, which is a bit clearer.
In both versions those are connected to LDO3 and LDO1 respectively.

While the DeviceTree property is named 'avdd-0v9-supply' the
'rockchip,dw-hdmi.yaml' binding document notes the following:

  A 0.9V supply that powers up the SoC internal circuitry. The actual
  pin name varies between the different SoCs and is usually
  HDMI_TX_AVDD_0V9 or sometimes HDMI_AVDD_1V0.

So the 'vdd_10' reference is not an error.

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Link: https://lore.kernel.org/r/20240704191919.38856-1-didi.debian@cknow.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts

index 229fe9da9c2ddc1e31ac662a6996424efe78d64e..90fef766f3ae1450398bf196ec76e16efec24379 100644 (file)
 };
 
 &hdmi {
+       avdd-0v9-supply = <&vdd_10>;
+       avdd-1v8-supply = <&vcc_18>;
        status = "okay";
 };