Bug 3226: Tags from external ACLs do not correctly expire

diff --git a/src/external_acl.cc b/src/external_acl.cc
index c661e5de7f9cd1b48f6fbd20ad54b7765cbc3e1a..516404da4eeb03e3959bb49058e3ff6015f1ca40 100644 (file)
--- a/src/external_acl.cc
+++ b/src/external_acl.cc
@@ -800,12 +800,9 @@ aclMatchExternal(external_acl_data *acl, ACLFilledChecklist *ch)
 
             if (acl->def->theHelper->stats.queue_size <= (int)acl->def->theHelper->childs.n_active) {
                 debugs(82, 2, "aclMatchExternal: \"" << key << "\": queueing a call.");
-                ch->changeState (ExternalACLLookup::Instance());
-
-                if (entry == NULL) {
-                    debugs(82, 2, "aclMatchExternal: \"" << key << "\": return -1.");
-                    return -1;
-                }
+                ch->changeState(ExternalACLLookup::Instance());
+                debugs(82, 2, "aclMatchExternal: \"" << key << "\": return -1.");
+                return -1; // to get here we have to have an expired cache entry. MUST not use.
             } else {
                 if (!entry) {
                     debugs(82, 1, "aclMatchExternal: '" << acl->def->name <<