media: i2c: ov02a10: Use V4L2 legacy sensor clock helper

Several camera sensor drivers access the "clock-frequency" property
directly to retrieve the external clock rate, or modify the clock rate
of the external clock programmatically. Both behaviours are valid on a
subset of ACPI platforms, but are considered deprecated on OF platforms,
and do not support ACPI platforms that implement MIPI DisCo for Imaging.
Implementing them manually in drivers is deprecated, as that can
encourage copying deprecated behaviour for OF platforms in new drivers,
and lead to differences in behaviour between drivers. Instead, drivers
that need to preserve the deprecated OF behaviour should use the
devm_v4l2_sensor_clk_get_legacy() helper.

This driver supports OF platforms only. The "clocks" and
"clock-frequency" properties were initially mandatory in the DT
bindings. The driver retrieves the clock, retrieves the clock rate from
the "clock-frequency" property, and sets the clock rate to the retrieved
rate. If the rate does not match one of the expected rates, the driver
fails probing. This is deprecated behaviour for OF.

Switch to using the devm_v4l2_sensor_clk_get_legacy() helper. This
preserves setting the clock rate on OF platforms. Should support for OF
platforms that set the clock rate through clock-frequency be considered
unneeded in the future, the driver will only need to switch to
devm_v4l2_sensor_clk_get() without any other change.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c
index 6217164a749213b61e9839a40f47d01b34fcc9b4..70d9d7c43f1874e37b8c1115f4ba019b28143cd2 100644 (file)
--- a/drivers/media/i2c/ov02a10.c
+++ b/drivers/media/i2c/ov02a10.c
@@ -102,7 +102,6 @@ struct ov02a10_mode {
 struct ov02a10 {
        struct device *dev;
 
-       u32 eclk_freq;
        /* Indication of MIPI transmission speed select */
        u32 mipi_clock_voltage;
 
@@ -886,22 +885,11 @@ static int ov02a10_probe(struct i2c_client *client)
                ov02a10->fmt.code = MEDIA_BUS_FMT_SRGGB10_1X10;
        }
 
-       ov02a10->eclk = devm_v4l2_sensor_clk_get(dev, "eclk");
+       ov02a10->eclk = devm_v4l2_sensor_clk_get_legacy(dev, "eclk", false, 0);
        if (IS_ERR(ov02a10->eclk))
                return dev_err_probe(dev, PTR_ERR(ov02a10->eclk),
                                     "failed to get eclk\n");
 
-       ret = device_property_read_u32(dev, "clock-frequency",
-                                      &ov02a10->eclk_freq);
-       if (ret < 0)
-               return dev_err_probe(dev, ret,
-                                    "failed to get eclk frequency\n");
-
-       ret = clk_set_rate(ov02a10->eclk, ov02a10->eclk_freq);
-       if (ret < 0)
-               return dev_err_probe(dev, ret,
-                                    "failed to set eclk frequency (24MHz)\n");
-
        if (clk_get_rate(ov02a10->eclk) != OV02A10_ECLK_FREQ)
                dev_warn(dev, "eclk mismatched, mode is based on 24MHz\n");